Copy Modifiers sets Data Transfer mapping incorrectly #100472

New Issue

Jan Kadeřábek · 2022-08-17T23:49:23+02:00

Jan Kadeřábek commented

2022-08-17 23:49:23 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-07-31 21:46, hash: ca172677b1
Worked: Probably never?

Short description of error
Link / Transfer Data (Ctrl L) -> Copy Modifiers seems to be using layers indices (instead of names) to set Data Transfer layer mapping (specifically layers_vcol_loop_select_dst).
As the result, if target (selected) objects use different layer indices, the mapping in created modifiers won't match.

Exact steps for others to reproduce the error
copy_modifier_layers_mapping_bug.blend

Open the attached .blend, there are 2 cubes, both having layers with the same name, just with flipped indices.
Copy the modifier by extending the selection to Cube1 (make active), Ctrl L -> Copy Modifiers.
Check the Data Transfer created on Cube2 and it's colors layers mapping - you can see the destination layer is different from the one in Cube1 Data Transfer

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-07-31 21:46, hash: `ca172677b1` Worked: Probably never? **Short description of error** Link / Transfer Data (Ctrl L) -> Copy Modifiers seems to be using layers indices (instead of names) to set Data Transfer layer mapping (specifically *layers_vcol_loop_select_dst*). As the result, if target (selected) objects use different layer indices, the mapping in created modifiers won't match. **Exact steps for others to reproduce the error** [copy_modifier_layers_mapping_bug.blend](https://archive.blender.org/developer/F13398202/copy_modifier_layers_mapping_bug.blend) - Open the attached .blend, there are 2 cubes, both having layers with the same name, just with flipped indices. - Copy the modifier by extending the selection to Cube1 (make active), Ctrl L -> Copy Modifiers. - Check the Data Transfer created on Cube2 and it's colors layers mapping - you can see the destination layer is different from the one in Cube1 Data Transfer

Jan Kadeřábek commented

2022-08-17 23:49:23 +02:00

Added subscriber: @JanKaderabek

Pratik Borhade commented

2022-08-18 06:23:43 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-08-18 06:23:43 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Pratik Borhade closed this issue

2022-08-18 06:23:43 +02:00

Pratik Borhade commented

2022-08-18 06:23:43 +02:00

In #84152#1086544, @mont29 wrote:
DataTransfer stores its operating layers as indices, there is nothing to be done here, and not a bug in any case

Hi, thanks for the report. As said in the above comment and in your report description, modifier uses indices and not the name
This is not a bug so closing your report. Feel free to comment if there is misunderstanding. I'll reopen the report in that case

> In #84152#1086544, `@mont29` wrote: > DataTransfer stores its operating layers as indices, there is nothing to be done here, and not a bug in any case Hi, thanks for the report. As said in the above comment and in your report description, modifier uses indices and not the name This is not a bug so closing your report. Feel free to comment if there is misunderstanding. I'll reopen the report in that case

Jan Kadeřábek commented

2022-08-18 12:44:00 +02:00

Hi,
from the user standpoint I still consider this as a bug, as the result is not what user expects (it took some hours to even advanced user like me, to find out why my script which uses Link -> Copy Modifiers doesn't set mapping correctly).
Users work with layer names, not indices - I believe most users even don't know something like layer index exists, and even if they do, they can't manage them anyway.

If some action (like Copy Modifiers) gives unexpected results only because different layers order (which isn't even manageable), it should be considered as a bug in my opinion, despite it makes sense technically.
Even in Python you set dst and src layers by name.

Hi, from the user standpoint I still consider this as a bug, as the result is not what user expects (it took some hours to even advanced user like me, to find out why my script which uses Link -> Copy Modifiers doesn't set mapping correctly). Users work with layer names, not indices - I believe most users even don't know something like layer index exists, and even if they do, they can't manage them anyway. If some action (like Copy Modifiers) gives unexpected results only because different layers order (which isn't even manageable), it should be considered as a bug in my opinion, despite it makes sense technically. Even in Python you set *dst* and *src* layers by name.

Pratik Borhade commented

2022-08-18 12:49:43 +02:00

Changed status from 'Archived' to: 'Needs Triage'

Pratik Borhade reopened this issue

2022-08-18 12:49:43 +02:00

Richard Antalik commented

2022-08-18 13:44:47 +02:00

Added subscriber: @iss

Richard Antalik commented

2022-08-18 13:44:47 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Richard Antalik closed this issue

2022-08-18 13:44:47 +02:00

Richard Antalik commented

2022-08-18 13:44:47 +02:00

Unfortunately due to number of existing bugs we use strict definition of what bug is. I appreciate the report and would agree, that it could work better, But this is a request for improved behavior and not a bug in current behavior. This bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests
For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Unfortunately due to number of existing bugs we use strict definition of what bug is. I appreciate the report and would agree, that it could work better, But this is a request for improved behavior and not a bug in current behavior. This bug tracker is only for bugs and errors. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Jan Kadeřábek commented

2022-08-18 14:34:30 +02:00

We have a narrow view of what is considered a bug, typically this is limited to something that doesn't work as intended.
Is it intended that Copy Modifiers creates modifiers with different settings?
But I understand there are more important issues to fix.
Thanks for your time anyway.

*We have a narrow view of what is considered a bug, typically this is limited to something that doesn't work as intended*. Is it intended that Copy Modifiers creates modifiers with different settings? But I understand there are more important issues to fix. Thanks for your time anyway.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Copy Modifiers sets Data Transfer mapping incorrectly #100472