Keyframing Corner pinning in compositing is inconsistent #101516

New Issue

Angelo Ignotus · 2022-10-01T10:55:07+02:00

Angelo Ignotus commented

2022-10-01 10:55:07 +02:00

System Information
Operating system: windows 10
Graphics card: Nvidia geforce GTX 1050 Ti

Blender Version
Broken: 3.3.0

Short description of error
When using the background X symbols to drag and drop corners with corner pinning, only the topmost value of each vector is keyframed
Example image(wanted to edit a meme):

Exact steps for others to reproduce the error

Open attached file
Single Render to Update Compositor
Move the Corner Pins
or
Arrange nodes as seen.

{F13601679}

Select the corner pin node
Try to keyframe the location of the second image/video, using auto keyframes and the background viewport manipulators.
Only the topmost (X) value gets keyframed

Corner pin.blend

**System Information** Operating system: windows 10 Graphics card: Nvidia geforce GTX 1050 Ti **Blender Version** Broken: 3.3.0 **Short description of error** When using the background X symbols to drag and drop corners with corner pinning, only the topmost value of each vector is keyframed Example image(wanted to edit a meme): ![image.png](https://archive.blender.org/developer/F13601668/image.png) **Exact steps for others to reproduce the error** - Open attached file - Single Render to Update Compositor - Move the Corner Pins or - Arrange nodes as seen. ``` {F13601679} ``` - Select the corner pin node - Try to keyframe the location of the second image/video, using auto keyframes and the background viewport manipulators. Only the topmost (X) value gets keyframed [Corner pin.blend](https://archive.blender.org/developer/F13609600/Corner_pin.blend)

Angelo Ignotus commented

2022-10-01 10:55:07 +02:00

Added subscriber: @Rokonuxa

Pratik Borhade commented

2022-10-03 04:06:36 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-10-03 04:06:36 +02:00

Hi, thanks for the report. I'm not able to redo this. AFAICS all are keyframed correctly (tested in latest 3.4 build).
Are you able to reproduce it from scratch? Can you upload your .blend?

Hi, thanks for the report. I'm not able to redo this. AFAICS all are keyframed correctly (tested in latest 3.4 build). Are you able to reproduce it from scratch? Can you upload your .blend?

Pratik Borhade commented

2022-10-03 04:06:43 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Angelo Ignotus commented

2022-10-03 11:55:50 +02:00

If it is fixed in 3.4, thats fine. I had the issue in 3.3
If you cannot reproduce it in 3.3, then something may be weird.
Simply set up nodes as seen, the images or textures used are irellevant, then enable auto keyframing (1), select the corner pin node (2), then move these X's around (3)

they move properly, but the keyframing only happens for the X coordinate.

got you the file anyways, but again, if 3.4 fixed it thats fine.
Corner pin.blend

If it is fixed in 3.4, thats fine. I had the issue in 3.3 If you cannot reproduce it in 3.3, then something may be weird. Simply set up nodes as seen, the images or textures used are irellevant, then enable auto keyframing (1), select the corner pin node (2), then move these X's around (3) ![image.png](https://archive.blender.org/developer/F13609582/image.png) they move properly, but the keyframing only happens for the X coordinate. ![image.png](https://archive.blender.org/developer/F13609590/image.png) got you the file anyways, but again, if 3.4 fixed it thats fine. [Corner pin.blend](https://archive.blender.org/developer/F13609600/Corner_pin.blend)

Pratik Borhade commented

2022-10-20 07:52:48 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Germano Cavalcante commented

2022-10-20 17:33:33 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-10-20 17:33:33 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2022-10-20 17:33:33 +02:00

I can confirm the problem

Sergey Sharybin commented

2022-11-10 17:19:35 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2022-11-10 17:19:35 +01:00

This is more for the UI (Gizmo) code than to the VFX & Video.

It seems that the issue is in the WM_gizmo_target_property_anim_autokey which has an explicit code to restrict array properties to only first array index. I am not sure why this is so, or is it just an oversight where intent was to force index of 0 for scalar properties or something.

This is more for the UI (Gizmo) code than to the VFX & Video. It seems that the issue is in the `WM_gizmo_target_property_anim_autokey` which has an explicit code to restrict array properties to only first array index. I am not sure why this is so, or is it just an oversight where intent was to force index of 0 for scalar properties or something.

Germano Cavalcante commented

2022-11-10 19:02:55 +01:00

Added subscriber: @ideasman42

Germano Cavalcante commented

2022-11-10 19:02:56 +01:00

The Auto-keyframe feature for gizmos, along with the explicit code to restrict array properties, has been implemented in 1e0b790364.
So @ideasman42 must know why?

Removing the restriction seems to fix the bug:

diff --git a/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c b/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c
index 9f0506f209b..0c7666526b9 100644
--- a/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c
+++ b/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c
@@ -344,8 +344,7 @@ void WM_gizmo_target_property_anim_autokey(bContext *C,
   if (gz_prop->prop != NULL) {
     Scene *scene = CTX_data_scene(C);
     const float cfra = (float)scene->r.cfra;
-    const int index = gz_prop->index == -1 ? 0 : gz_prop->index;
-    ED_autokeyframe_property(C, scene, &gz_prop->ptr, gz_prop->prop, index, cfra, false);
+    ED_autokeyframe_property(C, scene, &gz_prop->ptr, gz_prop->prop, gz_prop->index, cfra, false);
   }
 }

The `Auto-keyframe` feature for gizmos, along with the explicit code to restrict array properties, has been implemented in 1e0b790364. So @ideasman42 must know why? Removing the restriction seems to fix the bug: ``` diff --git a/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c b/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c index 9f0506f209b..0c7666526b9 100644 --- a/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c +++ b/source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c @@ -344,8 +344,7 @@ void WM_gizmo_target_property_anim_autokey(bContext *C, if (gz_prop->prop != NULL) { Scene *scene = CTX_data_scene(C); const float cfra = (float)scene->r.cfra; - const int index = gz_prop->index == -1 ? 0 : gz_prop->index; - ED_autokeyframe_property(C, scene, &gz_prop->ptr, gz_prop->prop, index, cfra, false); + ED_autokeyframe_property(C, scene, &gz_prop->ptr, gz_prop->prop, gz_prop->index, cfra, false); } } ```

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keyframing Corner pinning in compositing is inconsistent #101516