Baked f-curves display incorrectly when normalized #102218

Closed
opened 2022-11-02 00:49:43 +01:00 by Colin Basnett · 6 comments
Member

System Information
Operating system: Windows 11
Graphics card: NVIDIA RTX 3060 Ti

Blender Version
Broken: 3.3.0, 3.4.0 etc.
Worked: Unknown

After baking an f-curve, it no longer displays correctly when trying to displaying Normalized f-curves, since the values fall well outside the [-1.0, 1.0] range on the graph.

bakedcurvenormalizedbug.mp4

Exact steps for others to reproduce the error

  1. Open the attached file.
  2. Go to Key -> Bake Curve.
  3. Observe that the curves are well outside the normalized range.

badbake.blend

**System Information** Operating system: Windows 11 Graphics card: NVIDIA RTX 3060 Ti **Blender Version** Broken: 3.3.0, 3.4.0 etc. Worked: Unknown After baking an f-curve, it no longer displays correctly when trying to displaying Normalized f-curves, since the values fall well outside the [-1.0, 1.0] range on the graph. [bakedcurvenormalizedbug.mp4](https://archive.blender.org/developer/F13836666/bakedcurvenormalizedbug.mp4) **Exact steps for others to reproduce the error** 1. Open the attached file. 2. Go to Key -> Bake Curve. 3. Observe that the curves are well outside the normalized range. [badbake.blend](https://archive.blender.org/developer/F13836680/badbake.blend)
Author
Member

Added subscriber: @cmbasnett

Added subscriber: @cmbasnett
Author
Member

I had a look at the code where this seems to be falling over. The problem seems to be that normalization_factor_get in anim_draw.c doesn't even really take into account baked curves at all, so the scaling values ends up being a fallback. I have thrown together some code that fixes this. I will post a diff as soon as it's cleaned up and thoroughly tested.

I had a look at the code where this seems to be falling over. The problem seems to be that `normalization_factor_get` in `anim_draw.c` doesn't even really take into account baked curves at all, so the scaling values ends up being a fallback. I have thrown together some code that fixes this. I will post a diff as soon as it's cleaned up and thoroughly tested.
Colin Basnett changed title from Baked f-curves display incorrectly when use_normalization is eabled to Baked f-curves display incorrectly when normalized is enabled 2022-11-02 05:37:57 +01:00
Colin Basnett changed title from Baked f-curves display incorrectly when normalized is enabled to Baked f-curves display incorrectly when normalized 2022-11-02 05:39:58 +01:00
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Colin Basnett was assigned by Pratik Borhade 2022-11-02 08:05:59 +01:00
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

This issue was referenced by 11a705c2d0

This issue was referenced by 11a705c2d003854ac21d81ea3261a6c9dc804a70
Author
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#102218
No description provided.