Group Index input for the fill curve node #102285

New Issue

Hans Goudey · 2022-11-05T10:52:52+01:00

Hans Goudey commented

2022-11-05 10:52:52 +01:00

Add a "Group ID" integer input to the node, evaluated on the curve domain.
This will allow limiting intersections between separate curves, which can be helpful
as a performance optimization and for a simpler result.

The default value should be a single value of zero, and the number button should be hidden on the node.
To fill each curve separately, the "Index" node can be connected the group index.

Implementation

The filling function do_cdt can have a new IndexMask argument
This is similar to the sample curve node which uses a MultiValueMap to find groups of related indices
When the group index is a single value, creating the full IndexMask and map can be skipped
The total size of the mesh should be calculated based on all of the intersection results, then the results can be converted directly into subsets of the output mesh

Add a "Group ID" integer input to the node, evaluated on the curve domain. This will allow limiting intersections between separate curves, which can be helpful as a performance optimization and for a simpler result. The default value should be a single value of zero, and the number button should be hidden on the node. To fill each curve separately, the "Index" node can be connected the group index. **Implementation** - The filling function `do_cdt` can have a new `IndexMask` argument - This is similar to the sample curve node which uses a `MultiValueMap` to find groups of related indices - When the group index is a single value, creating the full `IndexMask` and map can be skipped - The total size of the mesh should be calculated based on all of the intersection results, then the results can be converted directly into subsets of the output mesh

Hans Goudey commented

2022-11-05 10:52:52 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2022-11-05 10:52:52 +01:00

Added subscriber: @HooglyBoogly

Iliya Katushenock commented

2022-11-05 11:04:50 +01:00

Added subscriber: @mod_moder

Pratik Borhade commented

2022-11-05 13:41:40 +01:00

Added subscriber: @PratikPB2123

swesik commented

2022-11-13 22:55:15 +01:00

Added subscriber: @Swesik-Ramineni

swesik commented

2022-11-13 22:55:15 +01:00

Hello, I'm brand new to the Blender developer community and was hoping to work on this issue, but I was confused about a few points. What exactly is the "Group Index", how does it relate to the IndexMask, and what are these supposed to do in do_cdt exactly? Thank you in advance for any guidance.

Iliya Katushenock commented

2022-11-13 23:08:41 +01:00

@Swesik-Ramineni The group index is the key that the individual curves have. By concatenating the indices of curves with the same key into one array to obtain from its IndexMask (standert iterator factory, what know span of indices), we can iterate over all curves of single key. Due to this, it is possible to split all curves into several IndexMask and generate for each key its own instance - geometry from a set of filled curves.

@Swesik-Ramineni The group index is the key that the individual curves have. By concatenating the indices of curves with the same key into one array to obtain from its `IndexMask` (standert iterator factory, what know span of indices), we can iterate over all curves of single key. Due to this, it is possible to split all curves into several `IndexMask` and generate for each key its own instance - geometry from a set of filled curves.

swesik commented

2022-11-14 00:55:40 +01:00

Thank you so much for the response. Just to clarify, for each index in IndexMask, I should append the evaluated points of the curve at that index to a new curve, which I pass as an input to delaunay_2d_calc?

Iliya Katushenock commented

2022-11-14 08:09:25 +01:00

Thank you so much for the response. Just to clarify, for each index in IndexMask, I should append the evaluated points of the curve at that index to a new curve, which I pass as an input to delaunay_2d_calc?

The whole task is reduced to sweeping this iterator constructor over the entire list of curves (index_range) to an external IndexMask pointing to the list of curves belonging to the group.

{https://developer.blender.org/diffusion/B/browse/master/source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc$53}

(Of course, this is only a cursory answer to the question. I'm afraid if you write down everything that needs to be changed, then it will just be a diff patch to implement this)

> Thank you so much for the response. Just to clarify, for each index in IndexMask, I should append the evaluated points of the curve at that index to a new curve, which I pass as an input to delaunay_2d_calc? The whole task is reduced to sweeping this iterator constructor over the entire list of curves (`index_range`) to an external `IndexMask` pointing to the list of curves belonging to the group. {https://developer.blender.org/diffusion/B/browse/master/source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc$53} (Of course, this is only a cursory answer to the question. I'm afraid if you write down everything that needs to be changed, then it will just be a diff patch to implement this)

Iliya Katushenock commented

2022-11-14 08:29:08 +01:00

@Swesik-Ramineni Also, if you have any more questions, you can always ask them in the geometry nodes chat to those who are online there (me, hans, and others)

swesik self-assigned this 2022-11-15 01:45:28 +01:00

Emilis Baltrusaitis commented

2022-11-16 01:26:48 +01:00

Added subscriber: @emilis

swesik was unassigned by Hans Goudey

2023-01-18 21:57:51 +01:00

Douglas Paul commented

2023-10-16 04:03:54 +02:00

FYI, I've picked this up, and I believe I have it working locally for regular curves. I just need to extend the behavior to grease pencil curves, since the Fill Curve node recently gained support for those via #113602.

Douglas Paul commented

2023-10-16 06:35:15 +02:00

Ack, I'm not able to create a test .blend file for the grease pencil because GPv3 is currently very broken on MacOS: #113601

I get the sense that's not expected to be fixed particularly soon, so I will see if I can get someone else to create a simple test file for me.

Ack, I'm not able to create a test `.blend` file for the grease pencil because GPv3 is currently very broken on MacOS: #113601 I get the sense that's not expected to be fixed particularly soon, so I will see if I can get someone else to create a simple test file for me.

Douglas Paul referenced this issue

2023-10-17 03:10:26 +02:00

GPv3 not rendering on macOS #113601

Douglas Paul referenced this issue

2023-10-23 06:11:11 +02:00

Geometry Nodes: Add a 'Group ID' input to the Fill Curve node #114048

Douglas Paul commented

2023-10-23 06:20:00 +02:00

I was able to work around the current GPv3 issues on MacOS well enough to be able to verify my implementation works for GPv3. The PR is #114048.

Hans Goudey referenced this issue from a commit

2023-11-14 11:23:29 +01:00

Geometry Nodes: Add a Group ID input to the Fill Curve node