Regression: Grease pencil: applying armature does not work. It is now similar to removing the armature modifier #103234

New Issue

Tim · 2022-12-15T08:00:24+01:00

Tim commented

2022-12-15 08:00:24 +01:00

Hi! First of all thank you for your great job!

System Information
Operating system: Windows 11
Graphics card: NVIDIA GeForce RTX 2080 SUPER

Blender Version
Broken: 3.4.0, 3.3.0, 3.2.0
Worked: 3.1.2

Caused by cff6eb6580.

Short description of error
The applying armature doesn't work for grease pencil. It is now similar to removing the armature modifier

Exact steps for others to reproduce the error

Create grease pencil with two strokes.
Create armature with two bones chain.
Assing each stroke to its bone.
Make some pose - rotate one of the bone.
Apply the armature modifier.
Result is similar to removing the modifier - all strokes will return to initial poses.

#103234.blend

Best wishes,
Tim

Hi! First of all thank you for your great job! **System Information** Operating system: Windows 11 Graphics card: NVIDIA GeForce RTX 2080 SUPER **Blender Version** Broken: 3.4.0, 3.3.0, 3.2.0 Worked: 3.1.2 Caused by cff6eb6580. **Short description of error** The applying armature doesn't work for grease pencil. It is now similar to removing the armature modifier **Exact steps for others to reproduce the error** 1. Create grease pencil with two strokes. 2. Create armature with two bones chain. 3. Assing each stroke to its bone. 4. Make some pose - rotate one of the bone. 5. Apply the armature modifier. Result is similar to removing the modifier - all strokes will return to initial poses. ![image.png](https://archive.blender.org/developer/F14058665/image.png) ![image.png](https://archive.blender.org/developer/F14058681/image.png) ![image.png](https://archive.blender.org/developer/F14058685/image.png) [#103234.blend](https://archive.blender.org/developer/F14058745/T103234.blend) Best wishes, Tim

Tim commented

2022-12-15 08:00:25 +01:00

Added subscriber: @Tim-Kravchenko

Philipp Oeser commented

2022-12-15 08:38:25 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-12-15 08:38:25 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-12-15 08:38:25 +01:00

Can confirm, will check

Broken: all versions.

Not true, this was working in 3.1.2

Can confirm, will check > Broken: all versions. Not true, this was working in 3.1.2

Tim commented

2022-12-15 08:56:32 +01:00

In #103234#1460832, @lichtwerk wrote:
Can confirm, will check

Broken: all versions.

Not true, this was working in 3.1.2

Thanks, @lichtwerk! I checked only 3.3.0 and 3.4.0. So I thought it never worked)

> In #103234#1460832, @lichtwerk wrote: > Can confirm, will check > >> Broken: all versions. > Not true, this was working in 3.1.2 Thanks, @lichtwerk! I checked only 3.3.0 and 3.4.0. So I thought it never worked)

Aleš Jelovčan commented

2022-12-15 09:07:20 +01:00

Added subscribers: @antoniov, @frogstomp-4

Aleš Jelovčan commented

2022-12-15 09:07:20 +01:00

@lichtwerk there was a change in applying layer transformation in 3.2: https://developer.blender.org/D14844
Possible cause maybe?
cc @antoniov

@lichtwerk there was a change in applying layer transformation in 3.2: https://developer.blender.org/D14844 Possible cause maybe? cc @antoniov

Philipp Oeser commented

2022-12-15 09:09:31 +01:00

@frogstomp-4 : think it is something else that broke this, will bisect...

Antonio Vazquez commented

2022-12-15 09:19:31 +01:00

In #103234#1460843, @frogstomp-4 wrote:
@lichtwerk there was a change in applying layer transformation in 3.2: https://developer.blender.org/D14844
Possible cause maybe?
cc @antoniov

This patch was for bake animation and it's not related to this modifier.

> In #103234#1460843, @frogstomp-4 wrote: > @lichtwerk there was a change in applying layer transformation in 3.2: https://developer.blender.org/D14844 > Possible cause maybe? > cc @antoniov This patch was for bake animation and it's not related to this modifier.

Philipp Oeser commented

2022-12-15 09:35:49 +01:00

Caused by cff6eb6580.
Seems like the armature modifier needs to do this with the original bGPdata (it passes the evaluated object to generic_bake_deform_stroke though)

Caused by cff6eb6580. Seems like the armature modifier needs to do this with the **original** bGPdata (it passes the **evaluated** object to `generic_bake_deform_stroke` though)

Philipp Oeser changed title from ~~Grease pencil: applying armature does not work. It is now similar to removing the armature modifier~~ to Regression: Grease pencil: applying armature does not work. It is now similar to removing the armature modifier

2022-12-15 09:38:43 +01:00

Philipp Oeser commented

2022-12-15 09:46:03 +01:00

Havent checked why this mixture of original and evaluated is needed (in fact, it doesnt seem like this is actually needed, see second example), but here are two changes that potentionally "fix":



diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c b/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c
index d4ada842d0b..a5d13796249 100644
--- a/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c
+++ b/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c
@@ -178,9 +178,10 @@ void generic_bake_deform_stroke(
 {
   Scene *scene = DEG_get_evaluated_scene(depsgraph);
   bGPdata *gpd = ob->data;
+  bGPdata *gpd_orig = (bGPdata *)DEG_get_original_id(&gpd->id);
   int oldframe = (int)DEG_get_ctime(depsgraph);
 
-  LISTBASE_FOREACH (bGPDlayer *, gpl, &gpd->layers) {
+  LISTBASE_FOREACH (bGPDlayer *, gpl, &gpd_orig->layers) {
     LISTBASE_FOREACH (bGPDframe *, gpf, &gpl->frames) {
       if (retime) {
         scene->r.cfra = gpf->framenum;



diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c
index d99d9950efb..5163f4d7020 100644
--- a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c
+++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c
@@ -118,14 +118,12 @@ static void bakeModifier(Main *UNUSED(bmain),
                          GpencilModifierData *md,
                          Object *ob)
 {
-  Object *object_eval = DEG_get_evaluated_object(depsgraph, ob);
   ArmatureGpencilModifierData *mmd = (ArmatureGpencilModifierData *)md;
-  GpencilModifierData *md_eval = BKE_gpencil_modifiers_findby_name(object_eval, md->name);
 
   if (mmd->object == NULL) {
     return;
   }
-  generic_bake_deform_stroke(depsgraph, md_eval, object_eval, true, deformStroke);
+  generic_bake_deform_stroke(depsgraph, md, ob, true, deformStroke);
 }
 
 static bool isDisabled(GpencilModifierData *md, int UNUSED(userRenderParams))

Havent checked why this mixture of original and evaluated is needed (in fact, it doesnt seem like this is actually needed, see second example), but here are two changes that potentionally "fix": ``` diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c b/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c index d4ada842d0b..a5d13796249 100644 --- a/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c +++ b/source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c @@ -178,9 +178,10 @@ void generic_bake_deform_stroke( { Scene *scene = DEG_get_evaluated_scene(depsgraph); bGPdata *gpd = ob->data; + bGPdata *gpd_orig = (bGPdata *)DEG_get_original_id(&gpd->id); int oldframe = (int)DEG_get_ctime(depsgraph); - LISTBASE_FOREACH (bGPDlayer *, gpl, &gpd->layers) { + LISTBASE_FOREACH (bGPDlayer *, gpl, &gpd_orig->layers) { LISTBASE_FOREACH (bGPDframe *, gpf, &gpl->frames) { if (retime) { scene->r.cfra = gpf->framenum; ``` ``` diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c index d99d9950efb..5163f4d7020 100644 --- a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c +++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c @@ -118,14 +118,12 @@ static void bakeModifier(Main *UNUSED(bmain), GpencilModifierData *md, Object *ob) { - Object *object_eval = DEG_get_evaluated_object(depsgraph, ob); ArmatureGpencilModifierData *mmd = (ArmatureGpencilModifierData *)md; - GpencilModifierData *md_eval = BKE_gpencil_modifiers_findby_name(object_eval, md->name); if (mmd->object == NULL) { return; } - generic_bake_deform_stroke(depsgraph, md_eval, object_eval, true, deformStroke); + generic_bake_deform_stroke(depsgraph, md, ob, true, deformStroke); } static bool isDisabled(GpencilModifierData *md, int UNUSED(userRenderParams)) ```

Antonio Vazquez commented

2022-12-15 10:46:15 +01:00

@lichtwerk The right fix is this:

diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c
index d99d9950efb..5163f4d7020 100644
--- a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c
+++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c
@@ -118,14 +118,12 @@ static void bakeModifier(Main *UNUSED(bmain),
                          GpencilModifierData *md,
                          Object *ob)
 {
-  Object *object_eval = DEG_get_evaluated_object(depsgraph, ob);
   ArmatureGpencilModifierData *mmd = (ArmatureGpencilModifierData *)md;
-  GpencilModifierData *md_eval = BKE_gpencil_modifiers_findby_name(object_eval, md->name);
 
   if (mmd->object == NULL) {
     return;
   }
-  generic_bake_deform_stroke(depsgraph, md_eval, object_eval, true, deformStroke);
+  generic_bake_deform_stroke(depsgraph, md, ob, true, deformStroke);
 }
 
 static bool isDisabled(GpencilModifierData *md, int UNUSED(userRenderParams))

@lichtwerk The right fix is this: ``` diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c index d99d9950efb..5163f4d7020 100644 --- a/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c +++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c @@ -118,14 +118,12 @@ static void bakeModifier(Main *UNUSED(bmain), GpencilModifierData *md, Object *ob) { - Object *object_eval = DEG_get_evaluated_object(depsgraph, ob); ArmatureGpencilModifierData *mmd = (ArmatureGpencilModifierData *)md; - GpencilModifierData *md_eval = BKE_gpencil_modifiers_findby_name(object_eval, md->name); if (mmd->object == NULL) { return; } - generic_bake_deform_stroke(depsgraph, md_eval, object_eval, true, deformStroke); + generic_bake_deform_stroke(depsgraph, md, ob, true, deformStroke); } static bool isDisabled(GpencilModifierData *md, int UNUSED(userRenderParams)) ```

blender-admin commented

2022-12-15 10:52:58 +01:00

This issue was referenced by 6aacbdd716

This issue was referenced by 6aacbdd716fa979f2d02ae2b7c0fcb2fdc0554e4

blender-admin commented

2022-12-15 10:52:58 +01:00

This issue was referenced by d4a6108ef2

This issue was referenced by d4a6108ef292ee43aa0d5315fdcfd51c9a5da629

blender-admin commented

2022-12-15 10:52:58 +01:00

This issue was referenced by e0ef5f3602

This issue was referenced by e0ef5f360222148d52e68d820df499dd6da5ce8a