GeoNodes: Attributes inputs aren't overridable #103785

Open
opened 2023-01-10 16:08:03 +01:00 by Demeter Dzadik · 10 comments
Member

Blender Version
Broken: version: 3.5.0 Alpha, branch: HEAD (modified), commit date: 2023-01-09 18:05, hash: b314d92e7d

Short description of error
When exposing values to the Modifier UI, all available property types seem to be overridable - even Strings, even though the UI to create String custom properties doesn't have the "Library Overridable" option (perhaps a separate bug). However, when toggling over to using an Attribute as the input, the input box is grayed out:
image.png

Files:
sphere.blend
sphere_overridden.blend

  • Download files next to each other
  • Open sphere_overridden.blend
  • Try to change any input that supports it, into an Attribute, and then specifying the attribute. You can't. Also, if you save and reload the file, the "use_attribute" toggle flips back to False, so that's also not overridable.
**Blender Version** Broken: version: 3.5.0 Alpha, branch: HEAD (modified), commit date: 2023-01-09 18:05, hash: `b314d92e7d` **Short description of error** When exposing values to the Modifier UI, all available property types seem to be overridable - even Strings, even though the UI to create String custom properties doesn't have the "Library Overridable" option (perhaps a separate bug). However, when toggling over to using an Attribute as the input, the input box is grayed out: ![image.png](https://archive.blender.org/developer/F14137587/image.png) Files: [sphere.blend](https://archive.blender.org/developer/F14137590/sphere.blend) [sphere_overridden.blend](https://archive.blender.org/developer/F14137591/sphere_overridden.blend) - Download files next to each other - Open sphere_overridden.blend - Try to change any input that supports it, into an Attribute, and then specifying the attribute. You can't. Also, if you save and reload the file, the "use_attribute" toggle flips back to False, so that's also not overridable.
Author
Member

Added subscriber: @Mets

Added subscriber: @Mets
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Author
Member

Related: #103865

Related: #103865

Added subscriber: @mont29

Added subscriber: @mont29

I'd rather have this investigated by the #geometry_nodes team first. The usages of IDProperties in this project is extremely... innovative and pushing boundaries, to say the least, so they should be the first to investigate these sort of issues.

I'd rather have this investigated by the #geometry_nodes team first. The usages of IDProperties in this project is extremely... innovative and pushing boundaries, to say the least, so they should be the first to investigate these sort of issues.
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

@mont29 Could you be more specific about how the IDProperty usage is suspect to you? It's hard to get a picture of the overall design and how the use in the geometry nodes modifier aligns to that otherwise.

@mont29 Could you be more specific about how the IDProperty usage is suspect to you? It's hard to get a picture of the overall design and how the use in the geometry nodes modifier aligns to that otherwise.

Added subscriber: @mod_moder

Added subscriber: @mod_moder

@HooglyBoogly afaik these IDProps are used i a new way, totally outside of the RNA 'wrapping' code that is usually used for e.g. py-defined properties added to existing RNA struct, operators, etc., and totally outside of the 'usual' user-defined custom properties.

the 'Attribute input' button uses an operator to do... something?

In #103865, fact that C.object.modifiers['GeometryNodes']["Input_10"] = 0.5 has a completely different effect than setattr(C.object.modifiers['GeometryNodes'], '["Input_10"]', 0.5) is also... preoccupying from a sanity level. And this behavior is not reproducible with regular custom properties at all.

@HooglyBoogly afaik these IDProps are used i a new way, totally outside of the RNA 'wrapping' code that is usually used for e.g. py-defined properties added to existing RNA struct, operators, etc., and totally outside of the 'usual' user-defined custom properties. the 'Attribute input' button uses an operator to do... something? In #103865, fact that `C.object.modifiers['GeometryNodes']["Input_10"] = 0.5` has a completely different effect than `setattr(C.object.modifiers['GeometryNodes'], '["Input_10"]', 0.5)` is also... preoccupying from a sanity level. And this behavior is not reproducible with regular custom properties at all.
Bastien Montagne added this to the Core project 2023-02-09 15:43:54 +01:00
Bastien Montagne removed this from the Core project 2023-02-09 18:20:29 +01:00
Philipp Oeser removed the
Interest
Nodes & Physics
label 2023-02-10 08:43:14 +01:00
Philipp Oeser added the
Interest
Core
label 2023-02-10 11:09:20 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#103785
No description provided.