Assert failure in anonymous attribute relations #103945

New Issue

Hans Goudey · 2023-01-17T18:24:19+01:00

Hans Goudey commented

2023-01-17 18:24:19 +01:00

generic_props_bug.blend

To reproduce, open file in a debug build.

The assert happens while building the anonymous attribute relations for the Deform_curve node group.

For that node tree there are two eval_relations:

{field_input = 2, geometry_input = 0}
{field_input = 2, geometry_input = 1}

When adding these to a VectorSet<AttributeReferenceKey> with add_new, there is a collision because the field_input values are the same.
AttributeReferenceKey doesn't contain the geometry_input value.

__pthread_kill_implementation@0x00007ffff72afe5c (Unknown Source:0)
raise@0x00007ffff725fa76 (Unknown Source:0)
abort@0x00007ffff72497fc (Unknown Source:0)
_BLI_assert_abort@0x000000000a6066a8 (/home/hans/blender-git/blender/source/blender/blenlib/intern/BLI_assert.c:46)
blender::VectorSet<blender::nodes::AttributeReferenceKey, blender::PythonProbingStrategy<1ul, false>, blender::DefaultHash<blender::nodes::AttributeReferenceKey>, blender::DefaultEquality<blender::nodes::AttributeReferenceKey>, blender::SimpleVectorSetSlot<blender::nodes::AttributeReferenceKey>, blender::GuardedAllocator>::add_new__impl<blender::nodes::AttributeReferenceKey const&>@0x0000000003a99a9e (/home/hans/blender-git/blender/source/blender/blenlib/BLI_vector_set.hh:683)
blender::VectorSet<blender::nodes::AttributeReferenceKey, blender::PythonProbingStrategy<1ul, false>, blender::DefaultHash<blender::nodes::AttributeReferenceKey>, blender::DefaultEquality<blender::nodes::AttributeReferenceKey>, blender::SimpleVectorSetSlot<blender::nodes::AttributeReferenceKey>, blender::GuardedAllocator>::add_new@0x0000000003a725b9 (/home/hans/blender-git/blender/source/blender/blenlib/BLI_vector_set.hh:269)
blender::nodes::GeometryNodesLazyFunctionGraphBuilder::build_attribute_references@0x0000000003a424e1 (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:2253)
blender::nodes::GeometryNodesLazyFunctionGraphBuilder::build_attribute_propagation_sets@0x0000000003a408e1 (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:2181)
blender::nodes::GeometryNodesLazyFunctionGraphBuilder::build@0x0000000003a22a1c (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:1212)
blender::nodes::ensure_geometry_nodes_lazy_function_graph@0x00000000039f80fc (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:2761)
blender::bke::node_tree_runtime::preprocess_geometry_node_tree_for_evaluation@0x0000000000ce5744 (/home/hans/blender-git/blender/source/blender/blenkernel/intern/node_runtime.cc:22)
operator()@0x0000000002ebd91d (/home/hans/blender-git/blender/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc:1761)
std::__invoke_impl<void, blender::deg::DepsgraphNodeBuilder::build_nodetree(bNodeTree*)::<lambda(Depsgraph*)>&, Depsgraph*>(std::__invoke_other, struct {...} &)@0x0000000002ee775b (/usr/include/c++/12/bits/invoke.h:61)
std::__invoke_r<void, blender::deg::DepsgraphNodeBuilder::build_nodetree(bNodeTree*)::<lambda(Depsgraph*)>&, Depsgraph*>(struct {...} &)@0x0000000002ee1824 (/usr/include/c++/12/bits/invoke.h:111)
std::_Function_handler<void(Depsgraph*), blender::deg::DepsgraphNodeBuilder::build_nodetree(bNodeTree*)::<lambda(Depsgraph*)> >::_M_invoke(const std::_Any_data &, Depsgraph *&&)@0x0000000002ed905e (/usr/include/c++/12/bits/std_function.h:290)
std::function<void (Depsgraph*)>::operator()(Depsgraph*) const@0x0000000002e05e2b (/usr/include/c++/12/bits/std_function.h:591)
blender::deg::(anonymous namespace)::evaluate_node@0x0000000002e0040c (/home/hans/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:101)
blender::deg::(anonymous namespace)::deg_task_run_func@0x0000000002e0083e (/home/hans/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:118)
Task::operator()@0x000000000ac94399 (/home/hans/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:164)
tbb::internal::function_task<Task>::execute@0x000000000ac98c13 (/home/hans/blender-git/lib/linux_x86_64_glibc_228/tbb/include/tbb/task.h:1059)

[generic_props_bug.blend](https://archive.blender.org/developer/F14159723/generic_props_bug.blend) To reproduce, open file in a debug build. The assert happens while building the anonymous attribute relations for the `Deform_curve` node group. For that node tree there are two `eval_relations`: - `{field_input = 2, geometry_input = 0}` - `{field_input = 2, geometry_input = 1}` When adding these to a `VectorSet<AttributeReferenceKey>` with `add_new`, there is a collision because the `field_input` values are the same. `AttributeReferenceKey` doesn't contain the `geometry_input` value. ``` __pthread_kill_implementation@0x00007ffff72afe5c (Unknown Source:0) raise@0x00007ffff725fa76 (Unknown Source:0) abort@0x00007ffff72497fc (Unknown Source:0) _BLI_assert_abort@0x000000000a6066a8 (/home/hans/blender-git/blender/source/blender/blenlib/intern/BLI_assert.c:46) blender::VectorSet<blender::nodes::AttributeReferenceKey, blender::PythonProbingStrategy<1ul, false>, blender::DefaultHash<blender::nodes::AttributeReferenceKey>, blender::DefaultEquality<blender::nodes::AttributeReferenceKey>, blender::SimpleVectorSetSlot<blender::nodes::AttributeReferenceKey>, blender::GuardedAllocator>::add_new__impl<blender::nodes::AttributeReferenceKey const&>@0x0000000003a99a9e (/home/hans/blender-git/blender/source/blender/blenlib/BLI_vector_set.hh:683) blender::VectorSet<blender::nodes::AttributeReferenceKey, blender::PythonProbingStrategy<1ul, false>, blender::DefaultHash<blender::nodes::AttributeReferenceKey>, blender::DefaultEquality<blender::nodes::AttributeReferenceKey>, blender::SimpleVectorSetSlot<blender::nodes::AttributeReferenceKey>, blender::GuardedAllocator>::add_new@0x0000000003a725b9 (/home/hans/blender-git/blender/source/blender/blenlib/BLI_vector_set.hh:269) blender::nodes::GeometryNodesLazyFunctionGraphBuilder::build_attribute_references@0x0000000003a424e1 (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:2253) blender::nodes::GeometryNodesLazyFunctionGraphBuilder::build_attribute_propagation_sets@0x0000000003a408e1 (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:2181) blender::nodes::GeometryNodesLazyFunctionGraphBuilder::build@0x0000000003a22a1c (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:1212) blender::nodes::ensure_geometry_nodes_lazy_function_graph@0x00000000039f80fc (/home/hans/blender-git/blender/source/blender/nodes/intern/geometry_nodes_lazy_function.cc:2761) blender::bke::node_tree_runtime::preprocess_geometry_node_tree_for_evaluation@0x0000000000ce5744 (/home/hans/blender-git/blender/source/blender/blenkernel/intern/node_runtime.cc:22) operator()@0x0000000002ebd91d (/home/hans/blender-git/blender/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc:1761) std::__invoke_impl<void, blender::deg::DepsgraphNodeBuilder::build_nodetree(bNodeTree*)::<lambda(Depsgraph*)>&, Depsgraph*>(std::__invoke_other, struct {...} &)@0x0000000002ee775b (/usr/include/c++/12/bits/invoke.h:61) std::__invoke_r<void, blender::deg::DepsgraphNodeBuilder::build_nodetree(bNodeTree*)::<lambda(Depsgraph*)>&, Depsgraph*>(struct {...} &)@0x0000000002ee1824 (/usr/include/c++/12/bits/invoke.h:111) std::_Function_handler<void(Depsgraph*), blender::deg::DepsgraphNodeBuilder::build_nodetree(bNodeTree*)::<lambda(Depsgraph*)> >::_M_invoke(const std::_Any_data &, Depsgraph *&&)@0x0000000002ed905e (/usr/include/c++/12/bits/std_function.h:290) std::function<void (Depsgraph*)>::operator()(Depsgraph*) const@0x0000000002e05e2b (/usr/include/c++/12/bits/std_function.h:591) blender::deg::(anonymous namespace)::evaluate_node@0x0000000002e0040c (/home/hans/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:101) blender::deg::(anonymous namespace)::deg_task_run_func@0x0000000002e0083e (/home/hans/blender-git/blender/source/blender/depsgraph/intern/eval/deg_eval.cc:118) Task::operator()@0x000000000ac94399 (/home/hans/blender-git/blender/source/blender/blenlib/intern/task_pool.cc:164) tbb::internal::function_task<Task>::execute@0x000000000ac98c13 (/home/hans/blender-git/lib/linux_x86_64_glibc_228/tbb/include/tbb/task.h:1059) ```

Hans Goudey commented

2023-01-17 18:24:19 +01:00

Added subscriber: @HooglyBoogly