Regression: Click-Drag to select channels in Graph Editor no longer working #104026

Closed
opened 2023-01-20 13:59:47 +01:00 by Christoph Lendenfeld · 7 comments

System Information
Operating system: Linux
Graphics card: RTX 3070

Blender Version
Broken: 3.2 - latest
Worked: 3.1
Caused by 4d0f846b93

Short description of error
Up until version 3.1 of Blender you could click-drag in the channels from the graph editor/dope sheet to select multiple channels.
From 3.2 onwards the box select never triggers and you can only select 1 channel.

Looking at the code, the keymappings are still there, presumably the event just gets caught before it hits the operator.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

channel_drag.blend

  • Open the attached blend file
  • try box selecting the channels in the graph editor/dope sheet
**System Information** Operating system: Linux Graphics card: RTX 3070 **Blender Version** Broken: 3.2 - latest Worked: 3.1 Caused by 4d0f846b93 **Short description of error** Up until version 3.1 of Blender you could click-drag in the channels from the graph editor/dope sheet to select multiple channels. From 3.2 onwards the box select never triggers and you can only select 1 channel. Looking at the code, the keymappings are still there, presumably the event just gets caught before it hits the operator. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). [channel_drag.blend](https://archive.blender.org/developer/F14179299/channel_drag.blend) * Open the attached blend file * try box selecting the channels in the graph editor/dope sheet
Author
Member

Added subscriber: @ChrisLend

Added subscriber: @ChrisLend
Christoph Lendenfeld self-assigned this 2023-01-20 14:00:12 +01:00
Author
Member

Added subscriber: @ideasman42

Added subscriber: @ideasman42
Author
Member

@ideasman42 I am not 100% sure but I think this stems from the change from EVT_TWEAK_L to LEFTMOUSE in the blender_default.py keymap.

was there anything inherent to EVT_TWEAK_L that made it execute before LEFTMOUSE ?

@ideasman42 I am not 100% sure but I think this stems from the change from `EVT_TWEAK_L` to `LEFTMOUSE` in the `blender_default.py` keymap. was there anything inherent to `EVT_TWEAK_L` that made it execute before `LEFTMOUSE` ?
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Author
Member

I found a potential fix by changing the keymap for anim.channels_click from PRESS to CLICK

I found a potential fix by changing the keymap for `anim.channels_click` from `PRESS` to `CLICK`

In #104026#1477278, @ChrisLend wrote:
@ideasman42 I am not 100% sure but I think this stems from the change from EVT_TWEAK_L to LEFTMOUSE in the blender_default.py keymap.

was there anything inherent to EVT_TWEAK_L that made it execute before LEFTMOUSE ?

Yes it would have, previously handling the PRESS did not suppress the TWEAK event (so selection could optionally tweak afterwards). There were quite a few cases where this bit us, as far as I knew they were all handled. This one slipped through, your fix looks fine (replied).

> In #104026#1477278, @ChrisLend wrote: > @ideasman42 I am not 100% sure but I think this stems from the change from `EVT_TWEAK_L` to `LEFTMOUSE` in the `blender_default.py` keymap. > > was there anything inherent to `EVT_TWEAK_L` that made it execute before `LEFTMOUSE` ? Yes it would have, previously handling the PRESS did not suppress the TWEAK event (so selection could optionally tweak afterwards). There were quite a few cases where this bit us, as far as I knew they were all handled. This one slipped through, your fix looks fine (replied).
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:34:41 +01:00
Sybren A. Stüvel added this to the Animation & Rigging project 2023-02-09 16:42:17 +01:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2023-02-10 11:36:05 +01:00
Sybren A. Stüvel removed this from the Animation & Rigging project 2023-02-17 14:19:22 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104026
No description provided.