Add WM api to handle PanelType parent/child relationships #104303

New Issue

Bastien Montagne · 2023-02-02T15:27:25+01:00

Bastien Montagne commented

2023-02-02 15:27:25 +01:00

Currently handling of parenting between panels in C/C++ code is spread all over the place, each area of code redefining the essentially the same logic to create sub-panels. At least these functions are concerned:

rna_Panel_register used by all Python-defined panels
modifier_subpanel_register
gpencil_modifier_subpanel_register
fmodifier_subpanel_register
shaderfx_panel_register
nla_buttons_register

TODO

Check all current use-cases and define what part of these are common logic. Put this common logic into a new WM_paneltype_subpanel_add API function (defined in wm_panel_type.c).
This should cover at the very least setting the parent_id string and parent PanelType pointer of the child, and insert the child at the proper place in its parent's children list.

Currently handling of parenting between panels in C/C++ code is spread all over the place, each area of code redefining the essentially the same logic to create sub-panels. At least these functions are concerned: * `rna_Panel_register` used by all Python-defined panels * `modifier_subpanel_register` * `gpencil_modifier_subpanel_register` * `fmodifier_subpanel_register` * `shaderfx_panel_register` * `nla_buttons_register` TODO ------- Check all current use-cases and define what part of these are common logic. Put this common logic into a new `WM_paneltype_subpanel_add` API function (defined in `wm_panel_type.c`). This should cover at the very least setting the `parent_id` string and `parent` `PanelType` pointer of the child, and insert the child at the proper place in its parent's `children` list.

Bastien Montagne commented

2023-02-02 15:27:25 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2023-02-02 15:27:25 +01:00

Added subscriber: @mont29

bekzii commented

2023-02-03 08:57:33 +01:00

Added subscriber: @bekzii

bekzii self-assigned this 2023-02-03 08:57:33 +01:00

bekzii commented

2023-02-03 08:57:33 +01:00

Hi, I'd like to take on this task :)

Dhruv Maroo commented

2023-02-03 12:00:30 +01:00

Added subscriber: @DMaroo

bekzii was unassigned by Dhruv Maroo

2023-02-03 12:00:30 +01:00

Dhruv Maroo self-assigned this 2023-02-03 12:00:30 +01:00

Dhruv Maroo commented

2023-02-03 12:00:30 +01:00

Hi @bekzii

I'm sorry, I didn't notice your comment about working on the task. But I started working on the task a while before that and even submitted a patch at https://developer.blender.org/D17193 :/

I'm sorry for this collision, and I should have claimed the task for myself. But I believe there is no need to work on this task anymore. Again, sorry for not claiming it.

Hi @bekzii I'm sorry, I didn't notice your comment about working on the task. But I started working on the task a while before that and even submitted a patch at https://developer.blender.org/D17193 :/ I'm sorry for this collision, and I should have claimed the task for myself. But I believe there is no need to work on this task anymore. Again, sorry for not claiming it.

bekzii commented

2023-02-03 12:08:37 +01:00

It's okay! Glad you managed to get it done :) (You actually did it kind of better than my solution)