Sequencer Preview doesn't update properly #21378

Closed
opened 2010-02-27 20:08:08 +01:00 by Anna Celarek · 11 comments

%%%Sequencer preview doesn't update properly if transform strip keys are moved around in Dope Sheet.

To recreate:
Make a transform strip in sequencer, animate position/scale, and move those keys to another place in Dope Sheet.
The sequencer preview image won't update properly when you go around the current frame (by dragging the green line with the mouse, or also Alt A). It will flicker between the old and new position/scale.

If you go to after the very last frame, and back again, there's a chance that it behaves normal again (but not always).

In the sample file, I used a non-animated wipe effect instead of an image, because I couldn't pack a sequencer image into the file ( https://projects.blender.org/tracker/index.php?func=detail&aid=21377&group_id=9&atid=498 ). However, with an image the effect seems to be even worse than with the wipe.

Doing the same in the F-Curve Editor makes no problems.

2.51 svn 27163
Win XP SP 3
AMD Turion 64 MT-30 1,6 GHz processor
1 GB RAM
Nvidia GeForce Go 6200

On xubuntu (another PC, not mine) it updates properly after you release and click again with the mouse. %%%

%%%Sequencer preview doesn't update properly if transform strip keys are moved around in Dope Sheet. To recreate: Make a transform strip in sequencer, animate position/scale, and move those keys to another place in Dope Sheet. The sequencer preview image won't update properly when you go around the current frame (by dragging the green line with the mouse, or also Alt A). It will flicker between the old and new position/scale. If you go to after the very last frame, and back again, there's a chance that it behaves normal again (but not always). In the sample file, I used a non-animated wipe effect instead of an image, because I couldn't pack a sequencer image into the file ( https://projects.blender.org/tracker/index.php?func=detail&aid=21377&group_id=9&atid=498 ). However, with an image the effect seems to be even worse than with the wipe. Doing the same in the F-Curve Editor makes no problems. 2.51 svn 27163 Win XP SP 3 AMD Turion 64 MT-30 1,6 GHz processor 1 GB RAM Nvidia GeForce Go 6200 On xubuntu (another PC, not mine) it updates properly after you release and click again with the mouse. %%%
Author

Changed status to: 'Open'

Changed status to: 'Open'

%%%There is a refresh button for this very purpose.%%%

%%%There is a refresh button for this very purpose.%%%
Author

%%%Haven't seen it, it's true. But I tried working with it, and it's quite annoying, to click down there after every little change. If it works with F-Curves without hitting the refresh button, why can't it work for DopeSheet? %%%

%%%Haven't seen it, it's true. But I tried working with it, and it's quite annoying, to click down there after every little change. If it works with F-Curves without hitting the refresh button, why can't it work for DopeSheet? %%%

%%%Hrm. While I can't say beyond a shadow of a doubt the reasoning, it isn't difficult to see the performance hit.

Imagine grabbing 100 fcurve points and dragging slightly... now you wait stuck while all of the various updates happen.

It is not productive nor condusive to an industry grade set of manipulations. What works for simple work likely doesn't work for complex work, which Blender is typically aimed at.

It could very well be that there is a broken update auyomatically toggle somewhere, but the default response is valid. %%%

%%%Hrm. While I can't say beyond a shadow of a doubt the reasoning, it isn't difficult to see the performance hit. Imagine grabbing 100 fcurve points and dragging slightly... now you wait stuck while all of the various updates happen. It is not productive nor condusive to an industry grade set of manipulations. What works for simple work likely doesn't work for complex work, which Blender is typically aimed at. It could very well be that there is a broken update auyomatically toggle somewhere, but the default response is valid. %%%

%%%This is a bug, since it works in the graph editor but not the dopesheet. Both have a Realtime Update in the View menu. There's an easy way to fix this but it also would be slow when transforming many channels at once (calling DAG_id_flush_update hundreds of times is very slow in more complex scenes), will try to think of a good solution.%%%

%%%This is a bug, since it works in the graph editor but not the dopesheet. Both have a Realtime Update in the View menu. There's an easy way to fix this but it also would be slow when transforming many channels at once (calling DAG_id_flush_update hundreds of times is very slow in more complex scenes), will try to think of a good solution.%%%
Member

%%%Anna: brecht committed better dependency handling, maybe this works now? I tried the file, but nothing shows strange here.%%%

%%%Anna: brecht committed better dependency handling, maybe this works now? I tried the file, but nothing shows strange here.%%%

%%%The bug is that it doesn't update when you move keyframes in the dopesheet, that still happens here. I'm not sure what the right fix is, probably it should loop over all f-curves involved and call their update functions, so attach a patch that does this. Not sure this will work in all cases, so assigning to Joshua to get his opinion.%%%

%%%The bug is that it doesn't update when you move keyframes in the dopesheet, that still happens here. I'm not sure what the right fix is, probably it should loop over all f-curves involved and call their update functions, so attach a patch that does this. Not sure this will work in all cases, so assigning to Joshua to get his opinion.%%%

%%%A possible solution to the performance hog could be to have an asynchronous process (I.e. a thread) execute the latest order. Possible pseudocode could be:


global image current_preview;

global fcurves current = null;
global fcurves next = null;
global Mutex mutex;

void thread_fn()
{

  while (true)
  {
      with (mutex)
      {
          if (next == null)
          {
                return;
          }
          current = next;
          next = null;
      }
      current_preview = do_processing(current);
  }

}

void on_update(new_fcurve_params)
{

  with(mutex)
  {
       next = new_fcurve_params;
       if (thread not running)
       {
           run threadf_fn as thread;
       }
  }

}%%%

%%%A possible solution to the performance hog could be to have an asynchronous process (I.e. a thread) execute the latest order. Possible pseudocode could be: ---------------------- global image current_preview; global fcurves current = null; global fcurves next = null; global Mutex mutex; void thread_fn() { ``` while (true) { with (mutex) { if (next == null) { return; } current = next; next = null; } current_preview = do_processing(current); } ``` } void on_update(new_fcurve_params) { ``` with(mutex) { next = new_fcurve_params; if (thread not running) { run threadf_fn as thread; } } ``` }%%%

%%%Sorry for the messy code. I don't know how the markup works on this site (standard HTML?).%%%

%%%Sorry for the messy code. I don't know how the markup works on this site (standard HTML?).%%%
Member

%%%I will move this to wiki as future todo. Adding hacks in our code to circumvent this are only going to work against us.
There are also many work arounds available:

  • disable the preview drawing when inserting keys
  • use autokey when inserting keys
  • open fcurve editor and tweak the curves manually.

A proper fix will really be to improve our timing system in general, which is a large project.

Wiki todo link:
http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Editors#Video_Sequencer%%%

%%%I will move this to wiki as future todo. Adding hacks in our code to circumvent this are only going to work against us. There are also many work arounds available: - disable the preview drawing when inserting keys - use autokey when inserting keys - open fcurve editor and tweak the curves manually. A proper fix will really be to improve our timing system in general, which is a large project. Wiki todo link: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Editors#Video_Sequencer%%%
Member

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#21378
No description provided.