Undoing an operation while baking fluids freezes Blender #27328

Closed
opened 2011-05-08 16:00:06 +02:00 by Stuart murra · 5 comments

%%%Simple steps to recreate freeze:

While baking a fluid simulation, make any modification to anything in the scene (move, rotate, add/remove keyframe etc) then hit undo. Blender should freeze.

Verbose steps to recreate freeze:

  1. Create a cube mesh.

  2. Hit Space, type Make Fluid and run the command (or make your own domain and turn the cube mesh into a fluid).

  3. Set the resolution of the domain to 250, or something equally high to get it to bake long enough to give you a chance to test this bug.

  4. Bake fluid simulation

  5. While simulation is baking, make an adjustment anything in the scene, ie move or rotate the light/domain/fluid... anything

  6. Hit ctrl+z to undo while still baking.

  7. Blender should freeze

Blender 2.57.1 r36339 64bit
Windows 7 64bit
Intel Core2 Duo E8500 3.61ghz
4GB RAM
AMD Radeon HD4860%%%

%%%Simple steps to recreate freeze: While baking a fluid simulation, make any modification to anything in the scene (move, rotate, add/remove keyframe etc) then hit undo. Blender should freeze. - Verbose steps to recreate freeze: 1. Create a cube mesh. 2. Hit Space, type Make Fluid and run the command (or make your own domain and turn the cube mesh into a fluid). 3. Set the resolution of the domain to 250, or something equally high to get it to bake long enough to give you a chance to test this bug. 4. Bake fluid simulation 5. While simulation is baking, make an adjustment anything in the scene, ie move or rotate the light/domain/fluid... anything 6. Hit ctrl+z to undo while still baking. 7. Blender should freeze Blender 2.57.1 r36339 64bit Windows 7 64bit Intel Core2 Duo E8500 3.61ghz 4GB RAM AMD Radeon HD4860%%%
Author

Changed status to: 'Open'

Changed status to: 'Open'
Member

%%%Yeah... fluid sim is not resistant to our undo system.

Not sure what to do with it, need advice from Janne if there's a way to detect bake-in-progress and disable 3d editing then.
janne: give me some info and assign to me to add code for it :)%%%

%%%Yeah... fluid sim is not resistant to our undo system. Not sure what to do with it, need advice from Janne if there's a way to detect bake-in-progress and disable 3d editing then. janne: give me some info and assign to me to add code for it :)%%%
Member

%%%The fluid bake is a job just like rendering (bake operator in editors/physics/physics_fluid.c), so you can check if a bake is running with WM_jobs_test(CTX_wm_manager(C), CTX_data_scene(C)). In theory 3d editing could be allowed during a fluid bake as the fluidsim creates an internal representation of all needed data before starting the bake, but undo seems to mess things up.

I'll gladly leave the decision of how to handle this to you Ton :)%%%

%%%The fluid bake is a job just like rendering (bake operator in editors/physics/physics_fluid.c), so you can check if a bake is running with WM_jobs_test(CTX_wm_manager(C), CTX_data_scene(C)). In theory 3d editing could be allowed during a fluid bake as the fluidsim creates an internal representation of all needed data before starting the bake, but undo seems to mess things up. I'll gladly leave the decision of how to handle this to you Ton :)%%%

%%%Should be fixed in svn rev42257. Thanks for the report, closing.%%%

%%%Should be fixed in svn rev42257. Thanks for the report, closing.%%%

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#27328
No description provided.