Comp Group nodes don't retain name #29139

New Issue

david mcsween · 2011-11-03T07:54:05+01:00

david mcsween commented

2011-11-03 07:54:05 +01:00

%%%If I name a group node I cannot search for it by name, as only the default name appears in the add dropdown menu eg. Nodegroup.001 etc.

When I try to append the node group from the node tree of a .blend all I see are the default names. I have tried this on other PCs but not other OS.

Win XP 32bit 2.6 r41259%%%

%%%If I name a group node I cannot search for it by name, as only the default name appears in the add dropdown menu eg. Nodegroup.001 etc. When I try to append the node group from the node tree of a .blend all I see are the default names. I have tried this on other PCs but not other OS. Win XP 32bit 2.6 r41259%%%

david mcsween commented

2011-11-03 07:54:05 +01:00

Changed status to: 'Open'

Brecht Van Lommel commented

2011-11-03 11:59:41 +01:00

%%%It works for me, I think perhaps you are changing the wrong name? There is the name of the node, and the name of the node group used by that node. The former you can edit in the Active Node panel, while the latter is edited by opening the group node (tab) and edit the name that shows at the top.%%%

david mcsween commented

2011-11-03 23:28:14 +01:00

%%%I see, but the name IS reflected in the active node properties panel. Leading me to think that, that is where I should edit the value.

But if you change it there (in properties), it does not change the name in the actual group node. It is not intuitive to edit the name field on the group node itself, as all the other nodes must be edited in the properties panel.

I agree it is not broken but could be a UI bug.%%%

%%%I see, but the name IS reflected in the active node properties panel. Leading me to think that, that is where I should edit the value. But if you change it there (in properties), it does not change the name in the actual group node. It is not intuitive to edit the name field on the group node itself, as all the other nodes must be edited in the properties panel. I agree it is not broken but could be a UI bug.%%%

david mcsween commented

2011-11-03 23:30:10 +01:00

%%%Sorry I meant to say that the default name IS reflected in the Active node panel. Making it seem that, that would be where to alter it. You just can't edit it there.%%%

Sergey Sharybin commented

2011-11-04 13:30:13 +01:00

%%%David, when you're trying to link group node into scene, name of node tree belongs to group node is displayed there. It can be renamed from group node header when it's in edit mode. Also here's patch which makes it able to edit name of editing tree from panel.

Lukas, what do you think about this change?%%%

%%%David, when you're trying to link group node into scene, name of node tree belongs to group node is displayed there. It can be renamed from group node header when it's in edit mode. Also here's patch which makes it able to edit name of editing tree from panel. Lukas, what do you think about this change?%%%

Brecht Van Lommel commented

2011-11-04 13:42:24 +01:00

%%%Sergey, I'd use uiTemplateID here, instead of just the name.%%%

Sergey Sharybin commented

2011-11-04 13:58:26 +01:00

%%%Brecht, in this case uiTemplateIDBrowse would make more sense because you don't want this tree be unlinked. Uploading updated patch.%%%

Brecht Van Lommel commented

2011-11-04 14:20:12 +01:00

%%%I'd leave out the label, we don't generally use this for datablock selectors, but otherwise just commit I think.%%%

Sergey Sharybin commented

2011-11-04 14:32:32 +01:00

%%%Just wasn't sure it's clear what exactly this id browser does, that's why added label. Removed label and commited to rev41523.
Thanks for the report and review, closing now.%%%

%%%Just wasn't sure it's clear what exactly this id browser does, that's why added label. Removed label and commited to rev41523. Thanks for the report and review, closing now.%%%

Sergey Sharybin commented

2011-11-04 14:32:33 +01:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2011-11-04 14:32:33 +01:00

Lukas Tönne commented

2011-11-05 17:00:14 +01:00

%%%Ok, from the bug description it sounds like you are renaming the group node, but actually want to rename the node tree itself. The situation with node names is confusing (partly due to my own changes) and needs cleanup. There are three different naming strings involved:

The node name: Unique string to identify the node, but usually not usable as ui display string, because it has .001, etc. appendix after each node duplication.
The displayed label: is now instead generated by a label callback. Usually takes just the node type name (e.g. "Add", "Color Balalnce"). This label can also be overridden by specifying a custom label string in the node props panel. It does not have to be unique, but each node still has its own custom label (not shared between nodes of same type).
The group tree ID block name: Groups nodes use a different default label function to display the name of the internal tree datablock instead. So their display name can actually be changed by either the custom label or by changing the group tree name. Also the tree datablock is only displayed in edited groups. Sergey's patch just exposes this as part of the group node again, so shortcuts the name and label strings (not bad at all, just doesn't really solve the problem)

The goal with introducing the label callback was to allow nicer and more meaningful ui string display ("Add" instead of "Math.003"). The disadvantage is that the node name string is not directly visible in the ui, except the active node panel. It should only be used for identifying the node (e.g. in scripting).

A possible solution could be removing the custom node label string again. Previously the node name was registering change of the initial string with a flag (can't remember what exactly this was used for), we could roll back to that behavior to avoid confusion. Disadvantage would be getting name extensions on duplicated nodes in the ui again, but may be worth it to reduce complexity.
%%%

%%%Ok, from the bug description it sounds like you are renaming the group node, but actually want to rename the node tree itself. The situation with node names is confusing (partly due to my own changes) and needs cleanup. There are three different naming strings involved: 1) The node name: Unique string to identify the node, but usually not usable as ui display string, because it has .001, etc. appendix after each node duplication. 2) The displayed label: is now instead generated by a label callback. Usually takes just the node _type_ name (e.g. "Add", "Color Balalnce"). This label can also be overridden by specifying a custom label string in the node props panel. It does not have to be unique, but each node still has its own custom label (not shared between nodes of same type). 3) The group tree ID block name: Groups nodes use a different default label function to display the name of the internal tree datablock instead. So their display name can actually be changed by either the custom label or by changing the group tree name. Also the tree datablock is only displayed in edited groups. Sergey's patch just exposes this as part of the group node again, so shortcuts the name and label strings (not bad at all, just doesn't really solve the problem) The goal with introducing the label callback was to allow nicer and more meaningful ui string display ("Add" instead of "Math.003"). The disadvantage is that the node name string is not directly visible in the ui, except the active node panel. It should only be used for identifying the node (e.g. in scripting). A possible solution could be removing the custom node label string again. Previously the node name was registering change of the initial string with a flag (can't remember what exactly this was used for), we could roll back to that behavior to avoid confusion. Disadvantage would be getting name extensions on duplicated nodes in the ui again, but may be worth it to reduce complexity. %%%

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Comp Group nodes don't retain name #29139