Incorrect drawing of Circle/Axes/Cross on Particles when Display set to that AND Size/Vel/Num/Health also selected #29433

New Issue

Mike Sloman · 2011-11-28T03:37:19+01:00

Mike Sloman commented

2011-11-28 03:37:19 +01:00

%%%The drawing of the Cross, Circle and Axes when using ParticleSettings.draw_method set to either of those is incorrect WHEN you have any of the Size/Health/Velocity/Number checkboxes set on.

The drawing of the circle/cross/axes scales up and down as you move the viewport. At a certain point these vanish (ie scaled to 0) and continue moving the view port they re-appear. However they are inverted but you can only tell when viewing the Axes option as it then draws the axes pointing in the opposite direction to the particle orientation. If you turn on the Velocity option (ParticleSettings.show_velocity) then you can see the axes change in orientation wrt. the velocity vector.

See attached blend file. Simply zoom in then out of observe the axes flip. Move the main view port and observe the axes decrease and change direction.

The shrinking of the cross/axes/circle is NOT present in 2.49. The shrinking is not that bad and aids the ability to adjust your view to get a clearer picture of the particle swarm without clutter and visualise the Health/Number information. However swapping axes direction is not right. I expect the two are related.

Possibly the issue is around line 3984 of function draw_new_particle_system() in file source/blender/editors/space_view3d/drawobject.c

%%%

%%%The drawing of the Cross, Circle and Axes when using ParticleSettings.draw_method set to either of those is incorrect WHEN you have any of the Size/Health/Velocity/Number checkboxes set on. The drawing of the circle/cross/axes scales up and down as you move the viewport. At a certain point these vanish (ie scaled to 0) and continue moving the view port they re-appear. However they are inverted but you can only tell when viewing the Axes option as it then draws the axes pointing in the opposite direction to the particle orientation. If you turn on the Velocity option (ParticleSettings.show_velocity) then you can see the axes change in orientation wrt. the velocity vector. See attached blend file. Simply zoom in then out of observe the axes flip. Move the main view port and observe the axes decrease and change direction. The shrinking of the cross/axes/circle is NOT present in 2.49. The shrinking is not that bad and aids the ability to adjust your view to get a clearer picture of the particle swarm without clutter and visualise the Health/Number information. However swapping axes direction is not right. I expect the two are related. Possibly the issue is around line 3984 of function draw_new_particle_system() in file source/blender/editors/space_view3d/drawobject.c %%%

Mike Sloman commented

2011-11-28 03:37:19 +01:00

Changed status to: 'Open'

Mike Sloman commented

2011-11-28 03:44:46 +01:00

%%%oh forgot to add ,

Built using customised scons and gcc 4.6.1.

Blender:

version 2.60 (sub 5), revision 42198M. Release
build date: 2011-11-28, 10:52:15
platform: Darwin:64bit

build cflags: -DPARALLEL=1 -DWITH_QUICKTIME -DUSE_QTKIT -DPARALLEL=1 -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -pipe -funsigned-char -fopenmp -DNDEBUG -O2 -ftree-vectorize -msse -msse2 -msse3 -mfpmath=sse -march=core2 -mssse3 -enable-threads -m64 -DGHOST_COCOA -DUSE_QTKIT -DWITH_MOD_FLUID -DWITH_MOD_OCEANSIM -D__LITTLE_ENDIAN__ -DWITH_AUDASPACE
build cxxflags: -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -pipe -funsigned-char -fopenmp -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -DNDEBUG -O2 -ftree-vectorize -msse -msse2 -msse3 -mfpmath=sse -march=core2 -mssse3 -enable-threads -m64 -DGHOST_COCOA -DUSE_QTKIT -DWITH_MOD_FLUID -DWITH_MOD_OCEANSIM -D__LITTLE_ENDIAN__ -DWITH_AUDASPACE
build linkflags: -mmacosx-version-min=10.6 -Wl -isysroot /Developer/SDKs/MacOSX10.6.sdk -fexceptions -framework CoreServices -framework Foundation -framework IOKit -framework AppKit -framework Cocoa -framework Carbon -framework AudioUnit -framework AudioToolbox -framework CoreAudio -framework OpenAL -m64 -framework QTKit
build system: SCons%%%

%%%oh forgot to add , Built using customised scons and gcc 4.6.1. Blender: **** version 2.60 (sub 5), revision 42198M. Release build date: 2011-11-28, 10:52:15 platform: Darwin:64bit build cflags: -DPARALLEL=1 -DWITH_QUICKTIME -DUSE_QTKIT -DPARALLEL=1 -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -pipe -funsigned-char -fopenmp -DNDEBUG -O2 -ftree-vectorize -msse -msse2 -msse3 -mfpmath=sse -march=core2 -mssse3 -enable-threads -m64 -DGHOST_COCOA -DUSE_QTKIT -DWITH_MOD_FLUID -DWITH_MOD_OCEANSIM -D__LITTLE_ENDIAN__ -DWITH_AUDASPACE build cxxflags: -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -pipe -funsigned-char -fopenmp -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -DNDEBUG -O2 -ftree-vectorize -msse -msse2 -msse3 -mfpmath=sse -march=core2 -mssse3 -enable-threads -m64 -DGHOST_COCOA -DUSE_QTKIT -DWITH_MOD_FLUID -DWITH_MOD_OCEANSIM -D__LITTLE_ENDIAN__ -DWITH_AUDASPACE build linkflags: -mmacosx-version-min=10.6 -Wl -isysroot /Developer/SDKs/MacOSX10.6.sdk -fexceptions -framework CoreServices -framework Foundation -framework IOKit -framework AppKit -framework Cocoa -framework Carbon -framework AudioUnit -framework AudioToolbox -framework CoreAudio -framework OpenAL -m64 -framework QTKit build system: SCons%%%

Mike Sloman commented

2011-11-28 07:58:07 +01:00

%%%The reversal of the Axes display mode can simply be fixed by using the attached diff. However I'm not sure if the allover scaling effect was what was desired.

- source/blender/editors/space_view3d/drawobject.c	(revision 42206)

+++ source/blender/editors/space_view3d/drawobject.c (working copy)
@@ -3990,7 +3990,7 @@
case PART_DRAW_CROSS:
case PART_DRAW_AXIS:
/* lets calculate the scale: */

pixsize= ED_view3d_pixel_size(rv3d, ob->obmat[3]);

  	pixsize= fabs(ED_view3d_pixel_size(rv3d, ob->obmat[3]));

  	if(part->draw_size==0.0)
  		pixsize *= 2.0f;

%%%

%%%The reversal of the Axes display mode can simply be fixed by using the attached diff. However I'm not sure if the allover scaling effect was what was desired. **** - source/blender/editors/space_view3d/drawobject.c (revision 42206) +++ source/blender/editors/space_view3d/drawobject.c (working copy) @@ -3990,7 +3990,7 @@ case PART_DRAW_CROSS: case PART_DRAW_AXIS: /* lets calculate the scale: */ - pixsize= ED_view3d_pixel_size(rv3d, ob->obmat[3]); + pixsize= fabs(ED_view3d_pixel_size(rv3d, ob->obmat[3])); if(part->draw_size==0.0) pixsize *= 2.0f; %%%

Brecht Van Lommel commented

2011-11-28 16:14:33 +01:00

%%%The scaling can't be intentional, it should stay a roughly fixed size in pixels as you zoom in/out. I think perhaps it should be passing the particle position rather than the object position to ED_view3d_pixel_size, otherwise this size isn't going to be very accurate when you zoom into a part of the object.%%%

Mike Sloman commented

2011-11-29 03:14:29 +01:00

%%%Brecht : OK, so definitely that scaling effect is not wanted. At that point in the code the calculation uses the object that is emitting the particles for the size calculation I suspect to avoid doing that call for every particle later in the code when the vertex arrays are generated. Will try to understand a little more on what is going on and why this effect only shows up when the Size/Vel/Heath/Num boxes are checked.%%%

Brecht Van Lommel commented

2012-02-01 18:34:45 +01:00

%%%Campbell fixed this in svn, didn't close report, closing now.%%%

Brecht Van Lommel commented

2012-02-01 18:34:45 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2012-02-01 18:34:45 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Incorrect drawing of Circle/Axes/Cross on Particles when Display set to that AND Size/Vel/Num/Health also selected #29433