Save All Edited only works for Saved external image, not New or Packed image (bpy.ops.image.save_dirty) #31136

Closed
opened 2012-04-28 05:01:53 +02:00 by Jacob Gustafson · 3 comments

%%%(Tested on Blender 2.62 32-bit on Windows 7 64-bit, Intel Core i3)
If you Unwrap, then in UV/Image Editor you click "New", "Save All Edited" doesn't work as expected.

(After doing Smart UV Project)

  • Doesn't work after: Image, New, paint on it [Save All Edited fails with "Invalid Path:" followed by nothing]
  • Starts working after: Image, Save As Image
  • Stops working after: Image, Pack (or Pack As PNG) [fails silently]
  • Starts working again after: Image, Unpack, Overwrite (or create)

Steps to reproduce issue:

  1. New default cube, Tab, UVUnwrap, Smart Projection, Split View, change 2nd view to UV Image Editor, File, Save, name blend file, Enter, Enter.
  2. Image, New, Change 1st view to Texture Paint, File, Save, paint on it, Save All Edited: doesn't work ("Invalid Path:" followed by nothing)
  3. Reopen blend file, Image, Save As Image, name the image, Enter, Enter, File, Save, paint on it more, Save All Edited: works this time
  4. Image, Pack (or Pack As PNG), paint on it more, Save All Edited: fails silently (changes don't appear after re-opening blend file) even if you do Image, Replace Image & save Blend File. then edit it, File, Save, Reopen Blend file--Save All Edited still fails.
  5. Image, Unpack, Overwrite named image: makes Save All Edited start working again

Suggested solutions:

  • change bpy.ops.image.save_dirty to:

put outer loop here to handle situations where there are multiple images

  if #packed as png:
      bpy.ops.image.pack(as_png=True)
  elif  #packed but not as png:
      bpy.ops.image.pack(as_png=False)
  elif  #saved as image:
    #move previous image save code to here
  else:
    #this should run if you press Save All Edited after you had pressed Image, New but had clicked nothing else in UV/Image Editor
      bpy.ops.image.pack(as_png=True)
  • change bpy.ops.wm.save_mainfile to include bpy.ops.image.save_dirty() (or have option for that in preferences)%%%
%%%(Tested on Blender 2.62 32-bit on Windows 7 64-bit, Intel Core i3) If you Unwrap, then in UV/Image Editor you click "New", "Save All Edited" doesn't work as expected. (After doing Smart UV Project) - Doesn't work after: Image, New, paint on it [Save All Edited fails with "Invalid Path:" followed by nothing] - Starts working after: Image, Save As Image - Stops working after: Image, Pack (or Pack As PNG) [fails silently] - Starts working again after: Image, Unpack, Overwrite (or create) Steps to reproduce issue: 1. New default cube, Tab, UVUnwrap, Smart Projection, Split View, change 2nd view to UV Image Editor, File, Save, name blend file, Enter, Enter. 2. Image, New, Change 1st view to Texture Paint, File, Save, paint on it, Save All Edited: doesn't work ("Invalid Path:" followed by nothing) 3. Reopen blend file, Image, Save As Image, name the image, Enter, Enter, File, Save, paint on it more, Save All Edited: works this time 4. Image, Pack (or Pack As PNG), paint on it more, Save All Edited: fails silently (changes don't appear after re-opening blend file) even if you do Image, Replace Image & save Blend File. then edit it, File, Save, Reopen Blend file--Save All Edited still fails. 5. Image, Unpack, Overwrite named image: makes Save All Edited start working again Suggested solutions: - change bpy.ops.image.save_dirty to: # put outer loop here to handle situations where there are multiple images ``` if #packed as png: bpy.ops.image.pack(as_png=True) elif #packed but not as png: bpy.ops.image.pack(as_png=False) elif #saved as image: ``` #move previous image save code to here ``` else: ``` #this should run if you press Save All Edited after you had pressed Image, New but had clicked nothing else in UV/Image Editor ``` bpy.ops.image.pack(as_png=True) ``` - change bpy.ops.wm.save_mainfile to include bpy.ops.image.save_dirty() (or have option for that in preferences)%%%

Changed status to: 'Open'

Changed status to: 'Open'

%%%fixed 46294.

now repacks edited images and reports a warning for packed library images (which cant be written to).%%%

%%%fixed 46294. now repacks edited images and reports a warning for packed library images (which cant be written to).%%%

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#31136
No description provided.