Fractional step in value input for Skin Modifier (Event/input problem) #31584

New Issue

Daniel Salazar · 2012-05-24T10:47:29+02:00

Daniel Salazar commented

2012-05-24 10:47:29 +02:00

%%%This one is weird.. It's about Ctrl + A for scaling "vertex size" in skin modifier

If you press Ctrl + A slowly it works smoothly as expected
If you press Ctrl + A in rapid succession a fractional step of .1 is given to the value input

This is probably not your code even but I'll assign to you so you can decide%%%

%%%This one is weird.. It's about Ctrl + A for scaling "vertex size" in skin modifier If you press Ctrl + A slowly it works smoothly as expected If you press Ctrl + A in rapid succession a fractional step of .1 is given to the value input This is probably not your code even but I'll assign to you so you can decide%%%

Daniel Salazar commented

2012-05-24 10:47:29 +02:00

Changed status to: 'Open'

Nicholas Bishop commented

2012-05-24 21:46:21 +02:00

%%%I have observed this as well. As far as I can tell it's not skin related (I've seen similar problems with modifier keys elsewhere in Blender too.)

Unassigning self, hopefully someone with more event-system knowledge can check.%%%

%%%I have observed this as well. As far as I can tell it's not skin related (I've seen similar problems with modifier keys elsewhere in Blender too.) Unassigning self, hopefully someone with more event-system knowledge can check.%%%

Bastien Montagne commented

2012-06-21 21:34:33 +02:00

%%%Can confirm this has nothing related to modifier, it’s a problem with transform code.

To be precise, you can reproduce the bug by releasing the modifier key (ctrl here, but same problem would arise with shift…) before the A key. This is caused by a piece of code at init transform time (initTransform, transform.c, lines 1668-1686), which enables snapping if ctrl (or shift) key is pressed at init time.

This allows snapping to be on when you click on transform widget with ctrl key pressed… but also enables it when you start a transform tool with a shortcut using such modifier!

I guess things work OK when you release ctrl after A because this generates an event while the transformation is already active, and hence is correctly detected as a “snapping deactivation”.

Either way, we are hitting the limits of trying to manage/detect continuous states with discrete events (here ctrl key press/release). Maybe we should rather test those modifiers in all transformEvent calls, but I guess this would broke the shortcut system… :/%%%

%%%Can confirm this has nothing related to modifier, it’s a problem with transform code. To be precise, you can reproduce the bug by releasing the modifier key (ctrl here, but same problem would arise with shift…) *before* the A key. This is caused by a piece of code at init transform time (initTransform, transform.c, lines 1668-1686), which enables snapping if ctrl (or shift) key is pressed at init time. This allows snapping to be on when you click on transform widget with ctrl key pressed… but also enables it when you start a transform tool with a shortcut using such modifier! I guess things work OK when you release ctrl after A because this generates an event while the transformation is already active, and hence is correctly detected as a “snapping deactivation”. Either way, we are hitting the limits of trying to manage/detect continuous states with discrete events (here ctrl key press/release). Maybe we should rather test those modifiers in all transformEvent calls, but I guess this would broke the shortcut system… :/%%%

Sergey Sharybin commented

2012-07-12 16:42:35 +02:00

%%%Fixed in svn rev48864. Not ideal, but don't think it makes code more silly there.
Thanks for the report, closing.%%%

%%%Fixed in svn rev48864. Not ideal, but don't think it makes code more silly there. Thanks for the report, closing.%%%

Sergey Sharybin commented

2012-07-12 16:42:35 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2012-07-12 16:42:35 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fractional step in value input for Skin Modifier (Event/input problem) #31584