Loop Selection on wireframe selects vertex behind #31900

Closed
opened 2012-06-22 15:54:06 +02:00 by Pablo Vazquez · 8 comments
Member

%%%Hi,

When in wireframe, or solid view with "Limited Selection to Visible" enabled, when selecting a loop via Alt + RMB, if we do it close to a vertex in the background, it will select it as well.

It happens in the simplest of cases, attached is an image of how it looks, and a blend file where you can reproduce this:

  • Just open the file, and (without moving the view) loopselect what is inside the red circle. It will select the edgeloop + the vertex behind, even if this one doesn't belong at all to the loop.

Thanks for your time.%%%

%%%Hi, When in wireframe, or solid view with "Limited Selection to Visible" enabled, when selecting a loop via Alt + RMB, if we do it close to a vertex in the background, it will select it as well. It happens in the simplest of cases, attached is an image of how it looks, and a blend file where you can reproduce this: - Just open the file, and (without moving the view) loopselect what is inside the red circle. It will select the edgeloop + the vertex behind, even if this one doesn't belong at all to the loop. Thanks for your time.%%%
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'

%%%Indeed… Probably because loop-select works on edges, while “normal” select works on vertices?

Will have a look at that.%%%

%%%Indeed… Probably because loop-select works on edges, while “normal” select works on vertices? Will have a look at that.%%%
Author
Member

%%%Confirmed it also happens when in with edges during Edge select and faces on Face select.

Thanks!%%%

%%%Confirmed it also happens when in with edges during Edge select and faces on Face select. Thanks!%%%

%%%Eeeep, I believe I might have introduced this error. I'll investigate tomorrow.

Here's my commit information:
Fixes [#31577] Select N-th vertex/face/edge doesnt work
http://projects.blender.org/tracker/index.php?func=detail&aid=31577&group_id=9&atid=498

Also solves both TODOs in the commented code.

Loop select now calls mouse_mesh() to handle setting an active vertex/edge/face.

Modified Paths:

 trunk/blender/source/blender/editors/mesh/editmesh_select.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_select.c


- trunk/blender/source/blender/editors/mesh/editmesh_select.c 2012-06-20 05:41:52 UTC (rev 48104)

+++ trunk/blender/source/blender/editors/mesh/editmesh_select.c 2012-06-20 07:31:19 UTC (rev 48105)
@@ -1044,6 +1044,7 @@
// if (EM_texFaceCheck())

             /* sets as active, useful for other tools */

+#if 0

             if (select) {
                     if (em->selectmode & SCE_SELECT_VERTEX) {
                             /* TODO: would be nice if the edge vertex chosen here

@@ -1058,6 +1059,8 @@
* belongs to the selected edge could be set to
* active here in face select mode */

             }

+#endif

  •           mouse_mesh(C, mval, select, TRUE, FALSE);
    
             WM_event_add_notifier(C, NC_GEOM | ND_SELECT, vc.obedit);
     }%%%
%%%Eeeep, I believe I might have introduced this error. I'll investigate tomorrow. Here's my commit information: Fixes [#31577] Select N-th vertex/face/edge doesnt work http://projects.blender.org/tracker/index.php?func=detail&aid=31577&group_id=9&atid=498 Also solves both TODOs in the commented code. Loop select now calls mouse_mesh() to handle setting an active vertex/edge/face. Modified Paths: -------------- ``` trunk/blender/source/blender/editors/mesh/editmesh_select.c ``` Modified: trunk/blender/source/blender/editors/mesh/editmesh_select.c **** - trunk/blender/source/blender/editors/mesh/editmesh_select.c 2012-06-20 05:41:52 UTC (rev 48104) +++ trunk/blender/source/blender/editors/mesh/editmesh_select.c 2012-06-20 07:31:19 UTC (rev 48105) @@ -1044,6 +1044,7 @@ // if (EM_texFaceCheck()) ``` /* sets as active, useful for other tools */ ``` +#if 0 ``` if (select) { if (em->selectmode & SCE_SELECT_VERTEX) { /* TODO: would be nice if the edge vertex chosen here ``` @@ -1058,6 +1059,8 @@ * belongs to the selected edge could be set to * active here in face select mode */ ``` } ``` +#endif + mouse_mesh(C, mval, select, TRUE, FALSE); ``` WM_event_add_notifier(C, NC_GEOM | ND_SELECT, vc.obedit); }%%%

%%%Yep, was just investigating this, can confirm commenting out this mouse_mesh() call fixes the problem! :p%%%

%%%Yep, was just investigating this, can confirm commenting out this mouse_mesh() call fixes the problem! :p%%%

%%%Fixed in svn48272!

Thanks for reporting. :)%%%

%%%Fixed in svn48272! Thanks for reporting. :)%%%

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Author
Member

%%%Thank you both Nicholas and Bastien! :D

/me does the compile dance%%%

%%%Thank you both Nicholas and Bastien! :D /me does the compile dance%%%
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#31900
No description provided.