Standalone Player switches not working #32360

New Issue

Thomas Szepe · 2012-08-18T21:14:11+02:00

Thomas Szepe commented

2012-08-18 21:14:11 +02:00

Category: UI/Interface

%%%Standalone player switches debug droperties, show framerate and quad-buffer are not working.%%%

**Category**: UI/Interface %%%Standalone player switches debug droperties, show framerate and quad-buffer are not working.%%%

Thomas Szepe commented

2012-08-18 21:14:11 +02:00

Changed status to: 'Open'

Mitchell Stokes commented

2012-08-18 22:12:35 +02:00

%%%The following works as expected for me:
blenderplayer.exe -g show_properties = 1 -g show_framerate = 1 test.blend

I don't know about quad-buffer since I don't have a card that supports it. However, I do know it can be a little tricky to get going.%%%

%%%The following works as expected for me: blenderplayer.exe -g show_properties = 1 -g show_framerate = 1 test.blend I don't know about quad-buffer since I don't have a card that supports it. However, I do know it can be a little tricky to get going.%%%

Dalai Felinto commented

2012-08-19 08:01:33 +02:00

%%%quadbuffer is supposed to be working, but it works only in blenderplayer and it requires fullscreen.%%%

Thomas Szepe commented

2012-08-19 10:33:40 +02:00

%%%@ Mitchell.
You misunderstood me. I know that the command line parameters are working.
But I meant when I start the blenderplayer from the new UI button (blue in the screenshot) in blender.

Look at the attached screenshot. The green switches are working, the red one not.

@ Dalai.
On my PC (Quadro FX 3700M) quad-buffer it working also in windowed mode.%%%

%%%@ Mitchell. You misunderstood me. I know that the command line parameters are working. But I meant when I start the blenderplayer from the new UI button (blue in the screenshot) in blender. Look at the attached screenshot. The green switches are working, the red one not. @ Dalai. On my PC (Quadro FX 3700M) quad-buffer it working also in windowed mode.%%%

Thomas Szepe commented

2012-08-31 15:33:54 +02:00

%%%The "Quad-Buffer" is working since Mitchell Stokes patch r49998 [#32361] Blenderplayer quad-buffer maximum 100Hz Fps

I made a patch for the "Debug Properties", "Framerate and Profile" and "Deprecation Warnings" switches.
Because of the bug in the profile ([#32459] Profile in blenderplayer displays wrong values.) I made two patches.

%%%

%%%The "Quad-Buffer" is working since Mitchell Stokes patch r49998 [#32361] Blenderplayer quad-buffer maximum 100Hz Fps I made a patch for the "Debug Properties", "Framerate and Profile" and "Deprecation Warnings" switches. Because of the bug in the profile ([#32459] Profile in blenderplayer displays wrong values.) I made two patches. %%%

Dalai Felinto commented

2012-09-21 23:49:45 +02:00

%%%Hi, the patch doesn't change anything here (aka it doesn't seem to be working).
and why did you remove m_ketsjiengine->SetTimingDisplay(frameRate, false, false); ?

Also, when creating a patch please do it from blender base source dir (instead of source/gameengine/GamePlayer/ghost in this case)
And having two patches confused me a bit. Ultimately the only patch you would like to apply is the Player Switches, right?

/tested on OSX%%%

%%%Hi, the patch doesn't change anything here (aka it doesn't seem to be working). and why did you remove m_ketsjiengine->SetTimingDisplay(frameRate, false, false); ? Also, when creating a patch please do it from blender base source dir (instead of source/gameengine/GamePlayer/ghost in this case) And having two patches confused me a bit. Ultimately the only patch you would like to apply is the Player Switches, right? /tested on OSX%%%

Dalai Felinto commented

2012-09-22 00:38:21 +02:00

%%%I gave another look at the patch and I don't think this is the best approach.
I think this fits better if implemented in the python file that launches the blenderplayer instead of the GHOST code.%%%

%%%I gave another look at the patch and I don't think this is the best approach. I think this fits better if implemented in the python file that launches the blenderplayer instead of the GHOST code.%%%

Thomas Szepe commented

2012-09-22 13:27:24 +02:00

%%%The patch is working on my Windows XP 32 bit system.
I have not fully understand the whole blender code yet.
At the moment I don't really understand for what the ghost files are for and why there are a similar code is in the BL_KetsjiEmbedStart.cpp.
I don't know but maybe OSX we have to change the BL_KetsjiEmbedStart.cpp to (line 268 to 277) to.

I removed the m_ketsjiengine->SetTimingDisplay(frameRate, false, false); method, because I found it two times in the GPG_Application.cpp.
line 635 m_ketsjiengine->SetTimingDisplay(frameRate, false, false);
line 645 m_ketsjiengine->SetTimingDisplay(frameRate, profile, properties);
That must be a fault in the original code. So I removed the unnecessary line 635 from the code.

I created the patch not from the blender base because I have made some other changes in the source code and I want to generate a patch from the ghost.
But in future I will make a separate copy from the blender source for each patch. Then I can make a patch from the blender base.

I made two patches because the profile values are not displaying correct on my PC (as I described above). The second patch don't enable the profile values. But it seams that problem with the profile depends on my PC. So the "Player switches.patch" is the right one.
I tried to made it working if we start the player from inside blender (start button) and if the file is started directly with the blenderplayer (no need to setup the command line parameter more).

I changed the GHOST because all other switches like fixed_framerate, show_physics, displaylists and restrictAnimFPS are also loaded in the ghost file in this way.

If we change python file instead of the GHOST code the switches are only working if we start the player from start button inside blender.
If you start the file direct with the blenderplayer the stored settings won’t have a affect and you must use the command line parameters.

I can try to make a patch for the python file instead of the GHOST code. But then I have to change also the GHOST code to. Because we should choose one way to do it and don't mix it up.

I personally like it more to load the saved settings from the file. Because on windows I can drag and drop the fie on the player an it starts with the saved setup. So I don't need to stat the player from the command window or write a batch file.
%%%

%%%The patch is working on my Windows XP 32 bit system. I have not fully understand the whole blender code yet. At the moment I don't really understand for what the ghost files are for and why there are a similar code is in the BL_KetsjiEmbedStart.cpp. I don't know but maybe OSX we have to change the BL_KetsjiEmbedStart.cpp to (line 268 to 277) to. I removed the m_ketsjiengine->SetTimingDisplay(frameRate, false, false); method, because I found it two times in the GPG_Application.cpp. line 635 m_ketsjiengine->SetTimingDisplay(frameRate, false, false); line 645 m_ketsjiengine->SetTimingDisplay(frameRate, profile, properties); That must be a fault in the original code. So I removed the unnecessary line 635 from the code. I created the patch not from the blender base because I have made some other changes in the source code and I want to generate a patch from the ghost. But in future I will make a separate copy from the blender source for each patch. Then I can make a patch from the blender base. I made two patches because the profile values are not displaying correct on my PC (as I described above). The second patch don't enable the profile values. But it seams that problem with the profile depends on my PC. So the "Player switches.patch" is the right one. I tried to made it working if we start the player from inside blender (start button) and if the file is started directly with the blenderplayer (no need to setup the command line parameter more). I changed the GHOST because all other switches like fixed_framerate, show_physics, displaylists and restrictAnimFPS are also loaded in the ghost file in this way. If we change python file instead of the GHOST code the switches are only working if we start the player from start button inside blender. If you start the file direct with the blenderplayer the stored settings won’t have a affect and you must use the command line parameters. I can try to make a patch for the python file instead of the GHOST code. But then I have to change also the GHOST code to. Because we should choose one way to do it and don't mix it up. I personally like it more to load the saved settings from the file. Because on windows I can drag and drop the fie on the player an it starts with the saved setup. So I don't need to stat the player from the command window or write a batch file. %%%

Daniel Stokes commented

2013-09-06 01:13:57 +02:00

%%%Changed the operator to use the command line switches based on UI settings in r5962.
The UI settings it considers are:

Framerate and Profile
Debug Properties
Deprecation Warnings

Is this sufficient to close this report?%%%

%%%Changed the operator to use the command line switches based on UI settings in r5962. The UI settings it considers are: * Framerate and Profile * Debug Properties * Deprecation Warnings Is this sufficient to close this report?%%%

Thomas Szepe commented

2013-09-06 16:38:16 +02:00

%%%The patch is working.

But now the operation of the new switches are switches is different to the others.

Example:
Framerate and Profile
%%%

%%%The patch is working. But now the operation of the new switches are switches is different to the others. Example: Framerate and Profile %%%

Thomas Szepe commented

2013-09-06 16:53:13 +02:00

%%%The patch is working.

But now the operation of the new switches are switches is different to the others (as I described above).

Example:
Framerate and Profile = works with Standalone button = not working with blenderplayer.exe
Physics Visualisation = works with Standalone button = working with blenderplayer.exe

I really dislike when things are mixed up this way.There should only one way how it works. Because I think that will confuse some peoples.
If you relay like the Python way more then you should change the other switches like the Physics Visualisation to.

Sorry for the double post, but using the TAB button sent the message before I had finished my post%%%

%%%The patch is working. But now the operation of the new switches are switches is different to the others (as I described above). Example: Framerate and Profile = works with Standalone button = not working with blenderplayer.exe Physics Visualisation = works with Standalone button = working with blenderplayer.exe I really dislike when things are mixed up this way.There should only one way how it works. Because I think that will confuse some peoples. If you relay like the Python way more then you should change the other switches like the Physics Visualisation to. Sorry for the double post, but using the TAB button sent the message before I had finished my post%%%

Daniel Stokes commented

2013-09-10 22:15:17 +02:00

%%%With regards to those switches not working when launching the player outside of player, that is currently working as intended. Some more discussion needs to take place, but the current idea is that the player is meant for releases, and not development. This means it ignores development options like framerate and profile unless you explicitly re-enable them. Obviously this idea has not applied universally as physics visualization could be considered as a development option.

Since this aspect of the BGE is still under discussion and could potentially change, I think it is best to leave it as is.%%%

%%%With regards to those switches not working when launching the player outside of player, that is currently working as intended. Some more discussion needs to take place, but the current idea is that the player is meant for releases, and not development. This means it ignores development options like framerate and profile unless you explicitly re-enable them. Obviously this idea has not applied universally as physics visualization could be considered as a development option. Since this aspect of the BGE is still under discussion and could potentially change, I think it is best to leave it as is.%%%

Mitchell Stokes commented

2013-11-19 21:34:47 +01:00

Changed status from 'Open' to: 'Resolved'

Mitchell Stokes closed this issue

2013-11-19 21:34:47 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Standalone Player switches not working #32360