ParticleInstance: crash with hidden particle system + children #32887

New Issue

xxxxx xxxxx · 2012-10-16T06:12:57+02:00

xxxxx xxxxx commented

2012-10-16 06:12:57 +02:00

Relates to: #32058

%%%win7 x64, tested with both official 2.64a and 51350

this is a slight variant of bug #32058

anyway, follow the same steps, but before saving and reloading the file, enable child particles for the particle system, and enable the children option in the particle instance modifier.

boom, crash on reload!

attached is an offending file%%%

**Relates to**: #32058 %%%win7 x64, tested with both official 2.64a and 51350 this is a slight variant of bug #32058 anyway, follow the same steps, but before saving and reloading the file, enable child particles for the particle system, and enable the children option in the particle instance modifier. boom, crash on reload! attached is an offending file%%%

xxxxx xxxxx commented

2012-10-16 06:12:57 +02:00

Changed status to: 'Open'

Sergey Sharybin commented

2012-10-16 14:52:54 +02:00

%%%Lukas, seems to be just matter of adding check for DM != NULL, but not sure where it'll be the best place for this. Since you've looked into related issue think it'll be much easier for you to look into this issue too?%%%

Lukas Tönne commented

2012-10-16 21:26:24 +02:00

%%%Yes, checking for DM != NULL is simple, but unfortunately the problem is rooted deeper:

Particle Instance modifier depends on a different object with the Particle System modifier, which is handled nicely by the depsgraph. However, disabling the System modifier usually leaves the psys in an invalid state ... This is unlike real modifiers, which simply use the unchanged input DM.

Next to the missing DM pointer (accessed from the cached psmd data) we found at least one other variable that causes trouble (lazy-initialized frand array). Finding all potential invalid variables etc. is almost impossible due to the convoluted code, i would rather not attempt major changes here.

Simple solution: never disable the particle system modifier! I will try to implement a way of preventing "disable" of that modifier. It is an ugly hack to fix a broken design, but guess we all know that by now ...%%%

%%%Yes, checking for DM != NULL is simple, but unfortunately the problem is rooted deeper: Particle Instance modifier depends on a different object with the Particle System modifier, which is handled nicely by the depsgraph. However, disabling the System modifier usually leaves the psys in an invalid state ... This is unlike real modifiers, which simply use the unchanged input DM. Next to the missing DM pointer (accessed from the cached psmd data) we found at least one other variable that causes trouble (lazy-initialized frand array). Finding all potential invalid variables etc. is almost impossible due to the convoluted code, i would rather not attempt major changes here. Simple solution: never disable the particle system modifier! I will try to implement a way of preventing "disable" of that modifier. It is an ugly hack to fix a broken design, but guess we all know that by now ...%%%

Lukas Tönne commented

2012-10-17 11:51:44 +02:00

%%%Fixed in SVN.

Note that the Particle Instance modifier will now be disabled automatically if the Particle System modifier is disabled. This is the only sane way to ensure it doesn't try to access invalid data. So in this case you need to re-enable the Particle System modifier to make the instancing work!%%%

%%%Fixed in SVN. Note that the Particle Instance modifier will now be disabled automatically if the Particle System modifier is disabled. This is the only sane way to ensure it doesn't try to access invalid data. So in this case you need to re-enable the Particle System modifier to make the instancing work!%%%

Lukas Tönne commented

2012-10-17 11:51:44 +02:00

Changed status from 'Open' to: 'Resolved'

Lukas Tönne closed this issue

2012-10-17 11:51:44 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

ParticleInstance: crash with hidden particle system + children #32887