Text Font Bug #33163

New Issue

Thomas Szepe · 2012-11-13T19:45:42+01:00

Thomas Szepe commented

2012-11-13 19:45:42 +01:00

Category: Rendering

%%%If you enable wire shading on a material and you run the file with the BlenderPlayer the font text don't will be displayed correctly.
The embedded player working correct.

Tested on Windows XP 32 Bit with
Blender 2.59 not working
Blender 2.62 not working
Blender 2.63a not working
Blender 2.64a not working
Blender 2.64.9 r52065 not working%%%

**Category**: Rendering %%%If you enable wire shading on a material and you run the file with the BlenderPlayer the font text don't will be displayed correctly. The embedded player working correct. Tested on Windows XP 32 Bit with Blender 2.59 not working Blender 2.62 not working Blender 2.63a not working Blender 2.64a not working Blender 2.64.9 r52065 not working%%%

Thomas Szepe commented

2012-11-13 19:45:42 +01:00

Changed status to: 'Open'

Thomas Szepe commented

2013-01-04 19:30:04 +01:00

%%%I fond out why this happens. in the GPC_RenderTools.cpp there is glPolygonMode(GL_FRONT_AND_BACK, GL_FILL) in RenderText3D.

I have attached a patch.%%%

%%%I fond out why this happens. in the GPC_RenderTools.cpp there is glPolygonMode(GL_FRONT_AND_BACK, GL_FILL) in RenderText3D. I have attached a patch.%%%

Dalai Felinto commented

2013-01-04 20:02:13 +01:00

%%%The patch seems ok, but what effect do you expect when using wireframe in a text object?%%%

Thomas Szepe commented

2013-01-04 21:38:20 +01:00

%%%A user from the Blendpolis forum uses a box in wireframe mode to get a outline around the selected menu text.
I attached a new file where you can see the effect in the blenderplayer if you move the mouse over the text.

A other uses the wireframe mode for displaying the weapons as wireframe in the weapon select menu.
But without the fix the text also render in wireframe in the blenderplayer.
%%%

%%%A user from the Blendpolis forum uses a box in wireframe mode to get a outline around the selected menu text. I attached a new file where you can see the effect in the blenderplayer if you move the mouse over the text. A other uses the wireframe mode for displaying the weapons as wireframe in the weapon select menu. But without the fix the text also render in wireframe in the blenderplayer. %%%

Thomas Szepe commented

2013-01-05 15:58:05 +01:00

%%%I don't want to render the text in wireframe. I want to render it filled like in the embedded player.

Sorry if I confused you with my second post. What I want to write was.
In the GPC_RenderTools.cpp there is glPolygonMode(GL_FRONT_AND_BACK, GL_FILL) in RenderText3D missing.
%%%

%%%I don't want to render the text in wireframe. I want to render it filled like in the embedded player. Sorry if I confused you with my second post. What I want to write was. In the GPC_RenderTools.cpp there is glPolygonMode(GL_FRONT_AND_BACK, GL_FILL) in RenderText3D missing. %%%

Dalai Felinto commented

2013-01-09 20:32:55 +01:00

%%%I talked with Diego Borghetti (blf mantainer) and he said the patch is ok, but it should add a glGet before changing it to restore the polygon mode state after the text is drawn.
At first I thought he may wanted to handle this inside BLF, thus the delay in the review.

Can you do the above changes? Thanks%%%

%%%I talked with Diego Borghetti (blf mantainer) and he said the patch is ok, but it should add a glGet before changing it to restore the polygon mode state after the text is drawn. At first I thought he may wanted to handle this inside BLF, thus the delay in the review. Can you do the above changes? Thanks%%%

Mitchell Stokes commented

2013-01-10 01:50:46 +01:00

%%%I'd try to avoid glGet if possible. It slows things down and I've been trying to remove all uses of it in the BGE. Maybe use glPushAttrib instead? However, that might be deprecated.%%%

Thomas Szepe commented

2013-01-10 22:30:11 +01:00

%%%I have now written two new patches one with glGet and one with glPushAttrib. So you can choose the patch you like.
I've been looking into the source code and found both commands.
The command glPushAttrib works up to OpenGL 2.1 and does no longer exists in OpenGL 3.0.

But I think that it is unnecessary to store and restore the value, because the font object is at the end of the render loop in front PostRenderScene call.%%%

%%%I have now written two new patches one with glGet and one with glPushAttrib. So you can choose the patch you like. I've been looking into the source code and found both commands. The command glPushAttrib works up to OpenGL 2.1 and does no longer exists in OpenGL 3.0. But I think that it is unnecessary to store and restore the value, because the font object is at the end of the render loop in front PostRenderScene call.%%%

Mitchell Stokes commented

2013-06-20 08:23:48 +02:00

%%%The embedded player doesn't bother with attempting to restore the previous state, so the Blenderplayer shouldn't either. Although, looking at KX_BlenderGL::DisableForText(), it looks like the Blenderplayer is also not disabling the following: alpha blending, alpha testing, lighting , and color materials. I'm thinking the solution should be to copy the code from DisableForText() and put it into GPC_RenderTools::RenderText3D, so the two RenderTools are identical in this aspect again. Fairly soon I plan to get both players onto a single RenderTools (or drop RenderTools and merge it completely into the rasterizer), but until then, we might as well get this bug fixed.%%%

Thomas Szepe commented

2013-06-20 14:38:18 +02:00

%%%I don't added KX_BlenderGL::DisableForText() the other disable for alpha blending, alpha testing, lighting and color materials, because so the user can decide if he want to
render the Text shadeless or not.

My suggestion is to remove the disable calls from the KX_BlenderGL::DisableForText() to, if it doesn't makes any other problems.

%%%

%%%I don't added KX_BlenderGL::DisableForText() the other disable for alpha blending, alpha testing, lighting and color materials, because so the user can decide if he want to render the Text shadeless or not. My suggestion is to remove the disable calls from the KX_BlenderGL::DisableForText() to, if it doesn't makes any other problems. %%%

Mitchell Stokes commented

2013-06-21 00:40:40 +02:00

%%%I've committed your fix of adding glPolygonMode(GL_FRONT_AND_BACK, GL_FILL) to GPC_RenderTools::RenderText3D as r57623. I did not commit any of the glGet/glPushAttrib code as I think this is unnecessary and just slows things down. As for copying more of the disables or removing them from DisableForText(), I think that is better left for after the next release (we're supposed to only be doing bug fixes right now).

Thanks for the fix!%%%

%%%I've committed your fix of adding glPolygonMode(GL_FRONT_AND_BACK, GL_FILL) to GPC_RenderTools::RenderText3D as r57623. I did not commit any of the glGet/glPushAttrib code as I think this is unnecessary and just slows things down. As for copying more of the disables or removing them from DisableForText(), I think that is better left for after the next release (we're supposed to only be doing bug fixes right now). Thanks for the fix!%%%

Mitchell Stokes commented

2013-06-21 00:40:40 +02:00

Changed status from 'Open' to: 'Resolved'

Mitchell Stokes closed this issue

2013-06-21 00:40:40 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Text Font Bug #33163