Make Local on linked mesh object: object gets removed if redo function is used #34446

New Issue

CodeManX · 2013-02-26T17:04:55+01:00

CodeManX commented

2013-02-26 17:04:55 +01:00

%%%--- Blender version with error, and version that worked ---
2.66-official

- Short description of error ---

If one changes the type for Make Local operator in Redo panel, object disappears (from scene as well as from bpy.data.objects)

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

Save default scene (cube) to .blend for linking that cube later
Open new scene
File > Link
Add the cube from .blend (step 1)
Click menu Object > Make Local > Selected objects (for instance, any type will work)
Change type of the operation in Redo panel to something else
Cube vanishes

Redo should either be disabled for this op, or made working.%%%

%%%--- Blender version with error, and version that worked --- 2.66-official - Short description of error --- If one changes the type for Make Local operator in Redo panel, object disappears (from scene as well as from bpy.data.objects) - Steps for others to reproduce the error (preferably based on attached .blend file) --- 1) Save default scene (cube) to .blend for linking that cube later 2) Open new scene 3) File > Link 4) Add the cube from .blend (step 1) 5) Click menu Object > Make Local > Selected objects (for instance, any type will work) 6) Change type of the operation in Redo panel to something else 7) Cube vanishes Redo should either be disabled for this op, or made working.%%%

CodeManX commented

2013-02-26 17:04:55 +01:00

Changed status to: 'Open'

blender-admin commented

2013-02-26 17:04:55 +01:00

#44858 was marked as duplicate of this issue

blender-admin commented

2013-02-26 17:04:55 +01:00

#40428 was marked as duplicate of this issue

Ton Roosendaal commented

2013-02-26 19:19:21 +01:00

%%%Will investigate it.%%%

CodeManX commented

2013-02-26 21:15:37 +01:00

%%%I later notices these messages in system console (no report popup showed however):

Object Cube.001 lost data.
Warning: Warning in console
Warning: LIB ERROR: object lost from scene: 'Scene'%%%

%%%I later notices these messages in system console (no report popup showed however): Object Cube.001 lost data. Warning: Warning in console Warning: LIB ERROR: object lost from scene: 'Scene'%%%

Sergey Sharybin commented

2014-05-30 11:02:54 +02:00

Added subscriber: @mutantbob

Sergey Sharybin commented

2014-05-30 11:02:54 +02:00

◀ Merged tasks: #40428.

Ton Roosendaal was unassigned by Julian Eisel

2014-12-26 17:09:43 +01:00

Julian Eisel commented

2014-12-26 17:09:43 +01:00

Added subscriber: @JulianEisel

mathieu menuet commented

2015-06-17 09:44:24 +02:00

Added subscriber: @bliblubli

Bastien Montagne was assigned by Julian Eisel

2015-07-30 12:01:49 +02:00

Julian Eisel commented

2015-07-30 12:01:49 +02:00

Added subscriber: @mont29

Julian Eisel commented

2015-07-30 12:01:49 +02:00

Old bug and nobody assigned to it :/ Maybe @mont29 can give it a go?

Bastien Montagne commented

2015-08-25 12:12:51 +02:00

Added subscribers: @carlosdp, @MarioSottile

Bastien Montagne commented

2015-08-25 17:34:19 +02:00

Added subscribers: @Sergey, @ideasman42

Bastien Montagne commented

2015-08-25 17:34:19 +02:00

pfffff… this is a very nice can of worms. :(

So, as found by @carlosdp in D1376, the issue is that we do not re-read lib data blocks and ID placholders (ID_ID bheads) in undo context (in blo_read_file_internal), because BLO_read_from_memfile copies lib datablocks and Main data directly from oldmain. The idea being, linked data do not change from undo/redo.

This is valid as long as linked data was not changed by the undo step - but if some was deleted, it will be missing from oldmain, leading to data loss (note that does not only concerns objects, all linkable data types can be affected).

Now, we do can address that issue, by carefully mixing reuse of needed data from oldmain, and "normal" re-reading of missing one, see D1485. We already swim in some rather dark waters here imho, this gives a rather non-easy-to-follow code, but it seems to work quite well from some quick tests.

Nasty thing now: this leads us to another issue - re-reading some data from libraries means its address won't be the same as previously. Henceforth, any further redo will lose the data again, because it will try to find it (in fd->libmap) based on its old address.

I guess we could store someway in new ID that old address, but have the feeling that would be swimming in pitch black waters. So I’d end up voting for @carlosdp solution - revert that “smart” trick in undos - that, or accept the bug. Unless someone has a better idea? @ideasman42, @Sergey?

pfffff… this is a very nice can of worms. :( So, as found by @carlosdp in [D1376](https://archive.blender.org/developer/D1376), the issue is that we do not re-read lib data blocks and ID placholders (ID_ID bheads) in undo context (in `blo_read_file_internal`), because `BLO_read_from_memfile` copies lib datablocks and Main data directly from oldmain. The idea being, linked data do not change from undo/redo. This is valid as long as linked data was not changed by the undo step - but if some was deleted, it will be missing from oldmain, leading to data loss (note that does not only concerns objects, all linkable data types can be affected). Now, we do can address that issue, by carefully mixing reuse of needed data from oldmain, and "normal" re-reading of missing one, see [D1485](https://archive.blender.org/developer/D1485). We already swim in some rather dark waters here imho, this gives a rather non-easy-to-follow code, but it seems to work quite well from some quick tests. Nasty thing now: this leads us to another issue - re-reading some data from libraries means its address won't be the same as previously. Henceforth, any further redo will lose the data again, because it will try to find it (in fd->libmap) based on its old address. I guess we could store someway in new ID that old address, but have the feeling that would be swimming in pitch black waters. So I’d end up voting for @carlosdp solution - revert that “smart” trick in undos - that, or accept the bug. Unless someone has a better idea? @ideasman42, @Sergey?

Bastien Montagne commented

2015-08-25 20:10:39 +02:00

Hehe, actually, some pause was useful here - fixing the last point was simply a matter of adding old->new ID address to fd->libmap…

So, patch in D1485 seems to work OK - from quick tests. Would be nice if some user with complex lib-using file could stress-test it a bit…

Hehe, actually, some pause was useful here - fixing the last point was simply a matter of adding old->new ID address to fd->libmap… So, patch in [D1485](https://archive.blender.org/developer/D1485) seems to work OK - **from quick tests**. Would be nice if some user with complex lib-using file could stress-test it a bit…

blender-admin commented

2015-10-12 12:15:05 +02:00

This issue was referenced by 07332dd2bb

This issue was referenced by 07332dd2bbe62506bef89ffad22ad01766922c8e

Bastien Montagne commented

2015-10-12 12:18:05 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2015-10-12 12:18:05 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Make Local on linked mesh object: object gets removed if redo function is used #34446