"Save Copy" option misfunction #37011

New Issue

Dalai Felinto · 2013-10-09T19:03:54+02:00

Dalai Felinto commented

2013-10-09 19:03:54 +02:00

%%%--- Blender version with error, and version that worked ---
Blender 2.69RC, OSX

- Short description of error ---

If I save the file with the "Save Copy" option Blender still sets bpy.filepath to be the new name.
What I expected (and what I see in other apps, e.g., Photoshop) is to be back in my original file after saving a copy.

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

open blender
save the file as //test.blend
add a monkey
save the file with the 'Save Copy' option on, as //monkey.blend
in Python Console write: bpy.data.filepath
what I get: //monkey.blend
what I expected: //test.blend

And I expect to see the monkey on the screen, even though //test.blend has no monkey. In other words, the solution cannot be simply to load the previously saved file.
%%%

%%%--- Blender version with error, and version that worked --- Blender 2.69RC, OSX - Short description of error --- If I save the file with the "Save Copy" option Blender still sets bpy.filepath to be the new name. What I expected (and what I see in other apps, e.g., Photoshop) is to be back in my original file after saving a copy. - Steps for others to reproduce the error (preferably based on attached .blend file) --- 1) open blender 2) save the file as //test.blend 3) add a monkey 4) save the file with the 'Save Copy' option on, as //monkey.blend 5) in Python Console write: bpy.data.filepath what I get: //monkey.blend what I expected: //test.blend And I expect to see the monkey on the screen, even though //test.blend has no monkey. In other words, the solution cannot be simply to load the previously saved file. %%%

Dalai Felinto commented

2013-10-09 19:03:54 +02:00

Changed status to: 'Open'

Campbell Barton commented

2013-10-09 19:22:49 +02:00

%%%Can't redo this error or Linux, tested trunk but nothing related changed since tagging.%%%

Dalai Felinto commented

2013-10-09 20:19:56 +02:00

%%%here it happens if I save as (shift+cmd+s), but it works fine if I "save copy" (ctrl+alt+s).

My real use case is that I'm saving a file from a script using:
bpy.ops.wm.save_as_mainfile(filepath="/Users/dfelinto/Desktop/copy.blend", copy=True)

And it behaves wrongly as described here, although copy is set to True.%%%

%%%here it happens if I save as (shift+cmd+s), but it works fine if I "save copy" (ctrl+alt+s). My real use case is that I'm saving a file from a script using: bpy.ops.wm.save_as_mainfile(filepath="/Users/dfelinto/Desktop/copy.blend", copy=True) And it behaves wrongly as described here, although copy is set to True.%%%

Dalai Felinto commented

2013-10-09 20:39:25 +02:00

%%%That's really strange. It seems that sometimes it works and sometimes not.
So far if I set 'Save Copy' manually it re-set the flag. I think I know what the problem is (without looking at the code):
'copy' is probably being saved in the operator props.

I'll see if RNA_def_property_flag(prop, PROP_SKIP_SAVE); fix that.

%%%

%%%That's really strange. It seems that sometimes it works and sometimes not. So far if I set 'Save Copy' manually it re-set the flag. I think I know what the problem is (without looking at the code): 'copy' is probably being saved in the operator props. I'll see if RNA_def_property_flag(prop, PROP_SKIP_SAVE); fix that. %%%

Campbell Barton commented

2013-10-09 21:20:37 +02:00

%%%Dalai, ah thats it, 'save as' uses last use save-a-copy prop, pls commit PROP_SKIP_SAVE, it will fix the issue.%%%

Dalai Felinto commented

2013-10-09 21:30:34 +02:00

%%%fixed on rev.60644
I think there is still strange going on, but I'll investigate it separately ;)%%%

%%%fixed on rev.60644 I think there is still strange going on, but I'll investigate it separately ;)%%%

Dalai Felinto commented

2013-10-09 22:10:09 +02:00

%%%Reopening, I found the other issue I was having (and the reason the report was confusing).

Basically if I open Blender, do not save the file, and do a bpy.ops.wm.save_as_mainfile(filepath='whatever.blend', copy=True) it will save as, instead of copy.
(easier way to check is by printing bpy.data.filepath before and after calling the operator)%%%

%%%Reopening, I found the other issue I was having (and the reason the report was confusing). Basically if I open Blender, do not save the file, and do a bpy.ops.wm.save_as_mainfile(filepath='whatever.blend', copy=True) it will save as, instead of copy. (easier way to check is by printing bpy.data.filepath before and after calling the operator)%%%

Campbell Barton commented

2013-10-09 22:28:22 +02:00

%%%fixed r60649.%%%

Campbell Barton commented

2013-10-09 22:28:22 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2013-10-09 22:28:22 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

"Save Copy" option misfunction #37011