Cycles CPU render limited to 5 float textures #37264

New Issue

Ragnar Brynjúlfsson · 2013-10-30T19:01:15+01:00

2013-10-30 19:01:15 +01:00

Relates to: #36272

%%%--- Operating System, Graphics card ---
Ubuntu 12.04, 64-bit, Nvidia GTX 760

- Blender version with error, and version that worked ---

Error is in Blender 2.68a (sub 0), build revision 58536
Error is also in Blender 2.69 (sub 0), build revision 60991

- Short description of error ---

You cannot render with more than 5 float textures, when using Cycles, both on the GPU and CPU. It will output:
ImageManager::add_image: float image limit reached 5, skipping '/home/ragtag/linear_texture.exr'

This is a limitation introduced with commit 44698, with the svn log message:

"Cycles: float texture support. Due to GPU limitations there are now 95 byte,
and 5 float image textures. For CPU render this limit will be lifted later
on with image cache support. Patch by Mike Farnsworth."

This is a limitation the Fermi architecture, but shouldn't be applied to CPU renders.

For a linear workflow, it's important to be able to use float textures, as you'll often be converting 8-bit sRGB textures to 16-bit linear, and will loose a bit of information if you use 8-bit linear instead.

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

Create 6 planes
Add 6 diffuse shaders...
...with 6 float textures.
Render in Cycles.
5 planes will render fine, the 6th will be purple.
%%%

**Relates to**: #36272 %%%--- Operating System, Graphics card --- Ubuntu 12.04, 64-bit, Nvidia GTX 760 - Blender version with error, and version that worked --- Error is in Blender 2.68a (sub 0), build revision 58536 Error is also in Blender 2.69 (sub 0), build revision 60991 - Short description of error --- You cannot render with more than 5 float textures, when using Cycles, both on the GPU and CPU. It will output: ImageManager::add_image: float image limit reached 5, skipping '/home/ragtag/linear_texture.exr' This is a limitation introduced with commit 44698, with the svn log message: "Cycles: float texture support. Due to GPU limitations there are now 95 byte, and 5 float image textures. For CPU render this limit will be lifted later on with image cache support. Patch by Mike Farnsworth." This is a limitation the Fermi architecture, but shouldn't be applied to CPU renders. For a linear workflow, it's important to be able to use float textures, as you'll often be converting 8-bit sRGB textures to 16-bit linear, and will loose a bit of information if you use 8-bit linear instead. - Steps for others to reproduce the error (preferably based on attached .blend file) --- Create 6 planes Add 6 diffuse shaders... ...with 6 float textures. Render in Cycles. 5 planes will render fine, the 6th will be purple. %%%

Ragnar Brynjúlfsson commented

2013-10-30 19:01:15 +01:00

Changed status to: 'Open'

Thomas Dinges commented

2013-10-30 19:36:04 +01:00

%%%This is a known design limitation at the moment, so I would not consider this a bug, but a item for the todo list.

Your opinion Brecht? %%%

%%%This is a known design limitation at the moment, so I would not consider this a bug, but a item for the todo list. Your opinion Brecht? %%%

Oskar Gargas commented

2013-10-30 20:14:44 +01:00

%%%If I may agitate as a person used to Mudbox/Mari/Softimage pipeline - working with FP EXR for displacement, normals and very often color maps is a standard.
I've spend last two days wondering why Blender is rendering only some of my textures. Randomly chosen on each re-render. I've been using CPU only as those textures went above my GPU memory limits right away.

I'd say please lift CPU 5-tex limit ASAP or if it is something hard to do please consider providing some info/error to users when they hit the limit. As I said before I spend last two days with multiple UDIM model, eventually changeing all I could to PNGs... but without seeing any info why before I run on this bug report.%%%

%%%If I may agitate as a person used to Mudbox/Mari/Softimage pipeline - working with FP EXR for displacement, normals and very often color maps is a standard. I've spend last two days wondering why Blender is rendering only some of my textures. Randomly chosen on each re-render. I've been using CPU only as those textures went above my GPU memory limits right away. I'd say please lift CPU 5-tex limit ASAP or if it is something hard to do please consider providing some info/error to users when they hit the limit. As I said before I spend last two days with multiple UDIM model, eventually changeing all I could to PNGs... but without seeing any info why before I run on this bug report.%%%

Bogdan Nedkov commented

2013-12-12 00:38:56 +01:00

Added subscriber: @bned

Thomas Dinges commented

2013-12-14 12:24:24 +01:00

@brecht: Possible fix. I tested this with 6.hdrs on CPU, rendered ok. GPU still limited to 5.

diff --git a/intern/cycles/kernel/kernel_globals.h b/intern/cycles/kernel/kernel_globals.h
index e60bd6c..18ec474 100644

  - a/intern/cycles/kernel/kernel_globals.h

+++ b/intern/cycles/kernel/kernel_globals.h
@@ -32,7 +32,7 @@ struct OSLShadingSystem;

#endif

#define MAX_BYTE_IMAGES 512

#define MAX_FLOAT_IMAGES 5

+#define MAX_FLOAT_IMAGES  32
 
 typedef struct KernelGlobals {
 	texture_image_uchar4 texture_byte_images[MAX_BYTE_IMAGES];
diff --git a/intern/cycles/render/image.cpp b/intern/cycles/render/image.cpp
index dcb2845..91aae6f 100644

  - a/intern/cycles/render/image.cpp

+++ b/intern/cycles/render/image.cpp
@@ -170,7 +170,7 @@ int ImageManager::add_image(const string& filename, void *builtin_data, bool ani
 
 		if(slot == float_images.size()) {
 			/* max images limit reached */

if(float_images.size() == TEX_NUM_FLOAT_IMAGES) {

+			if(float_images.size() == tex_num_float_images) {
 				printf("ImageManager::add_image: float image limit reached %d, skipping '%s'\n",
 				       tex_num_float_images, filename.c_str());
 				return -1;
diff --git a/intern/cycles/render/image.h b/intern/cycles/render/image.h
index f7be545..cfb47d0 100644

  - a/intern/cycles/render/image.h

+++ b/intern/cycles/render/image.h
@@ -30,7 +30,7 @@ CCL_NAMESPACE_BEGIN

define TEX_NUM_IMAGES 95
define TEX_IMAGE_BYTE_START TEX_NUM_FLOAT_IMAGES

#define TEX_EXTENDED_NUM_FLOAT_IMAGES 5

+#define TEX_EXTENDED_NUM_FLOAT_IMAGES	32

define TEX_EXTENDED_NUM_IMAGES 512
define TEX_EXTENDED_IMAGE_BYTE_START TEX_EXTENDED_NUM_FLOAT_IMAGES

@brecht: Possible fix. I tested this with 6.hdrs on CPU, rendered ok. GPU still limited to 5. ``` diff --git a/intern/cycles/kernel/kernel_globals.h b/intern/cycles/kernel/kernel_globals.h index e60bd6c..18ec474 100644 ``` - a/intern/cycles/kernel/kernel_globals.h ``` +++ b/intern/cycles/kernel/kernel_globals.h @@ -32,7 +32,7 @@ struct OSLShadingSystem; ``` #endif ``` ``` #define MAX_BYTE_IMAGES 512 - #define MAX_FLOAT_IMAGES 5 ``` +#define MAX_FLOAT_IMAGES 32 typedef struct KernelGlobals { texture_image_uchar4 texture_byte_images[MAX_BYTE_IMAGES]; diff --git a/intern/cycles/render/image.cpp b/intern/cycles/render/image.cpp index dcb2845..91aae6f 100644 ``` - a/intern/cycles/render/image.cpp ``` +++ b/intern/cycles/render/image.cpp @@ -170,7 +170,7 @@ int ImageManager::add_image(const string& filename, void *builtin_data, bool ani if(slot == float_images.size()) { /* max images limit reached */ ``` - if(float_images.size() == TEX_NUM_FLOAT_IMAGES) { ``` + if(float_images.size() == tex_num_float_images) { printf("ImageManager::add_image: float image limit reached %d, skipping '%s'\n", tex_num_float_images, filename.c_str()); return -1; diff --git a/intern/cycles/render/image.h b/intern/cycles/render/image.h index f7be545..cfb47d0 100644 ``` - a/intern/cycles/render/image.h ``` +++ b/intern/cycles/render/image.h @@ -30,7 +30,7 @@ CCL_NAMESPACE_BEGIN ``` - define TEX_NUM_IMAGES 95 - define TEX_IMAGE_BYTE_START TEX_NUM_FLOAT_IMAGES ``` ``` - #define TEX_EXTENDED_NUM_FLOAT_IMAGES 5 ``` +#define TEX_EXTENDED_NUM_FLOAT_IMAGES 32 ``` - define TEX_EXTENDED_NUM_IMAGES 512 - define TEX_EXTENDED_IMAGE_BYTE_START TEX_EXTENDED_NUM_FLOAT_IMAGES

blender-admin commented

2013-12-14 15:07:46 +01:00

This issue was referenced by blender/blender-addons-contrib@1bebdc9ad0

This issue was referenced by blender/blender-addons-contrib@1bebdc9ad0b6174a9aee243ad37fcc20db23791c

blender-admin commented

2013-12-14 15:07:46 +01:00

This issue was referenced by 1bebdc9ad0

This issue was referenced by 1bebdc9ad0b6174a9aee243ad37fcc20db23791c

Thomas Dinges commented

2013-12-14 15:26:07 +01:00

Changed status from 'Open' to: 'Resolved'

Thomas Dinges closed this issue