Cycles / CUDA detection fails when Blenders path contains umlauts. #37817

New Issue

Thomas Dinges · 2013-12-14T17:41:40+01:00

Thomas Dinges commented

2013-12-14 17:41:40 +01:00

System Information
Windows 7 x64, Geforce 540M

Blender Version
Broken: Blender 2.69.7

Short description of error
CUDA does not show up in the User Preferences, if Blender is located in a directory with umlauts. (like D:\blender_dev\install\blenderöä)

I am not sure where the exact error is, but it might be inside OIIO: this_program_path() uses GetModuleFileName() to retreive the path, I guess GetModuleFileNameW() should be used here.

I tried to hack something together and recompiled the OIIO lib, but the error in Cycles remained. So either my code is wrong or the problem is somewhere else.

diff --git a/src/libutil/sysutil.cpp b/src/libutil/sysutil.cpp
index 0c862bb..9bac5c1 100644

  - a/src/libutil/sysutil.cpp

+++ b/src/libutil/sysutil.cpp
@@ -73,6 +73,7 @@

#include "dassert.h"

#include "sysutil.h"

+#include "strutil.h"
 
 OIIO_NAMESPACE_ENTER
 {
@@ -234,8 +235,14 @@ Sysutil::this_program_path ()
         r = size;

#elif defined(_WIN32)

     // According to MSDN...

unsigned int size = sizeof(filename);
int r = GetModuleFileName (NULL, filename, size);

+	
+	wchar_t filename16[10240];
+	filename16[0] = 0;
+    unsigned int size = sizeof(filename16);
+    int r = GetModuleFileNameW (NULL, filename16, size);
+	
+	if (r > 0)
+        return Strutil::utf16_to_utf8(filename16);

#elif defined(FreeBSD) || defined(FreeBSD_kernel)

     int mib[4];
     mib[0] = CTL_KERN;

**System Information** Windows 7 x64, Geforce 540M **Blender Version** Broken: Blender 2.69.7 **Short description of error** CUDA does not show up in the User Preferences, if Blender is located in a directory with umlauts. (like D:\blender_dev\install\blenderöä\) I am not sure where the exact error is, but it might be inside OIIO: this_program_path() uses GetModuleFileName() to retreive the path, I guess GetModuleFileNameW() should be used here. I tried to hack something together and recompiled the OIIO lib, but the error in Cycles remained. So either my code is wrong or the problem is somewhere else. ``` diff --git a/src/libutil/sysutil.cpp b/src/libutil/sysutil.cpp index 0c862bb..9bac5c1 100644 ``` - a/src/libutil/sysutil.cpp ``` +++ b/src/libutil/sysutil.cpp @@ -73,6 +73,7 @@ ``` #include "dassert.h" ``` ``` #include "sysutil.h" ``` +#include "strutil.h" OIIO_NAMESPACE_ENTER { @@ -234,8 +235,14 @@ Sysutil::this_program_path () r = size; ``` #elif defined(_WIN32) ``` // According to MSDN... ``` - unsigned int size = sizeof(filename); - int r = GetModuleFileName (NULL, filename, size); ``` + + wchar_t filename16[10240]; + filename16[0] = 0; + unsigned int size = sizeof(filename16); + int r = GetModuleFileNameW (NULL, filename16, size); + + if (r > 0) + return Strutil::utf16_to_utf8(filename16); ``` #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ``` int mib[4]; mib[0] = CTL_KERN; ```

Thomas Dinges commented

2013-12-14 17:41:40 +01:00

Changed status to: 'Open'

Thomas Dinges commented

2013-12-14 17:41:40 +01:00

Added subscriber: @ThomasDinges

Thomas Dinges commented

2013-12-14 17:41:51 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2013-12-14 18:28:32 +01:00

OIIO: this_program_path() is not used when Cycles runs from inside Blender. For standalone this fix seems like it would be needed though.

I suspect cuModuleLoad is the problem, I couldn't figure out from the documentation what kind of encoding it expects. Probably utf16 on Windows, but I made a quick patch to use cuModuleLoadData instead which should solve the problem: cycles_utf16_cuda_path.diff

I didn't test this, don't have a Blender build on Windows at the moment.

`OIIO: this_program_path()` is not used when Cycles runs from inside Blender. For standalone this fix seems like it would be needed though. I suspect `cuModuleLoad` is the problem, I couldn't figure out from the documentation what kind of encoding it expects. Probably utf16 on Windows, but I made a quick patch to use `cuModuleLoadData` instead which should solve the problem: [cycles_utf16_cuda_path.diff](https://archive.blender.org/developer/F41092/cycles_utf16_cuda_path.diff) I didn't test this, don't have a Blender build on Windows at the moment.

Thomas Dinges commented

2013-12-14 18:49:09 +01:00

I had to change 2 lines to be able to compile it in FILE *path_fopen()

std::wstring path_utf16 = Strutil::utf8_to_utf16(path);
std::wstring mode_utf16 = Strutil::utf8_to_utf16(mode);

The result still fails though.

I had to change 2 lines to be able to compile it in FILE *path_fopen() std::wstring path_utf16 = Strutil::utf8_to_utf16(path); std::wstring mode_utf16 = Strutil::utf8_to_utf16(mode); The result still fails though.

Sergey Sharybin commented

2013-12-23 15:26:04 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2013-12-23 15:26:05 +01:00

Is someone looking into this issue?

Thomas Dinges commented

2013-12-25 14:05:52 +01:00

Didn't checked further since Brechts patch.

blender-admin commented

2014-01-11 00:47:58 +01:00

This issue was referenced by blender/blender-addons-contrib@241fccaf6a

This issue was referenced by blender/blender-addons-contrib@241fccaf6a113963598e5ad040e7e72c857bea00

blender-admin commented

2014-01-11 00:47:58 +01:00

This issue was referenced by 241fccaf6a

This issue was referenced by 241fccaf6a113963598e5ad040e7e72c857bea00

Brecht Van Lommel commented

2014-01-11 00:58:26 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2014-01-11 00:58:26 +01:00

Brecht Van Lommel commented

2014-01-11 00:58:26 +01:00

Closed by commit 241fccaf6a.

Closed by commit 241fccaf6a.

Lauri Lehmus commented

2014-01-13 16:10:57 +01:00

Added subscriber: @late-4

Lauri Lehmus commented

2014-01-13 16:10:57 +01:00

This fix did not work. I played around bit, and came up with this and it does not crash anymore:

static boost::filesystem::path to_boost(const string& path)
{

ifdef _MSC_VER

std::wstring path_utf16;
path_utf16.assign(path.begin(), path.end());
return boost::filesystem::path(path_utf16);

else

return boost::filesystem::path(path);

endif

}

static string from_boost(const boost::filesystem::path& path)
{

ifdef _MSC_VER

string s8;
std::wstring ws = path.wstring();
s8.assign(ws.begin(), ws.end());
return s8;

else

return path.string();

endif

}

This fix did not work. I played around bit, and came up with this and it does not crash anymore: static boost::filesystem::path to_boost(const string& path) { # ifdef _MSC_VER std::wstring path_utf16; path_utf16.assign(path.begin(), path.end()); return boost::filesystem::path(path_utf16); # else return boost::filesystem::path(path); # endif } static string from_boost(const boost::filesystem::path& path) { # ifdef _MSC_VER string s8; std::wstring ws = path.wstring(); s8.assign(ws.begin(), ws.end()); return s8; # else return path.string(); # endif }

Lauri Lehmus commented

2014-01-13 16:11:12 +01:00

Changed status from 'Resolved' to: 'Open'

Lauri Lehmus reopened this issue

2014-01-13 16:11:12 +01:00

Brecht Van Lommel commented

2014-01-14 20:03:25 +01:00

I don't think we can simply assign a utf8 string to an utf16 string like that, that won't work for non-ascii characters as far as I know.

Committed a tweak to my fix, which works for me anyway:
{d980c3eccbd020a9ff7137659e7cbfbc5adb125d}

I don't think we can simply assign a utf8 string to an utf16 string like that, that won't work for non-ascii characters as far as I know. Committed a tweak to my fix, which works for me anyway: {d980c3eccbd020a9ff7137659e7cbfbc5adb125d}

Brecht Van Lommel commented

2014-01-14 20:03:41 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2014-01-14 20:03:41 +01:00

Brecht Van Lommel self-assigned this 2014-01-14 20:03:41 +01:00

Thomas Dinges commented

2014-01-14 20:53:07 +01:00

OSL works again, thanks, also no further GPU crashers.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles / CUDA detection fails when Blenders path contains umlauts. #37817

ifdef _MSC_VER

else

endif

ifdef _MSC_VER

else

endif