Transforming keyframes in dope sheet causes weird result in graph editor #38692

New Issue

Sam Brubaker · 2014-02-18T01:15:58+01:00

Sam Brubaker commented

2014-02-18 01:15:58 +01:00

Version: 2.69 official (win 64)

How to reproduce: In the dope sheet of the provided .blend file, select some keyframes and grab/duplicate them. Notice that as you slide those keyframes in the dope sheet, weird, impossible f-curves show up in the graph editor.

Once you left click to drop the keyframes, the curve goes back to normal. This bug is a very minor one, as it has no real effect on the animation. It only affects the appearance of the f-curves during transformation.

Keyframe_Bug.blend

Version: 2.69 official (win 64) How to reproduce: In the dope sheet of the provided .blend file, select some keyframes and grab/duplicate them. Notice that as you slide those keyframes in the dope sheet, weird, impossible f-curves show up in the graph editor. Once you left click to drop the keyframes, the curve goes back to normal. This bug is a very minor one, as it has no real effect on the animation. It only affects the appearance of the f-curves during transformation. [Keyframe_Bug.blend](https://archive.blender.org/developer/F77864/Keyframe_Bug.blend)

Sam Brubaker commented

2014-02-18 01:15:58 +01:00

Changed status to: 'Open'

Sam Brubaker commented

2014-02-18 01:15:58 +01:00

Added subscriber: @rocketman

Joshua Leung commented

2014-02-18 04:24:36 +01:00

Changed status from 'Open' to: 'Archived'

Joshua Leung closed this issue

2014-02-18 04:24:36 +01:00

Joshua Leung self-assigned this 2014-02-18 04:24:36 +01:00

Joshua Leung commented

2014-02-18 04:24:36 +01:00

Without (needing to) checking the file, this sounds like it's simply a case of the keyframes not being sorted until after the transform is completed.

The F-Curve drawing is highly dependent on the keyframes in the curve being in the correct order. For transforms initiated in the Graph Editor, we had to add an extra sorting step after each transform step/update. However, currently, we don't do the same for the Dopesheet as 1) most of the time no-one will notice that it's going weird (since the curves aren't shown there), and 2) introducing this sorting step adds a significant amount of complexity to the code (since we need to keep track of what moved and what hasn't, fiddle all that around, hook it up, etc. etc.). Admittedly, this overhead is one of the reasons updates/tweaks/changes to the Graph Editor transform code are few and far between these days.

(Perhaps the only scenario when people are likely to notice that the curves are going wacko are if they use the default Animation workspace, which shows both editors one on top of the other. Then again, I don't believe that this is the best way to use these editors, and it's definitely not how they were designed...)

Now, unless we get a stream of reports that complain about the stuff jiggling around erratically in the viewport or elsewhere (AND causing significant issues due to that) while transforming keyframes in the dopesheet (from having the time cursor placed in the wrong place), it's probably not worth the trouble to fix this.

Without (needing to) checking the file, this sounds like it's simply a case of the keyframes not being sorted until after the transform is completed. The F-Curve drawing is highly dependent on the keyframes in the curve being in the correct order. For transforms initiated in the Graph Editor, we had to add an extra sorting step after each transform step/update. However, currently, we don't do the same for the Dopesheet as 1) most of the time no-one will notice that it's going weird (since the curves aren't shown there), and 2) introducing this sorting step adds a significant amount of complexity to the code (since we need to keep track of what moved and what hasn't, fiddle all that around, hook it up, etc. etc.). Admittedly, this overhead is one of the reasons updates/tweaks/changes to the Graph Editor transform code are few and far between these days. (Perhaps the only scenario when people are likely to notice that the curves are going wacko are if they use the default Animation workspace, which shows both editors one on top of the other. Then again, I don't believe that this is the best way to use these editors, and it's definitely not how they were designed...) Now, unless we get a stream of reports that complain about the stuff jiggling around erratically in the viewport or elsewhere (AND causing significant issues due to that) while transforming keyframes in the dopesheet (from having the time cursor placed in the wrong place), it's probably not worth the trouble to fix this.

Sam Brubaker commented

2014-02-18 16:23:19 +01:00

Added subscriber: @JoshuaLeung

Sam Brubaker commented

2014-02-18 16:23:19 +01:00

Thanks, @JoshuaLeung! I believe you if you say that this issue is more trouble than it is worth to fix.

One small point, though: More often than not, I do have both the Graph Editor and the Dope Sheet side-by-side together. I think a lot of animators do. I'm not trying to change your mind about this bug; I just wanted to let you know how I work.

Thanks, @JoshuaLeung! I believe you if you say that this issue is more trouble than it is worth to fix. One small point, though: More often than not, I *do* have both the Graph Editor and the Dope Sheet side-by-side together. I think a lot of animators do. I'm not trying to change your mind about this bug; I just wanted to let you know how I work.

Sybren A. Stüvel referenced this issue

2023-03-30 15:30:10 +02:00

Blender development todo list -- Editors #55366

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Transforming keyframes in dope sheet causes weird result in graph editor #38692