blender-2.69/source/blender/freestyle/intern/geometry/VecMat.h:707]: (error) Reference to auto variable returned. #38887

New Issue

Closed

opened 2014-02-28 10:05:53 +01:00 by David Binderman · 14 comments

David Binderman commented

2014-02-28 10:05:53 +01:00

Source code is

  inline Matrix<T, M, N>& transpose() const
  {
      Matrix<T, N, M> res;
      for (unsigned int i = 0; i < M; i++) {
          for (unsigned int j = 0; j < N; j++)
              res(j, i) = this->_coord[i * N + j];
      }
      return res;

Suggest code rework.

Source code is ``` inline Matrix<T, M, N>& transpose() const { Matrix<T, N, M> res; for (unsigned int i = 0; i < M; i++) { for (unsigned int j = 0; j < N; j++) res(j, i) = this->_coord[i * N + j]; } return res; ``` Suggest code rework.

David Binderman commented

2014-02-28 10:05:53 +01:00

Author

Changed status to: 'Open'

Changed status to: 'Open'

David Binderman commented

2014-02-28 10:05:53 +01:00

Author

Added subscriber: @dcb

Added subscriber: @dcb

Bastien Montagne commented

2014-02-28 10:10:49 +01:00

Owner

Added subscribers: @kjym3, @mont29

Added subscribers: @kjym3, @mont29

Campbell Barton commented

2014-02-28 10:46:42 +01:00

Owner

Added subscriber: @ideasman42

Added subscriber: @ideasman42

Campbell Barton commented

2014-02-28 10:46:42 +01:00

Owner

Could you give some more info? What program gives this error?

Could you give some more info? What program gives this error?

Tamito Kajiyama commented

2014-02-28 11:19:34 +01:00

Member

The quoted code is the definition of Matrix.transpose() which is part of the Freestyle code base.
Apparently this method is never used in the Freestyle implementation at the moment.
If the reported error breaks compilation, I would omit the method definition by an #if 0 block for now.

The quoted code is the definition of Matrix.transpose() which is part of the Freestyle code base. Apparently this method is never used in the Freestyle implementation at the moment. If the reported error breaks compilation, I would omit the method definition by an #if 0 block for now.

Thomas Dinges commented

2014-02-28 11:36:27 +01:00

Owner

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges

Tamito Kajiyama was assigned by Thomas Dinges

2014-02-28 11:36:48 +01:00

David Binderman commented

2014-02-28 11:56:07 +01:00

Author

Could you give some more info? What program gives this error?

cppcheck, a static analysis available from sourceforge.

>Could you give some more info? What program gives this error? cppcheck, a static analysis available from sourceforge.

Brecht Van Lommel commented

2014-02-28 16:07:51 +01:00

Owner

Added subscriber: @brecht

Added subscriber: @brecht

Brecht Van Lommel commented

2014-02-28 16:07:51 +01:00

Owner

This code is clearly wrong. The last line should be replaced by:

*this = res;

return *this;

This code is clearly wrong. The last line should be replaced by: *this = res; ``` return *this;

blender-admin commented

2014-02-28 18:15:24 +01:00

This issue was referenced by blender/blender-addons-contrib@da5e6b98c9

This issue was referenced by blender/blender-addons-contrib@da5e6b98c9991c7f113e97bbf856e7bc0161bcc0

blender-admin commented

2014-02-28 18:15:24 +01:00

This issue was referenced by da5e6b98c9

This issue was referenced by da5e6b98c9991c7f113e97bbf856e7bc0161bcc0

Brecht Van Lommel commented

2014-02-28 18:16:29 +01:00

Owner

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2014-02-28 18:16:29 +01:00

Brecht Van Lommel commented

2014-02-28 18:16:29 +01:00

Owner

Closed by commit da5e6b98c9.

Closed by commit da5e6b98c9.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

7 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#38887

No description provided.