Painting Overlay update issue with node texture #39435

New Issue

Leon Cheung · 2014-03-26T17:12:42+01:00

Leon Cheung commented

2014-03-26 17:12:42 +01:00

System Information
Win7 64bit |FX2700M

Blender Version
Broken: 2.70 Hash: b4d259f
Worked: (optional)

Short description of error
When using node texture for painting, the overlay doesn't always update accordingly after tweaking in node editor, which means you have to tweak something or somewhere to have it updated finally, or just reopen .blend files to have it displayed correctly.

Exact steps for others to reproduce the error
Example file for easy analysis:

node_texture_overlay.blend

NOTE: As far as I see, it may not actually effect the final paint result, but might be "unpredictable" sometimes.

Thanks for checking!

**System Information** Win7 64bit |FX2700M **Blender Version** Broken: 2.70 Hash: b4d259f Worked: (optional) **Short description of error** When using node texture for painting, the overlay doesn't always update accordingly after tweaking in node editor, which means you have to tweak something or somewhere to have it updated finally, or just reopen .blend files to have it displayed correctly. ![update_issue.png](https://archive.blender.org/developer/F82676/update_issue.png) **Exact steps for others to reproduce the error** Example file for easy analysis: [node_texture_overlay.blend](https://archive.blender.org/developer/F82678/node_texture_overlay.blend) NOTE: As far as I see, it may not actually effect the final paint result, but might be "unpredictable" sometimes. Thanks for checking!

Leon Cheung commented

2014-03-26 17:12:42 +01:00

Changed status to: 'Open'

Leon Cheung commented

2014-03-26 17:12:42 +01:00

Added subscriber: @ZhangYu

Antonis Ryakiotakis was assigned by Lukas Tönne

2014-03-27 09:28:29 +01:00

Lukas Tönne commented

2014-03-27 09:28:29 +01:00

Added subscribers: @Psy-Fi, @LukasTonne

Lukas Tönne commented

2014-03-27 09:28:29 +01:00

@Psy-Fi Not so familiar with the paint brush code. Texture nodes are generally stupid, could also involve depsgraph.

blender-admin commented

2014-03-27 11:09:50 +01:00

This issue was referenced by blender/blender-addons-contrib@688257d1a2

This issue was referenced by blender/blender-addons-contrib@688257d1a28e980e058b702520aac4885668f0fd

blender-admin commented

2014-03-27 11:09:50 +01:00

This issue was referenced by 688257d1a2

This issue was referenced by 688257d1a28e980e058b702520aac4885668f0fd

Antonis Ryakiotakis commented

2014-03-27 11:17:50 +01:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2014-03-27 11:17:50 +01:00

Antonis Ryakiotakis commented

2014-03-27 11:17:50 +01:00

Closed by commit 688257d1a2.

Closed by commit 688257d1a2.

Antonis Ryakiotakis commented

2014-03-27 12:28:55 +01:00

@LukasTonne, I have found out that we have lots of memory leaks in texture node editor.

I think it is related to ntreeTexBeginExecTree / ntreeTexEndExecTree.

Those two get called many times from different threads and could easily clear data through race conditions. I think it may be a good idea to do locked reference counting for this to work better?

@LukasTonne, I have found out that we have lots of memory leaks in texture node editor. I think it is related to ntreeTexBeginExecTree / ntreeTexEndExecTree. Those two get called many times from different threads and could easily clear data through race conditions. I think it may be a good idea to do locked reference counting for this to work better?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Painting Overlay update issue with node texture #39435