Glitch in baking a mixed SSS shader #40322

New Issue

Daniel Salazar · 2014-05-22T23:28:33+02:00

Daniel Salazar commented

2014-05-22 23:28:33 +02:00

System Information

openSUSE 12.3 64bits
NVIDIA 480GTX SC
AMD FX-8350

Blender Version

Broken: 0865b4f

Short description of error

Dark areas appear in the mix area that are not there in the rendered shader

Exact steps for others to reproduce the error

Press bake on this file Bake_Debug.blend

After it finishes, notice how there is a dark area around the face opening and in the antenas.
This are the areas where the shader mix happens based on vertex colors, however I can discard vertex colors being the culprit since I have tested with image textures wit the same result.

**System Information** openSUSE 12.3 64bits NVIDIA 480GTX SC AMD FX-8350 **Blender Version** Broken: 0865b4f **Short description of error** Dark areas appear in the mix area that are not there in the rendered shader **Exact steps for others to reproduce the error** Press bake on this file [Bake_Debug.blend](https://archive.blender.org/developer/F89746/Bake_Debug.blend) After it finishes, notice how there is a dark area around the face opening and in the antenas. This are the areas where the shader mix happens based on vertex colors, however I can discard vertex colors being the culprit since I have tested with image textures wit the same result.

Daniel Salazar commented

2014-05-22 23:28:33 +02:00

Changed status to: 'Open'

Dalai Felinto was assigned by Daniel Salazar

2014-05-22 23:28:33 +02:00

Daniel Salazar commented

2014-05-22 23:28:33 +02:00

Added subscriber: @zanqdo

Dalai Felinto commented

2014-05-22 23:59:36 +02:00

Simplified it to a single plane (and replaced the vcol with a texture just to make sure that wasn't the issue) - Bake_DebugPlane.blend

Simplified it to a single plane (and replaced the vcol with a texture just to make sure that wasn't the issue) - [Bake_DebugPlane.blend](https://archive.blender.org/developer/F89756/Bake_DebugPlane.blend)

blender-admin commented

2014-05-23 00:46:22 +02:00

This issue was referenced by 81b129d3b8

This issue was referenced by 81b129d3b837e31c0d6d2a9d2a6e39d39e47c1ec

Dalai Felinto commented

2014-05-23 00:48:09 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2014-05-23 00:48:09 +02:00

Dalai Felinto commented

2014-05-23 00:48:09 +02:00

Closed by commit 81b129d3b8.

Closed by commit 81b129d3b8.

Dalai Felinto commented

2014-05-24 17:32:08 +02:00

Changed status from 'Resolved' to: 'Open'

Dalai Felinto reopened this issue

2014-05-24 17:32:08 +02:00

Dalai Felinto commented

2014-05-24 17:32:08 +02:00

Added subscriber: @brecht

Dalai Felinto commented

2014-05-24 17:32:08 +02:00

@brecht do you have any thoughts on that? (see 81b129d3b8). The commit seemed to yield correct results and branched path was handling that this way as well already (was this intentional or an oversight?).

But according to @zanqdo real production file, there is still an issue (instead of getting dark areas he now gets over bright areas). To be honest I get over bright areas in some cases with regular path, but branched path is always correct in my simple sample file. So something may still be broken.

@brecht do you have any thoughts on that? (see 81b129d3b837). The commit seemed to yield correct results and branched path was handling that this way as well already (was this intentional or an oversight?). But according to @zanqdo real production file, there is still an issue (instead of getting dark areas he now gets over bright areas). To be honest I get over bright areas in some cases with regular path, but branched path is always correct in my simple sample file. So something may still be broken.

Brecht Van Lommel commented

2014-05-24 17:49:30 +02:00

Branched path tracing does it different and always traces rays for both, it intentionally works different.

I can't see immediately what's wrong here, but all that should be needed is to match the path and branched path code in kernel_path.h. This 81b129d3b8 fix is definitely wrong because it should do one or the other.

Branched path tracing does it different and always traces rays for both, it intentionally works different. I can't see immediately what's wrong here, but all that should be needed is to match the path and branched path code in kernel_path.h. This 81b129d3b837 fix is definitely wrong because it should do one or the other.

blender-admin commented

2014-05-24 19:22:55 +02:00

This issue was referenced by b3f9117523

This issue was referenced by b3f9117523d33568c6a8df1a34bbb695d3d53e1e

Dalai Felinto commented

2014-05-24 19:23:05 +02:00

ok, reverted 81b129d3b8. I did some tests and the issue doesn't seem to be the kernel_path_subsurface_scatter/kernel_branched_path_subsurface_scatter differences, but the kernel_path_integrate_lighting/kernel_branched_path_integrate_lighting instead. I'll look at that later.

ok, reverted 81b129d3b837. I did some tests and the issue doesn't seem to be the **kernel_path_subsurface_scatter**/**kernel_branched_path_subsurface_scatter** differences, but the **kernel_path_integrate_lighting**/**kernel_branched_path_integrate_lighting** instead. I'll look at that later.

Dalai Felinto commented

2014-05-24 19:23:36 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2014-05-24 19:23:36 +02:00

Dalai Felinto commented

2014-05-24 19:23:36 +02:00

Closed by commit b3f9117523.

Closed by commit b3f9117523.

Dalai Felinto commented

2014-05-25 01:08:59 +02:00

Changed status from 'Resolved' to: 'Open'

Dalai Felinto reopened this issue

2014-05-25 01:08:59 +02:00

blender-admin commented

2014-05-26 21:55:40 +02:00

This issue was referenced by 0efc0d5200

This issue was referenced by 0efc0d5200416f98a9dc4fb4685382b3cf8f68cc

Dalai Felinto commented

2014-05-26 21:56:49 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2014-05-26 21:56:49 +02:00

Dalai Felinto commented

2014-05-26 21:56:49 +02:00

Closed by commit 0efc0d5200.

Closed by commit 0efc0d5200.

Dalai Felinto commented

2014-05-26 21:57:56 +02:00

@brecht alright, it should be fixed now. It was simpler than I thought in the end. Thanks :)
@zanqdo can you please test with your production file? (branched path should've worked though by the way)

@brecht alright, it should be fixed now. It was simpler than I thought in the end. Thanks :) @zanqdo can you please test with your production file? (branched path should've worked though by the way)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Glitch in baking a mixed SSS shader #40322