Major shading errors when mixing a rough refractive shader with a transparent shader according to IOR #40896

Closed
opened 2014-06-30 21:57:17 +02:00 by Adam Friesen · 9 comments

System Information
Win7 64 bit, Ivy Bridge i7 CPU, ATI 7xxx GPU, 16 gigs of RAM

Blender Version
Broken: b5982f7
Worked: Any pre-2.71 release build (and possibly 2.71 itself).

Short description of error
The setup for combining a refractive shader with a transparent shader according to IOR (to get a custom fresnal) will not work properly anymore, now you will get a lot of dark and bright pixels that may get progressively worse with more samples. This only occurs when the roughness is not 0 though, as otherwise it will render properly. I suspect this may have been introduced with the importance sampling upgrade for Beckmann shading, as it seems to only affect post 2.71 release builds.

Exact steps for others to reproduce the error
Open the .blend file below and switch to rendered view to see the error, then change the roughness to 0 to see it render properly.

File
Cycles_shadingErrors.blend

System Information Win7 64 bit, Ivy Bridge i7 CPU, ATI 7xxx GPU, 16 gigs of RAM Blender Version Broken: b5982f7 Worked: Any pre-2.71 release build (and possibly 2.71 itself). **Short description of error** The setup for combining a refractive shader with a transparent shader according to IOR (to get a custom fresnal) will not work properly anymore, now you will get a lot of dark and bright pixels that may get progressively worse with more samples. This only occurs when the roughness is not 0 though, as otherwise it will render properly. I suspect this may have been introduced with the importance sampling upgrade for Beckmann shading, as it seems to only affect post 2.71 release builds. **Exact steps for others to reproduce the error** Open the .blend file below and switch to *rendered view* to see the error, then change the roughness to 0 to see it render properly. **File** [Cycles_shadingErrors.blend](https://archive.blender.org/developer/F96140/Cycles_shadingErrors.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @Ace_Dragon

Added subscriber: @Ace_Dragon

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges

Confirmed, GGX and Beckmann render different here, compared to Blender 2.71.

Confirmed, GGX and Beckmann render different here, compared to Blender 2.71.

Added subscriber: @SebastianRothlisberger

Added subscriber: @SebastianRothlisberger

Added subscriber: @Sergey

Added subscriber: @Sergey

Sergeys recent commit, fixes this file as well. There are no fireflies anymore. But it looks slightly different than in 2.71, not sure this is a bug.

Sergeys recent commit, fixes this file as well. There are no fireflies anymore. But it looks slightly different than in 2.71, not sure this is a bug.

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sergey Sharybin self-assigned this 2014-07-15 15:50:54 +02:00

We're using more appropriate importance sampling for microfasets now, we can't avoid differences in render results. Don't really think it's a bug.

We're using more appropriate importance sampling for microfasets now, we can't avoid differences in render results. Don't really think it's a bug.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#40896
No description provided.