Empty Images not displayed in the right Z order in viewport #41117

New Issue

Flavio Perez · 2014-07-18T14:38:37+02:00

Flavio Perez commented

2014-07-18 14:38:37 +02:00

System Information
Windows

Blender Version
Broken: 2.71

Short description of error
Using empty Images doesn't display well in Wireframe and Bounding box viewport shading modes : Z Order is messed

Exact steps for others to reproduce the error

Create new file
Create 3 or 4 empties with image as display type and load textures
Switch the viewport shading to wireframe or bounding box
The order of the displayed planes is messed (if not, turn around). It looks like the Z is depending on the creation order.

I might be related to https:*developer.blender.org/T28749 and https:*developer.blender.org/T34644 , but I'm not using the Alpha of the images in my case (which I don't care to solve), I just want the right Z order (even if it's grouped by unselected first then selected).

Best regards,
Flavio

**System Information** Windows **Blender Version** Broken: 2.71 **Short description of error** Using empty Images doesn't display well in Wireframe and Bounding box viewport shading modes : Z Order is messed **Exact steps for others to reproduce the error** - Create new file - Create 3 or 4 empties with image as display type and load textures - Switch the viewport shading to wireframe or bounding box - The order of the displayed planes is messed (if not, turn around). It looks like the Z is depending on the creation order. ![order.jpg](https://archive.blender.org/developer/F98398/order.jpg) I might be related to https:*developer.blender.org/T28749 and https:*developer.blender.org/T34644 , but I'm not using the Alpha of the images in my case (which I don't care to solve), I just want the right Z order (even if it's grouped by unselected first then selected). Best regards, Flavio

Flavio Perez commented

2014-07-18 14:38:37 +02:00

Changed status to: 'Open'

Flavio Perez commented

2014-07-18 14:38:37 +02:00

Added subscriber: @flav-3

Bastien Montagne commented

2014-07-18 14:43:11 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-07-18 14:43:11 +02:00

Please always attach a .blend file demonstrating the issue, saves us quite some time!

And I think issue is, since in wire/bbox draw mode we only draw lines, there is no Z sorting done at all…

Please always attach a .blend file demonstrating the issue, saves us quite some time! And I think issue is, since in wire/bbox draw mode we only draw lines, there is no Z sorting done at all…

Flavio Perez commented

2014-07-18 15:22:01 +02:00

Sorry, I forgot you can make a blend file including the external textures (...)
Here you have :

exampleEmptyImage.blend

But I expected some kind of answer like that. Umm..

Sorry, I forgot you can make a blend file including the external textures (...) Here you have : [exampleEmptyImage.blend](https://archive.blender.org/developer/F98414/exampleEmptyImage.blend) But I expected some kind of answer like that. Umm..

Bastien Montagne self-assigned this 2014-07-18 16:23:27 +02:00

Bastien Montagne commented

2014-07-18 16:23:27 +02:00

Thanks, will have a look at that. :)

Bastien Montagne commented

2014-07-20 11:29:07 +02:00

Added subscriber: @Sergey

Bastien Montagne commented

2014-07-20 11:29:07 +02:00

So, issue is indeed ZBuffer is disabled in wire and bbox modes… and we need it for empty images.

Here is a patch that handles this, would like another advice about it though, since it adds another full cycle over base (i.e. all objects in scene)… :/

P91: #41117

diff --git a/source/blender/editors/space_view3d/view3d_draw.c b/source/blender/editors/space_view3d/view3d_draw.c
index d34b3d8..e2abfac 100644
--- a/source/blender/editors/space_view3d/view3d_draw.c
+++ b/source/blender/editors/space_view3d/view3d_draw.c
@@ -752,6 +752,27 @@ static void draw_view_icon(RegionView3D *rv3d, rcti *rect)
 	glDisable(GL_BLEND);
 }
 
+bool view3d_need_zbuf(View3D *v3d, Scene *scene)
+{
+	Base *base;
+
+	if (v3d->drawtype > OB_WIRE) {
+		return true;
+	}
+
+	for (base = scene->base.first; base; base = base->next) {
+		if (v3d->lay & base->lay) {
+			Object *ob = base->object;
+
+			if (ob->type == OB_EMPTY && ob->empty_drawtype == OB_EMPTY_IMAGE) {
+				return true;
+			}
+		}
+	}
+
+	return false;
+}
+
 static const char *view3d_get_name(View3D *v3d, RegionView3D *rv3d)
 {
 	const char *name = NULL;
@@ -1314,7 +1335,7 @@ static void backdrawview3d(Scene *scene, ARegion *ar, View3D *v3d)
 	}
 #endif
 
-	if (v3d->drawtype > OB_WIRE) v3d->zbuf = true;
+	if (view3d_need_zbuf(v3d, scene)) v3d->zbuf = true;
 	
 	/* dithering and AA break color coding, so disable */
 	glDisable(GL_DITHER);
@@ -2603,7 +2624,7 @@ static void view3d_draw_objects(
 		view3d_draw_clipping(rv3d);
 
 	/* set zbuffer after we draw clipping region */
-	if (v3d->drawtype > OB_WIRE) {
+	if (view3d_need_zbuf(v3d, scene)) {
 		v3d->zbuf = true;
 	}
 	else {
diff --git a/source/blender/editors/space_view3d/view3d_intern.h b/source/blender/editors/space_view3d/view3d_intern.h
index 169bc49..4cb9a23 100644
--- a/source/blender/editors/space_view3d/view3d_intern.h
+++ b/source/blender/editors/space_view3d/view3d_intern.h
@@ -186,6 +186,8 @@ void circ(float x, float y, float rad);
 void view3d_update_depths_rect(struct ARegion *ar, struct ViewDepths *d, struct rcti *rect);
 float view3d_depth_near(struct ViewDepths *d);
 
+bool view3d_need_zbuf(struct View3D *v3d, struct Scene *scene);
+
 /* view3d_select.c */
 void VIEW3D_OT_select(struct wmOperatorType *ot);
 void VIEW3D_OT_select_circle(struct wmOperatorType *ot);
diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c
index 716f4b1..2f2e3a7 100644
--- a/source/blender/editors/space_view3d/view3d_view.c
+++ b/source/blender/editors/space_view3d/view3d_view.c
@@ -989,7 +989,7 @@ short view3d_opengl_select(ViewContext *vc, unsigned int *buffer, unsigned int b
 	view3d_winmatrix_set(ar, v3d, &rect);
 	mul_m4_m4m4(vc->rv3d->persmat, vc->rv3d->winmat, vc->rv3d->viewmat);
 	
-	if (v3d->drawtype > OB_WIRE) {
+	if (view3d_need_zbuf(v3d, scene)) {
 		v3d->zbuf = true;
 		glEnable(GL_DEPTH_TEST);
 	}
@@ -1073,8 +1073,8 @@ short view3d_opengl_select(ViewContext *vc, unsigned int *buffer, unsigned int b
 	view3d_winmatrix_set(ar, v3d, NULL);
 	mul_m4_m4m4(vc->rv3d->persmat, vc->rv3d->winmat, vc->rv3d->viewmat);
 	
-	if (v3d->drawtype > OB_WIRE) {
-		v3d->zbuf = 0;
+	if (v3d->zbuf) {
+		v3d->zbuf = false;
 		glDisable(GL_DEPTH_TEST);
 	}
 // XXX	persp(PERSP_WIN);

So, issue is indeed ZBuffer is disabled in wire and bbox modes… and we need it for empty images. Here is a patch that handles this, would like another advice about it though, since it adds another full cycle over `base` (i.e. all objects in scene)… :/ [P91: #41117](https://archive.blender.org/developer/P91.txt) ```diff diff --git a/source/blender/editors/space_view3d/view3d_draw.c b/source/blender/editors/space_view3d/view3d_draw.c index d34b3d8..e2abfac 100644 --- a/source/blender/editors/space_view3d/view3d_draw.c +++ b/source/blender/editors/space_view3d/view3d_draw.c @@ -752,6 +752,27 @@ static void draw_view_icon(RegionView3D *rv3d, rcti *rect) glDisable(GL_BLEND); } +bool view3d_need_zbuf(View3D *v3d, Scene *scene) +{ + Base *base; + + if (v3d->drawtype > OB_WIRE) { + return true; + } + + for (base = scene->base.first; base; base = base->next) { + if (v3d->lay & base->lay) { + Object *ob = base->object; + + if (ob->type == OB_EMPTY && ob->empty_drawtype == OB_EMPTY_IMAGE) { + return true; + } + } + } + + return false; +} + static const char *view3d_get_name(View3D *v3d, RegionView3D *rv3d) { const char *name = NULL; @@ -1314,7 +1335,7 @@ static void backdrawview3d(Scene *scene, ARegion *ar, View3D *v3d) } #endif - if (v3d->drawtype > OB_WIRE) v3d->zbuf = true; + if (view3d_need_zbuf(v3d, scene)) v3d->zbuf = true; /* dithering and AA break color coding, so disable */ glDisable(GL_DITHER); @@ -2603,7 +2624,7 @@ static void view3d_draw_objects( view3d_draw_clipping(rv3d); /* set zbuffer after we draw clipping region */ - if (v3d->drawtype > OB_WIRE) { + if (view3d_need_zbuf(v3d, scene)) { v3d->zbuf = true; } else { diff --git a/source/blender/editors/space_view3d/view3d_intern.h b/source/blender/editors/space_view3d/view3d_intern.h index 169bc49..4cb9a23 100644 --- a/source/blender/editors/space_view3d/view3d_intern.h +++ b/source/blender/editors/space_view3d/view3d_intern.h @@ -186,6 +186,8 @@ void circ(float x, float y, float rad); void view3d_update_depths_rect(struct ARegion *ar, struct ViewDepths *d, struct rcti *rect); float view3d_depth_near(struct ViewDepths *d); +bool view3d_need_zbuf(struct View3D *v3d, struct Scene *scene); + /* view3d_select.c */ void VIEW3D_OT_select(struct wmOperatorType *ot); void VIEW3D_OT_select_circle(struct wmOperatorType *ot); diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c index 716f4b1..2f2e3a7 100644 --- a/source/blender/editors/space_view3d/view3d_view.c +++ b/source/blender/editors/space_view3d/view3d_view.c @@ -989,7 +989,7 @@ short view3d_opengl_select(ViewContext *vc, unsigned int *buffer, unsigned int b view3d_winmatrix_set(ar, v3d, &rect); mul_m4_m4m4(vc->rv3d->persmat, vc->rv3d->winmat, vc->rv3d->viewmat); - if (v3d->drawtype > OB_WIRE) { + if (view3d_need_zbuf(v3d, scene)) { v3d->zbuf = true; glEnable(GL_DEPTH_TEST); } @@ -1073,8 +1073,8 @@ short view3d_opengl_select(ViewContext *vc, unsigned int *buffer, unsigned int b view3d_winmatrix_set(ar, v3d, NULL); mul_m4_m4m4(vc->rv3d->persmat, vc->rv3d->winmat, vc->rv3d->viewmat); - if (v3d->drawtype > OB_WIRE) { - v3d->zbuf = 0; + if (v3d->zbuf) { + v3d->zbuf = false; glDisable(GL_DEPTH_TEST); } // XXX persp(PERSP_WIN); ```

Bastien Montagne commented

2014-07-20 15:37:50 +02:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2014-07-20 15:37:50 +02:00

Bastien Montagne commented

2014-07-20 15:37:50 +02:00

So, as I suspected, this patch has too much influence over wire mode performances…

Closing as TODO/known limitation for now, thanks for the report anyway!

So, as I suspected, this patch has too much influence over wire mode performances… Closing as [TODO/known limitation](http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Editors#3D_View) for now, thanks for the report anyway!

Flavio Perez commented

2014-07-23 11:44:11 +02:00

Thanks for having a look at it !

Let's see if it can be improved in the future.

Thanks for having a look at it ! Let's see if it can be improved in the future.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Empty Images not displayed in the right Z order in viewport #41117