Crash on opening file #42486
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#42486
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Linux Ubuntu 14
nVidia GTX 560 ti
Blender Version
Broken: 2.70b
9e963ae
Worked: 2.71
Short description of error
With the supplied file I get an immediate crash once opening.
Exact steps for others to reproduce the error
Open the attached file in blender (It has been created with version 2.71).
Changed status to: 'Open'
Added subscriber: @hilbert
File which crashes blender: Telefoon.blend
Added subscribers: @ideasman42, @JulianEisel
Hi @hilbert,
I can confirm the issue. You used an array and a mirror modifier with merging enabled in the file, right? The issue seems to lay somewhere there, but maybe the file is just corrupt.
@ideasman42, maybe you could have a look on this? I tried to provoke a crash like this, by playing with arrays and mirrors, without any "luck".
Added subscribers: @PatriceBertrand, @LukasTonne
The file crashes with an invalid read report from adress sanitizer:
https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/cdderivedmesh.c$2970
The issue seems to be that
v_target
index is -1, which is generally allowed for the vtargetmap entries, but is not checked in this loop.DM_is_valid
does not complain, so i assume the mesh itself is not corrupted.@PatriceBertrand: Could you have a look at this? Thanks!
Adding @ideasman42
I will look at it.
The report says:
Broken: 2.70b
9e963ae
Worked: 2.71
Since modified array modifier was introduced in 2.72, I would assume this is not related to new implementation, right ?
Although indeed
https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/cdderivedmesh.c$2970
is in new implementation. So maybe the "broken" indication is wrong ?
I think this is a typo, the commit link says 2.72b instead 2.70
The issue relates to array caps with merge option, caps having a subdivision surface active.
Easy to reproduce: start with default cube, duplicate cube as cube.001, define array modifier on Cube, set merge option, set Cube.001 as start cap / end cap.
Then add a subdivision surface on Cube.001 ==> crash.
For some - unknown at this point - reason, this condition causes the addition of a poly with totloops=0, which thus passes through the all_vertices_merged test:
A few lines further down, we are using the vertex of the first loop of the poly, while not handling the fact that mp->totloop can be null. A test could easily be added there, but that is not the correct solution.
I need to investigate further.
After further investigations, here's where I am:
The cap object's derived mesh is obtained by
Which returns a dm where, in the case of subsurf, polys are wrong. For example, the following snippet:
Will show inconsistent polys.
In my original patch, the cap object's dm was obtained by
Which, does not crash with the crash file, BUT does not apply the cap object's subsurf.
@ideasman42, maybe you know what is the appropriate way of getting the derived mesh with modifiers applied ?
Actually, even though previous versions of Blender did apply the cap object's subsurf if present, it is in most cases not what one would want. For example in the telephone.blend file, there is really no point in having a subsurf on the phone cord's caps BEFORE adding them to the cord. Not only does it give wrong results, but it actually prevents the merge from taking place, because after subsurf, the vertices do are not near enough to be merged. It would be better to add the caps THEN apply the cord's own subsurf.
This makes me think that applying subsurf to caps could be dropped altogether. But I suppose not everyone will agree.
Got it !
At
Should be :
Probably a typo.
This issue was referenced by
723f1e950b
Changed status from 'Open' to: 'Resolved'
Closed by commit
723f1e950b
.This issue was referenced by 2c1a386c9aeb717ddb1ac59536308b0f1374f443