Quick Fur duplicate particle system on edit #43887

New Issue

UnknownFreak · 2015-03-04T17:10:56+01:00

UnknownFreak commented

2015-03-04 17:10:56 +01:00

System Information
Windows 7
Nvidia GTX 660

Blender Version
Broken: 2.73

Short description of error

Every time you edit the values in the quick fur properties window, you will create a duplicate particle system, each time you change a value

Exact steps for others to reproduce the error

If needed add a new mesh of any type
Goto Edit mode
Add quick fur
Change settings in the property window.
Check your particle systems tab

The bug only happens when you change the properties in a quick fur that is added in edit mode, otherwise it will work as intended.

Attached video shows how to reproduce the error
Particle system duplicate - video link (dropbox)
Particle_systemduplicate.mp4 - video download

**System Information** Windows 7 Nvidia GTX 660 **Blender Version** Broken: 2.73 **Short description of error** Every time you edit the values in the quick fur properties window, you will create a duplicate particle system, each time you change a value **Exact steps for others to reproduce the error** 1. If needed add a new mesh of any type 2. Goto Edit mode 3. Add quick fur 4. Change settings in the property window. 5. Check your particle systems tab The bug only happens when you change the properties in a quick fur that is added in edit mode, otherwise it will work as intended. Attached video shows how to reproduce the error [Particle system duplicate](https://dl.dropboxusercontent.com/u/66039636/Blender/Bugs/Particle%20systemduplicate.mp4) - video link (dropbox) [Particle_systemduplicate.mp4](https://archive.blender.org/developer/F147289/Particle_systemduplicate.mp4) - video download

UnknownFreak commented

2015-03-04 17:10:56 +01:00

Changed status to: 'Open'

UnknownFreak commented

2015-03-04 17:10:56 +01:00

Added subscriber: @UnknownFreak

Julian Eisel commented

2015-03-05 23:00:07 +01:00

Added subscribers: @LukasTonne, @ideasman42, @JulianEisel

Julian Eisel commented

2015-03-05 23:00:07 +01:00

Can confirm that. Add quick fur in Edit Mode -> change settings in redo panel -> A new particle system is added.

Not sure what triggers this, but I'd say it's the undo system. Disabling the rna prop update call doesn't work. @ideasman42, @LukasTonne any ideas?

Can confirm that. Add quick fur in Edit Mode -> change settings in redo panel -> A new particle system is added. Not sure what triggers this, but I'd say it's the undo system. Disabling the rna prop update call doesn't work. @ideasman42, @LukasTonne any ideas?

UnknownFreak commented

2015-03-08 17:35:25 +01:00

Downloaded and played with the new testbuild, problem still presisted, so I decided to look up the "quicktools" file (object_quick_effects.py)
and took a look in there, tested some different things, and decided with a friend. For now, the best solution
is to add:

  if context.mode == 'EDIT_MESH':
          bpy.ops.object.mode_set(mode='OBJECT', toggle=True)

in the class QuickFur(Operator):

  def execute(self, context):
      ...
      if not mesh_objects:
          self.report({'ERROR'}, "Select at least one mesh object")
          return {'CANCELLED'}

    #Added code

      if context.mode == 'EDIT_MESH':
          bpy.ops.object.mode_set(mode='OBJECT', toggle=True)

    #Endof added code

      mat = bpy.data.materials.new("Fur Material")
      ...
      return {'FINISHED'}

This will force the user into object mode (where the bug cannot happen).

There is probably a better solution. But it will do for now.

Downloaded and played with the new testbuild, problem still presisted, so I decided to look up the "quicktools" file (object_quick_effects.py) and took a look in there, tested some different things, and decided with a friend. For now, the best solution is to add: ``` if context.mode == 'EDIT_MESH': bpy.ops.object.mode_set(mode='OBJECT', toggle=True) ``` in the class QuickFur(Operator): ``` def execute(self, context): ... if not mesh_objects: self.report({'ERROR'}, "Select at least one mesh object") return {'CANCELLED'} ``` #Added code ``` if context.mode == 'EDIT_MESH': bpy.ops.object.mode_set(mode='OBJECT', toggle=True) ``` #Endof added code ``` mat = bpy.data.materials.new("Fur Material") ... return {'FINISHED'} ``` This will force the user into object mode (where the bug cannot happen). There is probably a better solution. But it will do for now.

Sergey Sharybin commented

2015-03-09 14:35:35 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2015-03-09 14:35:35 +01:00

The issue is caused by edit mode using local undo stack, which doesn't store particle system settings. But i don't think changing object mode is the proper way to go, imo it's better to just forbid adding fur onto objects which are in edit mode: http://www.pasteall.org/57142/diff

P.S. Ic sohuld probably check object's mode is OBJECT, so there's no issues with quick fur called for objects which are in paint/sculpt modes.

The issue is caused by edit mode using local undo stack, which doesn't store particle system settings. But i don't think changing object mode is the proper way to go, imo it's better to just forbid adding fur onto objects which are in edit mode: http://www.pasteall.org/57142/diff P.S. Ic sohuld probably check object's mode is OBJECT, so there's no issues with quick fur called for objects which are in paint/sculpt modes.

Campbell Barton commented

2015-03-10 12:16:36 +01:00

Agree - best just disable this in editmode.