array modifier "fit curve" mode not working properly #44361

New Issue

mathieu menuet · 2015-04-12T12:59:03+02:00

mathieu menuet commented

2015-04-12 12:59:03 +02:00

System Information
all

Blender Version
Broken: 2.74

Short description of error
The full length of the curve is not used by the array modifier, the 2 last copies are missing

Exact steps for others to reproduce the error
Open attached file, above is the buggy "fit curve" version, under it the "fixed count" version, using the full length
test_curve_and_array.blend

**System Information** all **Blender Version** Broken: 2.74 **Short description of error** The full length of the curve is not used by the array modifier, the 2 last copies are missing **Exact steps for others to reproduce the error** Open attached file, above is the buggy "fit curve" version, under it the "fixed count" version, using the full length [test_curve_and_array.blend](https://archive.blender.org/developer/F161172/test_curve_and_array.blend)

mathieu menuet commented

2015-04-12 12:59:03 +02:00

Changed status to: 'Open'

mathieu menuet commented

2015-04-12 12:59:03 +02:00

Added subscriber: @bliblubli

Bastien Montagne commented

2015-04-13 10:50:35 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2015-04-13 10:50:35 +02:00

Yep, there is an error in how number of object is computed from curve length (missing a + 1). Note your curve is slightly too short though, you need to add a tiny bit of length to it to get the other 'missing' copy.

Yep, there is an error in how number of object is computed from curve length (missing a `+ 1`). Note your curve is slightly too short though, you need to add a tiny bit of length to it to get the other 'missing' copy.

Bastien Montagne self-assigned this 2015-04-13 10:50:43 +02:00

blender-admin commented

2015-04-13 10:51:04 +02:00

This issue was referenced by 4fb33d82e2

This issue was referenced by 4fb33d82e251e340d4ffee8efda62cfeb5c03135

Bastien Montagne commented

2015-04-13 10:53:21 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2015-04-13 10:53:21 +02:00

Bastien Montagne commented

2015-04-13 10:53:21 +02:00

Closed by commit 4fb33d82e2.

Closed by commit 4fb33d82e2.

mathieu menuet commented

2015-04-13 19:05:17 +02:00

thanks for the fix :)

Susanne Wigard commented

2016-09-26 07:17:53 +02:00

Added subscriber: @wigarsu

Susanne Wigard commented

2016-09-26 07:17:53 +02:00

Actually I believe this is notthe correct behaviour - it was correct before the fix!

The manual says "Generates enough copies to fit within the length of the curve object specified in Curve."
I suppose it can be argued whether on a line of length n you can fit n or n+1 objectcs of size 1.

According to bliblu bli's version it would be n + 1, with the first and last object sticking out by one half unit over the ends of the curve - but then the total size of these objects would be one unit more than the length of the curve.

Also, the extra object causes problems if you close the curve, or join several of such curves into a chain.

Finally, one application of the array modifier together with the curve modifier would be to place objects along the segmentsof a polygon - but then a polygon with n vertices has only n-1 segments.

Actually I believe this is *not*the correct behaviour - it was correct before the fix! The manual says "Generates enough copies to fit within the length of the curve object specified in Curve." I suppose it can be argued whether on a line of length n you can fit n or n+1 objectcs of size 1. According to bliblu bli's version it would be n + 1, with the first and last object sticking out by one half unit over the ends of the curve - but then the total size of these objects would be one unit more than the length of the curve. Also, the extra object causes problems if you close the curve, or join several of such curves into a chain. Finally, one application of the array modifier together with the curve modifier would be to place objects along the *segments*of a polygon - but then a polygon with n vertices has only n-1 segments.

Susanne Wigard commented

2016-09-26 07:30:12 +02:00

Changed status from 'Resolved' to: 'Open'

Susanne Wigard reopened this issue

2016-09-26 07:30:12 +02:00

Susanne Wigard commented

2016-09-26 07:30:12 +02:00

In addition to my above comment, I would think that the endcap feature is meant to solve bliblu bli's problem. (at least for one of the two missing cubes - the other one is correctly taken into account by adding the epsilon in the fix).

In MOD_array.c, the line

count = (length + eps) / dist + 1;

should be

count = (length + eps) / dist;

In addition to my above comment, I would think that the *endcap* feature is meant to solve bliblu bli's problem. (at least for one of the two missing cubes - the other one is correctly taken into account by adding the epsilon in the fix). In MOD_array.c, the line `count = (length + eps) / dist + 1;` should be `count = (length + eps) / dist;`

Aaron Carlisle commented

2017-02-02 17:29:31 +01:00

Added subscriber: @Blendify

Aaron Carlisle commented

2017-02-02 17:29:31 +01:00

@mont29 can you take a look at the fix?

Bastien Montagne commented

2017-02-02 19:27:30 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2017-02-02 19:27:30 +01:00

Bastien Montagne commented

2017-02-02 19:27:30 +01:00

We can always argure on how fit to curev behaves, but this has nothing to do in this bug report. Should be handled through ML, get stakeholders artists on board to discuss what they want as behavior - keeping into mind that unless there is a really good reason for it, we'd rather not change behavior of working code, this would be really bad when opening older files.

This should never have been re-opened that way, bug tracker is to handle bug, not design tasks or feature requests.

We can always argure on how fit to curev behaves, but this has nothing to do in this bug report. Should be handled through ML, get stakeholders artists on board to discuss what they want as behavior - keeping into mind that unless there is a really good reason for it, we'd rather **not** change behavior of working code, this would be really bad when opening older files. This should never have been re-opened that way, bug tracker is to handle bug, not design tasks or feature requests.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

array modifier "fit curve" mode not working properly #44361