Apple right mouse emulation sending incorrect release event. #44739

New Issue

Francesc Juhe · 2015-05-17T12:07:55+02:00

Francesc Juhe commented

2015-05-17 12:07:55 +02:00

System Information
Any Mac OS X

Blender Version
Broken: All
Worked: None

Short description of error

The file source/blender/windowmanager/intern/wm_event_system.c has this code on line 2913

ifdef APPLE


/* rightmouse emulation */
if (U.flag & USER_TWOBUTTONMOUSE) {
  if (event->type == LEFTMOUSE) {
    
    if (event->val == KM_PRESS && event->oskey) {
      event->type = RIGHTMOUSE;
      event->oskey = 0;
      mmb_emulated = 1;
    }
    else if (event->val == KM_RELEASE) {
      if (mmb_emulated) {
        event->oskey = RIGHTMOUSE;
        event->alt = 0;
      }
      mmb_emulated = 0;
    }
  }
  
}

endif

The KM_RELEASE event is clearing alt and returning oskey as RIGHTMOUSE. Shouldn't it clear oskey and return type as RIGHTMOUSE?

    else if (event->val == KM_RELEASE) {
      if (mmb_emulated) {
        event->type = RIGHTMOUSE;
        event->oskey = 0;
      }
      mmb_emulated = 0;

Exact steps for others to reproduce the error

Doesn't produce errors but the event looks wrong.

**System Information** Any Mac OS X **Blender Version** Broken: All Worked: None **Short description of error** The file source/blender/windowmanager/intern/wm_event_system.c has this code on line 2913 # ifdef __APPLE__ ``` /* rightmouse emulation */ if (U.flag & USER_TWOBUTTONMOUSE) { if (event->type == LEFTMOUSE) { if (event->val == KM_PRESS && event->oskey) { event->type = RIGHTMOUSE; event->oskey = 0; mmb_emulated = 1; } else if (event->val == KM_RELEASE) { if (mmb_emulated) { event->oskey = RIGHTMOUSE; event->alt = 0; } mmb_emulated = 0; } } } ``` # endif The KM_RELEASE event is clearing alt and returning oskey as RIGHTMOUSE. Shouldn't it clear oskey and return type as RIGHTMOUSE? ``` else if (event->val == KM_RELEASE) { if (mmb_emulated) { event->type = RIGHTMOUSE; event->oskey = 0; } mmb_emulated = 0; ``` **Exact steps for others to reproduce the error** Doesn't produce errors but the event looks wrong.

Francesc Juhe commented

2015-05-17 12:07:55 +02:00

Changed status to: 'Open'

Francesc Juhe commented

2015-05-17 12:07:55 +02:00

Added subscriber: @fjuhec

jens verwiebe was assigned by Bastien Montagne

2015-05-17 12:21:04 +02:00

Bastien Montagne commented

2015-05-17 12:21:04 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2015-05-17 12:21:04 +02:00

Please avoid reporting 'suspicious' code as bug… better to do so in our ML (bf-committers) or directly on IRC (#blendercoders on freenode.net).

Jens, can you please check whether this code is correct?

Please avoid reporting 'suspicious' code as bug… better to do so in our ML (bf-committers) or directly on IRC (#blendercoders on freenode.net). Jens, can you please check whether this code is correct?

Brecht Van Lommel commented

2015-05-17 16:22:48 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2015-05-17 16:22:48 +02:00

The code is wrong, but the proposed fix is not enough. It will never actually hit that code path, because of the middle mouse emulation code right above it, so I'll commit a slightly different fix.

Thanks for finding this!

The code is wrong, but the proposed fix is not enough. It will never actually hit that code path, because of the middle mouse emulation code right above it, so I'll commit a slightly different fix. Thanks for finding this!

Francesc Juhe commented

2015-05-17 16:45:27 +02:00

Yes, both emulations conflict as they use the same status variable 'mmb_emulated' and the first changes the event type preventing the second from doing anythong because the event is no longer a left button. But, that would only be an issue if both alt and oskey are pressed and in that case, what key is the user trying to emulate when alt is for middle button and oskey for right button? The code seems to just give priority to middle mouse emulation over right mouse emulation and it seems to matter only for single button mouse or tabled and mac.

I didn't want to go deeper than noticing the km_release for oskey emulated right button was not sending the right value.
I am curious on the final fix.

Yes, both emulations conflict as they use the same status variable 'mmb_emulated' and the first changes the event type preventing the second from doing anythong because the event is no longer a left button. But, that would only be an issue if both alt and oskey are pressed and in that case, what key is the user trying to emulate when alt is for middle button and oskey for right button? The code seems to just give priority to middle mouse emulation over right mouse emulation and it seems to matter only for single button mouse or tabled and mac. I didn't want to go deeper than noticing the km_release for oskey emulated right button was not sending the right value. I am curious on the final fix.

blender-admin commented

2015-05-17 16:55:18 +02:00

This issue was referenced by 43ee3f4040

This issue was referenced by 43ee3f4040a41c637b6eceda4c3aa1046f8a13a5

Brecht Van Lommel commented

2015-05-17 16:56:02 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2015-05-17 16:56:02 +02:00

Brecht Van Lommel commented

2015-05-17 16:56:02 +02:00

Closed by commit 43ee3f4040.

Closed by commit 43ee3f4040.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Apple right mouse emulation sending incorrect release event. #44739

ifdef APPLE

endif