Hovering over 'Search' operator in Add Menu of Node editor when using custom shortcut causes crash #44822

New Issue

Greg Zaal · 2015-05-24T11:53:16+02:00

Greg Zaal commented

2015-05-24 11:53:16 +02:00

System Information
Windows 7 64 bit
also tested Linux 64 bit

Blender Version
Broken: Current master (78250f1), also 2.72 (071ec91), don't have anything older than that

Short description of error
In the Add menu of the node editor is a Search button to search through all the node types - right click it and add a custom shortcut (e.g. Ctrl-A). Now hover over the button, when the tooltip should pop up, blender segfaults.

It doesn't crash if a custom shortcut is not set, and I couldn't reproduce this behaviour with any other button - hovering over other custom shortcuts of mine work just fine.

**System Information** Windows 7 64 bit also tested Linux 64 bit **Blender Version** Broken: Current master (78250f1), also 2.72 (071ec91), don't have anything older than that **Short description of error** In the Add menu of the node editor is a Search button to search through all the node types - right click it and add a custom shortcut (e.g. Ctrl-A). Now hover over the button, when the tooltip should pop up, blender segfaults. It doesn't crash if a custom shortcut is not set, and I couldn't reproduce this behaviour with any other button - hovering over other custom shortcuts of mine work just fine.

Greg Zaal commented

2015-05-24 11:53:16 +02:00

Changed status to: 'Open'

Greg Zaal commented

2015-05-24 11:53:16 +02:00

Added subscriber: @GregZaal

Bastien Montagne commented

2015-05-24 18:50:24 +02:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2015-05-24 18:50:33 +02:00

Bastien Montagne commented

2015-05-24 19:20:25 +02:00

Added subscriber: @ideasman42

Bastien Montagne commented

2015-05-24 19:20:25 +02:00

Campbell, need your help here, root of the issue is that bpy enum_itemf callback (bpy_prop_enum_itemf_cb()) assumes given context is never NULL, which is wrong!

Tried placing all calls involving context in that func behind checks (passing Py_None as context in this case), seems to work, but need your advice here before I commit!

P227: #44822

diff --git a/source/blender/python/intern/bpy_props.c b/source/blender/python/intern/bpy_props.c
index 779c738..a5da6e5 100644
--- a/source/blender/python/intern/bpy_props.c
+++ b/source/blender/python/intern/bpy_props.c
@@ -1481,15 +1481,26 @@ static EnumPropertyItem *bpy_prop_enum_itemf_cb(struct bContext *C, PointerRNA *
 	EnumPropertyItem *eitems = NULL;
 	int err = 0;
 
-	bpy_context_set(C, &gilstate);
+	if (C) {
+		bpy_context_set(C, &gilstate);
+	}
+	else {
+		gilstate = PyGILState_Ensure();
+	}
 
 	args = PyTuple_New(2);
 	self = pyrna_struct_as_instance(ptr);
 	PyTuple_SET_ITEM(args, 0, self);
 
 	/* now get the context */
-	PyTuple_SET_ITEM(args, 1, (PyObject *)bpy_context_module);
-	Py_INCREF(bpy_context_module);
+	if (C) {
+		PyTuple_SET_ITEM(args, 1, (PyObject *)bpy_context_module);
+		Py_INCREF(bpy_context_module);
+	}
+	else {
+		PyTuple_SET_ITEM(args, 1, Py_None);
+		Py_INCREF(Py_None);
+	}
 
 	items = PyObject_CallObject(py_func, args);
 
@@ -1530,8 +1541,13 @@ static EnumPropertyItem *bpy_prop_enum_itemf_cb(struct bContext *C, PointerRNA *
 		eitems = DummyRNA_NULL_items;
 	}
 
+	if (C) {
+		bpy_context_clear(C, &gilstate);
+	}
+	else {
+		PyGILState_Release(gilstate);
+	}
 
-	bpy_context_clear(C, &gilstate);
 	return eitems;
 }

Campbell, need your help here, root of the issue is that bpy enum_itemf callback (`bpy_prop_enum_itemf_cb()`) assumes given context is never NULL, which is wrong! Tried placing all calls involving context in that func behind checks (passing `Py_None` as context in this case), seems to work, but need your advice here before I commit! [P227: #44822](https://archive.blender.org/developer/P227.txt) ``` diff --git a/source/blender/python/intern/bpy_props.c b/source/blender/python/intern/bpy_props.c index 779c738..a5da6e5 100644 --- a/source/blender/python/intern/bpy_props.c +++ b/source/blender/python/intern/bpy_props.c @@ -1481,15 +1481,26 @@ static EnumPropertyItem *bpy_prop_enum_itemf_cb(struct bContext *C, PointerRNA * EnumPropertyItem *eitems = NULL; int err = 0; - bpy_context_set(C, &gilstate); + if (C) { + bpy_context_set(C, &gilstate); + } + else { + gilstate = PyGILState_Ensure(); + } args = PyTuple_New(2); self = pyrna_struct_as_instance(ptr); PyTuple_SET_ITEM(args, 0, self); /* now get the context */ - PyTuple_SET_ITEM(args, 1, (PyObject *)bpy_context_module); - Py_INCREF(bpy_context_module); + if (C) { + PyTuple_SET_ITEM(args, 1, (PyObject *)bpy_context_module); + Py_INCREF(bpy_context_module); + } + else { + PyTuple_SET_ITEM(args, 1, Py_None); + Py_INCREF(Py_None); + } items = PyObject_CallObject(py_func, args); @@ -1530,8 +1541,13 @@ static EnumPropertyItem *bpy_prop_enum_itemf_cb(struct bContext *C, PointerRNA * eitems = DummyRNA_NULL_items; } + if (C) { + bpy_context_clear(C, &gilstate); + } + else { + PyGILState_Release(gilstate); + } - bpy_context_clear(C, &gilstate); return eitems; } ```

Campbell Barton commented

2015-05-25 08:47:37 +02:00

@mont29, checked the patch and think this is the only viable option.

Note that NULL context is used generating docs too.

(node poll function will need update too of course)

@mont29, checked the patch and think this is the only viable option. Note that NULL context is used generating docs too. (node poll function will need update too of course)

blender-admin commented

2015-05-25 14:24:49 +02:00

This issue was referenced by a80c1e50bc

This issue was referenced by a80c1e50bc7f57bc4d4c41bc51ac92d1d4c39030

Bastien Montagne commented

2015-05-25 14:28:53 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2015-05-25 14:28:53 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Hovering over 'Search' operator in Add Menu of Node editor when using custom shortcut causes crash #44822