Viewport compositing error without NPOT support #46105

New Issue

Joseph Eagar · 2015-09-14T06:55:55+02:00

Joseph Eagar commented

2015-09-14 06:55:55 +02:00

Screenspace AO doesn't work correctly on cards blacklisted for non-power-of-2 textures.

Screenspace AO doesn't work correctly on cards blacklisted for non-power-of-2 textures. ![screenao_npot.png](https://archive.blender.org/developer/F233183/screenao_npot.png)

Joseph Eagar commented

2015-09-14 06:55:55 +02:00

Changed status to: 'Open'

Joseph Eagar commented

2015-09-14 06:55:55 +02:00

Added subscriber: @JosephEagar

Campbell Barton commented

2015-09-14 08:05:53 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2015-09-14 08:05:53 +02:00

Confirmed. I was looking into this while checking on NPOT off-screen rendering.

Note that this isn't a regression, though it would be good to fix of course.

However being so close to release, larger changes here should go via patch review first.

Confirmed. I was looking into this while checking on NPOT off-screen rendering. Note that this isn't a regression, though it would be good to fix of course. However being so close to release, larger changes here should go via patch review first.

Campbell Barton changed title from ~~Screenspace AO Bug With Disabled NPOT~~ to Viewport compositing error without NPOT support

2015-09-14 11:09:05 +02:00

Antonis Ryakiotakis was assigned by Campbell Barton

2015-09-14 11:09:33 +02:00

Campbell Barton commented

2015-09-14 17:37:59 +02:00

@JosephEagar, are you using hardware which can do GPU compositing but has no NPOT support? Or is this just an error when testing with it forcefully disabled?

Joseph Eagar commented

2015-09-14 22:09:27 +02:00

Hardware has NPOT support, but is being blacklisted (there's a comment in gpu_extensions.c that certain API chipsets have issues, or something like that).

Antonis Ryakiotakis commented

2015-09-16 14:44:54 +02:00

It would help to have your system specs (OS, GPU model) and the system_info.txt generated from blender.

Can you try forcibly enabling npo2 support in blender and check if compositing works properly and fast?

That said, I'm quite sceptical about supporting those GPUs. While they can support compositing, since all that is needed is shader support + framebuffer object support, accounting for npo2 support can be annoying while writing more shaders and those GPUs are quite old indeed. Remember, we don't have fast way to debug code on GPU, it has to be done visually and through trial and error. Having an extra reason why code breaks due to po2 factors going wild makes things more hectic to develop for 95% of GPUs out there which do have npo2 support.

So I'm more inclined to unblacklist your GPU and disable compositing for po2 only GPUs rather than adding scaling factors to all shaders to properly account for such systems.

It would help to have your system specs (OS, GPU model) and the system_info.txt generated from blender. Can you try forcibly enabling npo2 support in blender and check if compositing works properly and fast? That said, I'm quite sceptical about supporting those GPUs. While they can support compositing, since all that is needed is shader support + framebuffer object support, accounting for npo2 support can be annoying while writing more shaders and those GPUs are quite old indeed. Remember, we don't have fast way to debug code on GPU, it has to be done visually and through trial and error. Having an extra reason why code breaks due to po2 factors going wild makes things more hectic to develop for 95% of GPUs out there which do have npo2 support. So I'm more inclined to unblacklist your GPU and disable compositing for po2 only GPUs rather than adding scaling factors to all shaders to properly account for such systems.

blender-admin commented

2015-09-16 16:04:12 +02:00

This issue was referenced by 2d16622068

This issue was referenced by 2d16622068d4662a24ab58a08f899b5228d5a81a

Antonis Ryakiotakis commented

2015-09-16 16:07:59 +02:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2015-09-16 16:07:59 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Viewport compositing error without NPOT support #46105