Particles in Particle Edit Mode get added in completely wrong location #47038

New Issue

Andy Goralczyk · 2015-12-22T12:02:44+01:00

Andy Goralczyk commented

2015-12-22 12:02:44 +01:00

When adding particles in Particle Edit mode using the Add brush, they appear in entirely different location. This used to work in 2.70, in 2.71 it broke somehow.
Sometimes this can be fixed by disabling the subsurf modifier that comes before the particle system. However, having subsurf and particles work together is vital!

oti_particle_edit_mode.blend

See attached file. This file should have a character base mesh already with a particle system, and the Add Particles tool enabled. To repeat the error, simply add particles by drawing on the mesh.

System Information
Tested using Blender Institute Linux workstation. Tracked down past working version using the windows builds from download.blender.org

Blender Version
Broken: 2.71 and after
Worked: pre 2.70

When adding particles in Particle Edit mode using the Add brush, they appear in entirely different location. This used to work in 2.70, in 2.71 it broke somehow. Sometimes this can be fixed by disabling the subsurf modifier that comes before the particle system. However, having subsurf and particles work together is vital! [oti_particle_edit_mode.blend](https://archive.blender.org/developer/F270020/oti_particle_edit_mode.blend) See attached file. This file should have a character base mesh already with a particle system, and the Add Particles tool enabled. To repeat the error, simply add particles by drawing on the mesh. **System Information** Tested using Blender Institute Linux workstation. Tracked down past working version using the windows builds from download.blender.org **Blender Version** Broken: 2.71 and after Worked: pre 2.70

Andy Goralczyk commented

2015-12-22 12:02:44 +01:00

Changed status to: 'Open'

Andy Goralczyk commented

2015-12-22 12:02:44 +01:00

Added subscriber: @eyecandy

Bastien Montagne self-assigned this 2015-12-22 13:01:59 +01:00

Dalai Felinto commented

2015-12-22 13:06:01 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2015-12-22 13:06:01 +01:00

This bug was introduced in eca6264a

This bug was introduced in eca6264a

Bastien Montagne was unassigned by Dalai Felinto

2015-12-22 13:08:46 +01:00

Antonis Ryakiotakis was assigned by Dalai Felinto

2015-12-22 13:08:46 +01:00

Dalai Felinto commented

2015-12-22 13:08:46 +01:00

Added subscriber: @mont29

Dalai Felinto commented

2015-12-22 13:08:46 +01:00

Antony, could you look at this?

Antonis Ryakiotakis commented

2015-12-22 14:01:12 +01:00

I'll try. No promises, the system there is pretty broken.

Bastien Montagne commented

2015-12-22 14:07:28 +01:00

Issue comes from the fact we are using only mesh_get_derived_deform() in brush_add()… So painting is done without subsurf modifier at all - and add_pars- [x].num_dmcache is set wint deform-only indices (which sounds pretty much useless).

I tried using mesh_get_derived_final() instead, now add_brush() produces valid mapped index values in num_dmcache, but shows nothing on screen (which makes me believe code drawing particles later on expects deform-only indices, but then, why isn’t it mapping correctly to complete DM?). Still investigating…

Issue comes from the fact we are using only `mesh_get_derived_deform()` in `brush_add()`… So painting is done without subsurf modifier at all - and `add_pars- [x].num_dmcache` is set wint deform-only indices (which sounds pretty much useless). I tried using `mesh_get_derived_final()` instead, now `add_brush()` produces valid mapped index values in `num_dmcache`, but shows nothing on screen (which makes me believe code drawing particles later on expects deform-only indices, but then, why isn’t it mapping correctly to complete DM?). Still investigating…

Bastien Montagne commented

2015-12-22 15:58:22 +01:00

@Psy-Fi if you could have a look at my patch and see whether I did not do complete crap… ;)

@eyecandy can you please check the patch (D1685) and confirm it works for you (and does not break something else :| )?

@Psy-Fi if you could have a look at my patch and see whether I did not do complete crap… ;) @eyecandy can you please check the patch ([D1685](https://archive.blender.org/developer/D1685)) and confirm it works for you (and does not break something else :| )?

Antonis Ryakiotakis was unassigned by Bastien Montagne

2015-12-23 20:02:44 +01:00

Bastien Montagne self-assigned this 2015-12-23 20:02:44 +01:00

Bastien Montagne commented

2015-12-23 20:02:44 +01:00

Added subscriber: @Psy-Fi

blender-admin commented

2016-01-04 12:19:45 +01:00

This issue was referenced by aad24468e2

This issue was referenced by aad24468e2d32d46e2c3b3b4a37302a4f1f27ab6

Bastien Montagne commented

2016-01-04 12:26:31 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-01-04 12:26:31 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Particles in Particle Edit Mode get added in completely wrong location #47038