Icon Preview generation for textures and images #48831

New Issue

Andreas Esau · 2016-07-12T09:29:32+02:00

Andreas Esau commented

2016-07-12 09:29:32 +02:00

System Information
Windows 7

Blender Version
2.77.a abf6f08

Short description of error
I am trying to use the preview functionality for textuers and images and display those icons via an enum property. I loop over all textures in bpy.data and generate an entry for the enum property. Icon for the enum property is set by the IconID I get from bpy.data.textures["tex"].preview.icon_id.
When I now generate a new texture, the icon gets also generated and displayed. The problem now starts when I when I reload the blend. The icons are not generated anymore. And I get an error in the console that the given IconID with its corresponding icon is not found. Is there a way to trigger the generation of an icon? Also Icons are not displayed by the template_icon_view.

Exact steps for others to reproduce the error
Just open the blend file. Generate some textures. Icons get generated. Save blend file and then reopen. Icons are missing.
draw_Icons.blend

**System Information** Windows 7 **Blender Version** 2.77.a abf6f08 **Short description of error** I am trying to use the preview functionality for textuers and images and display those icons via an enum property. I loop over all textures in bpy.data and generate an entry for the enum property. Icon for the enum property is set by the IconID I get from bpy.data.textures["tex"].preview.icon_id. When I now generate a new texture, the icon gets also generated and displayed. The problem now starts when I when I reload the blend. The icons are not generated anymore. And I get an error in the console that the given IconID with its corresponding icon is not found. Is there a way to trigger the generation of an icon? Also Icons are not displayed by the template_icon_view. **Exact steps for others to reproduce the error** Just open the blend file. Generate some textures. Icons get generated. Save blend file and then reopen. Icons are missing. [draw_Icons.blend](https://archive.blender.org/developer/F321886/draw_Icons.blend)

Campbell Barton was assigned by Andreas Esau

2016-07-12 09:29:32 +02:00

Andreas Esau commented

2016-07-12 09:29:32 +02:00

Changed status to: 'Open'

Andreas Esau commented

2016-07-12 09:29:32 +02:00

Added subscriber: @ndee

Andreas Esau commented

2016-07-12 09:37:17 +02:00

Small addition.

I add a new texture of type "IMAGE" and give the texture an image as data.
When painting something on the image, the icon does only update if the Texture Panel is "open" where the original texture icon in the texture_slot is displayed. Otherwise the icon has the old cashed version. It updates once the texture_slot is visible and updates the the icon.

Small addition. I add a new texture of type "IMAGE" and give the texture an image as data. When painting something on the image, the icon does only update if the Texture Panel is "open" where the original texture icon in the texture_slot is displayed. Otherwise the icon has the old cashed version. It updates once the texture_slot is visible and updates the the icon.

Andreas Esau commented

2016-07-12 11:02:32 +02:00

Here is a small gif showcasing the problem.

Here is a small gif showcasing the problem. ![blender_icons.gif](https://archive.blender.org/developer/F321896/blender_icons.gif)

Sergey Sharybin commented

2016-07-12 13:59:12 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-07-12 13:59:12 +02:00

This seems to be similar to #48813. Caused by Blender not knowing anything about dependencies between interface elements. To me it's more like a TODO than a Bug.

@mon29, @ideasman42, this is your area so leaving final decision up to you.

This seems to be similar to #48813. Caused by Blender not knowing anything about dependencies between interface elements. To me it's more like a TODO than a Bug. @mon29, @ideasman42, this is your area so leaving final decision up to you.

Sergey Sharybin commented

2016-07-12 14:08:52 +02:00

This seems to be similar to #48813. Caused by Blender not knowing anything about dependencies between interface elements. To me it's more like a TODO than a Bug.

@mon29, @ideasman42, this is your area so leaving final decision up to you.

This seems to be similar to #48813. Caused by Blender not knowing anything about dependencies between interface elements. To me it's more like a TODO than a Bug. @mon29, @ideasman42, this is your area so leaving final decision up to you.

Andreas Esau commented

2016-07-12 17:29:45 +02:00

I noticed that after reloading the blendfile blender crashes very often.
In the gif this also happens. I just open the same blendinstance in the back for the video purpose so it is not seeable.

So I would say this is sort of BUGGY and not just a feature TODO :)

I noticed that after reloading the blendfile blender crashes very often. In the gif this also happens. I just open the same blendinstance in the back for the video purpose so it is not seeable. So I would say this is sort of BUGGY and not just a feature TODO :)

Bastien Montagne commented

2016-07-12 17:53:34 +02:00

Added subscribers: @ideasman42, @mont29

Campbell Barton was unassigned by Bastien Montagne

2016-07-12 17:53:34 +02:00

Bastien Montagne self-assigned this 2016-07-12 17:53:34 +02:00

Bastien Montagne commented

2016-07-12 17:53:34 +02:00

Yes, there is the update issue, but as you said, this is considered TODO for now.

However, there are at least two other issues here:

ID.icon_id and PreviewImage.icon_id are not ensured to be the same, as it should be (and previewimage one is not correctly cleared on file read either).
Mere 'buttons from icon_id' UI code (ui_def_but_icon and its callgraph) are not able to generate/update their pictures when those are ID-auto-generated (and not loaded from filesystem).

Yes, there is the update issue, but as you said, this is considered TODO for now. However, there are at least two other issues here: 1) `ID.icon_id` and `PreviewImage.icon_id` are not ensured to be the same, as it should be (and previewimage one is not correctly cleared on file read either). 2) Mere 'buttons from icon_id' UI code (`ui_def_but_icon` and its callgraph) are not able to generate/update their pictures when those are ID-auto-generated (and not loaded from filesystem).

Bastien Montagne commented

2016-07-12 21:47:44 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-07-12 21:47:44 +02:00

Bastien Montagne commented

2016-07-12 21:47:45 +02:00

OK, Everything should be fixed now (51812fb502 & eb04908cc).

@ndee note however that you should rather use bpy.types.UILayout.icon(tex) to get an ID icon in theory… Now should not change anything though.

OK, Everything should be fixed now (51812fb502 & eb04908cc). @ndee note however that you should rather use `bpy.types.UILayout.icon(tex)` to get an ID icon in theory… Now should not change anything though.

Andreas Esau commented

2016-07-12 21:55:50 +02:00

Oh wow.. that was a quick. I will test this. Thanks alot Bastien.

so this would get me a proper icon id?

tex = bpy.data.textures["text_name"]
icon_id = bpy.types.UILayout.icon(tex)

Oh wow.. that was a quick. I will test this. Thanks alot Bastien. so this would get me a proper icon id? ``` tex = bpy.data.textures["text_name"] icon_id = bpy.types.UILayout.icon(tex) ```

Bastien Montagne was unassigned by Andreas Esau

2016-07-12 22:01:11 +02:00

Andreas Esau commented

2016-07-12 22:01:11 +02:00

Ok.. One last thing. I don't know if this is related or if I should create a custom bug report for that.

@mont29
The icon gets properly displayed for normal enum properties. But when I try to display the enum property as template_icon_view, the icons are not shown.
Is there a magic trick, or is this a bug and I should write an extra report for that?

Ok.. One last thing. I don't know if this is related or if I should create a custom bug report for that. @mont29 The icon gets properly displayed for normal enum properties. But when I try to display the enum property as template_icon_view, the icons are not shown. Is there a magic trick, or is this a bug and I should write an extra report for that?

Bastien Montagne commented

2016-07-12 22:06:44 +02:00

In #48831#381188, @ndee wrote:
so this would get me a proper icon id?
tex = bpy.data.textures["text_name"]
icon_id = bpy.types.UILayout.icon(tex)

Yes, typically… Though again, now it should not make any difference, except that going through tex.preview forces Blender to create the PreviewImage immediately - not a big deal in practice.

In #48831#381189, @ndee wrote:
The icon gets properly displayed for normal enum properties. But when I try to display the enum property as template_icon_view, the icons are not shown.

Don’t know about that, here it works perfectly now (using your demo file)…

> In #48831#381188, @ndee wrote: > so this would get me a proper icon id? > > ``` > tex = bpy.data.textures["text_name"] > icon_id = bpy.types.UILayout.icon(tex) > ``` Yes, typically… Though again, now it should not make any difference, except that going through tex.preview forces Blender to create the PreviewImage immediately - not a big deal in practice. > In #48831#381189, @ndee wrote: > The icon gets properly displayed for normal enum properties. But when I try to display the enum property as template_icon_view, the icons are not shown. Don’t know about that, here it works perfectly now (using your demo file)…

Andreas Esau commented

2016-07-13 07:10:39 +02:00

@mont29
ok. Just tried out the latest blender build and icon_view works fine now! Awesome that this issues are resolved!

@mont29 ok. Just tried out the latest blender build and icon_view works fine now! Awesome that this issues are resolved!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Icon Preview generation for textures and images #48831