Segfault when switching brushes while renaming another brush #49023
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#49023
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Windows 64-bit, msvc2013
Blender Version
Broken:
357480f8c3
Short description of error
At this point, it sometimes crashes, and sometimes doesn't.
Changed status to: 'Open'
Added subscriber: @JoshuaLeung
@antoniov: Could you take a look to figure out what's going on here? It might be something subtle going wrong with the RNA set functions for the brush names.
I cannot reproduce (I'm running Windows 10 64bits) the error.
@JoshuaLeung The RNA code is very simple in RNA_scene.c, so I don't think this is the problem.
@JoshuaLeung After a lot of test, I got this:
backtrace
33: BLI_system_backtrace - 0xCF94EC0
32: sig_handle_crash_backtrace - 0xBC5FCB0
31: sig_handle_crash - 0xBC5FD00
30: windows_exception_handler - 0xBC5FF80
29: UnhandledExceptionFilter - 0x6AFF7C70
28: memset - 0x6E51B900
27: _C_specific_handler - 0x6E505A90
26: _chkstk - 0x6E519A00
25: RtlImageNtHeaderEx - 0x6E4A4B30
24: KiUserExceptionDispatcher - 0x6E518BD0
23: strcmp - 0x10365B00
22: uniquename_find_dupe - 0xCF9CFC0
21: uniquename_unique_check - 0xCF9D060
20: BLI_uniquename_cb - 0xCF9ACD0
19: BLI_uniquename - 0xCF9ABD0
18: rna_GPencilBrush_name_set - 0xCCB56D0
17: GPencilBrush_name_set - 0xCCC3950
16: RNA_property_string_set - 0xCC65060
15: ui_but_string_set - 0xBF93420
14: ui_apply_but_TEX - 0xBFB8840
13: ui_apply_but - 0xBFBAF90
12: button_activate_exit - 0xBFB68F0
11: ui_handle_button_event - 0xBFCEC70
10: ui_handler_region_menu - 0xBFB6DF0
9: wm_handler_ui_call - 0xBC7AC80
8: wm_handlers_do_intern - 0xBC7DAF0
7: wm_handlers_do - 0xBC7E170
6: wm_event_do_handlers - 0xBC787C0
5: WM_main - 0xBC609E0
4: main - 0xBC59580
3: __tmainCRTStartup - 0x1036B900
2: mainCRTStartup - 0x1036BB20
1: BaseThreadInitThunk - 0x6D6480E0
0: RtlUserThreadStart - 0x6E4CC580
You can see the problem is in unique name function
The RNA set of brushes name is equal to layers name, so I don't see why we get this error.
Added subscriber: @mont29
I can easily reproduce on linux with debug build + asan, will investigate (simpler to check when you can reproduce 100% of time ;) ).
This issue was referenced by
df7be61438
Changed status from 'Open' to: 'Resolved'
@mont29 I'm new to RNA code, so I'm not sure, but there are more lines in the same file using the same code that you fixed (51, 516, 524, 534, ...).
Is it necessary to replace all of them?
I previous message I mean, similar code not equal. It is not clear for me the use of ptr->data yet :-)
@antoniov I did quick check while fixing, and no, those do not need same change.
Reason is,
rna_GPencil_active_brush_xxx
andrna_GPencilBrush_index_xxx
are callbacks of properties of an RNA struct definingRNA_def_struct_sdna(srna, "ToolSettings");
, which means they'll get aToolSettings
asptr->data
.On the other hand,
rna_GPencilBrush_name_set
is callback of a property of an RNA struct definingRNA_def_struct_sdna(srna, "bGPDbrush");
, so it’ll get abGPDbrush
asptr->data
.In later case, you can luckily find 'parent' struct pointer from ID owner (Scene here), which is stored in
ptr->id.data
.Note that the code was pretty obviously broken though, same pointer being assigned as both toolsettings and gpdbrush… ;)
PS: just realized names of ``rna_GPencil_active_brush_xxx
and
rna_GPencilBrush_index_xxx` are 'wrong' (misleading), will fix that.Thnks for the explanation. After reading your comments I see the error was obvious.
Also, noted a
[+ reason/effect of using higher values of this property]
in tooltip of pen_smooth_steps, this looks like TODO note more than understandable tip to me? ;)