Cycles Standalone missing generated coordinates #49904

New Issue

David · 2016-11-01T18:38:27+01:00

David commented

2016-11-01 18:38:27 +01:00

Something is broken with the nodes.

This is the example "scene_monkey.xml"
*The monkey should be Glass
*The ground should be checkerboard
http://imagizer.imageshack.com/img923/2464/reKxvE.png

*no changes from master on Win10 VS2013
*compiled and tested cycles standalone in both "rB Blender" and "rC Cycles"

I tested my compiled blender.exe, and the glass and checkerboard nodes work in blender, but something is not working in the standalone.

What it should look like:
http://www.blendernation.com/wp-content/uploads/2014/01/standalone.png

Something is broken with the nodes. This is the example "scene_monkey.xml" *The monkey should be Glass *The ground should be checkerboard http://imagizer.imageshack.com/img923/2464/reKxvE.png *no changes from master on Win10 VS2013 *compiled and tested cycles standalone in both "rB Blender" and "rC Cycles" I tested my compiled blender.exe, and the glass and checkerboard nodes work in blender, but something is not working in the standalone. What it should look like: http://www.blendernation.com/wp-content/uploads/2014/01/standalone.png

David commented

2016-11-01 18:38:27 +01:00

Changed status to: 'Open'

David commented

2016-11-01 18:38:27 +01:00

Added subscriber: @bocs

Martijn Berger commented

2016-11-02 10:53:40 +01:00

Added subscriber: @MartijnBerger

Martijn Berger commented

2016-11-02 10:53:40 +01:00

Seems cycles is not adding generated UV coordinates to the checker texture.

David commented

2016-11-02 23:34:14 +01:00

This comment was removed by @bocs

*This comment was removed by @bocs*

David commented

2016-11-02 23:47:53 +01:00

Found the commit where it broke standalone:
https://developer.blender.org/rBc96ae81160ad1a943fafaca44a7d5e97c2d7a0d7

Before and After:
http://imagizer.imageshack.com/img922/2615/3nec0A.png

Found the commit where it broke standalone: https://developer.blender.org/rBc96ae81160ad1a943fafaca44a7d5e97c2d7a0d7 Before and After: http://imagizer.imageshack.com/img922/2615/3nec0A.png

Bastien Montagne commented

2016-11-04 09:59:52 +01:00

Added subscribers: @MaiLavelle, @mont29

Mai Lavelle was assigned by Bastien Montagne

2016-11-04 09:59:52 +01:00

Bastien Montagne commented

2016-11-04 09:59:52 +01:00

@MaiLavelle, this seems to be for your desk? :)

David commented

2016-11-06 10:35:58 +01:00

I hope this helps make a proper patch...
I noticed during debugging that it's missing the ATTR_STD_GENERATED attribute.

which led me to this...

This code was removed from intern/cycles/render/mesh.cpp

			/* todo: get rid of this exception, it's only here for giving some
			* working texture coordinate for subdivision as we can't preserve
			* any attributes yet */
			if (!triangle_mattr && req.std == ATTR_STD_GENERATED) {
				triangle_mattr = mesh->attributes.add(ATTR_STD_GENERATED);
				if (mesh->verts.size())
					memcpy(triangle_mattr->data_float3(), &mesh->verts[0], sizeof(float3)*mesh->verts.size());
			}

without code:
http://imagizer.imageshack.com/img924/6018/lz7Tjh.png

With code:
http://imagizer.imageshack.com/img924/4740/L1C8uH.png

Off Topic:
I'm trying to intergrate Cycles into Unity, this is from a few months ago
https://youtu.be/wNtFdrKwkfM?t=1m15s

I hope this helps make a proper patch... I noticed during debugging that it's missing the ATTR_STD_GENERATED attribute. which led me to this... This code was removed from intern/cycles/render/mesh.cpp ``` /* todo: get rid of this exception, it's only here for giving some * working texture coordinate for subdivision as we can't preserve * any attributes yet */ if (!triangle_mattr && req.std == ATTR_STD_GENERATED) { triangle_mattr = mesh->attributes.add(ATTR_STD_GENERATED); if (mesh->verts.size()) memcpy(triangle_mattr->data_float3(), &mesh->verts[0], sizeof(float3)*mesh->verts.size()); } ``` without code: http://imagizer.imageshack.com/img924/6018/lz7Tjh.png With code: http://imagizer.imageshack.com/img924/4740/L1C8uH.png Off Topic: I'm trying to intergrate Cycles into Unity, this is from a few months ago https://youtu.be/wNtFdrKwkfM?t=1m15s

Mai Lavelle commented

2016-11-11 14:28:00 +01:00

As far as I know Cycles standalone never provided generated coordinates, so its a bit odd to say that that commit caused this. Check that you're using updated repos/files.

Not sure what the correct solution is here, as generated coordinates come from Blender, I guess we can mimic the behavior?

As far as I know Cycles standalone never provided generated coordinates, so its a bit odd to say that that commit caused this. Check that you're using updated repos/files. Not sure what the correct solution is here, as generated coordinates come from Blender, I guess we can mimic the behavior?

Mai Lavelle changed title from ~~Cycles Standalone Broken~~ to Cycles Standalone missing generated coordinates

2016-11-11 14:28:31 +01:00

Martijn Berger commented

2016-11-12 08:57:27 +01:00

well the xml does render correctly in older versions of cycles standalone. I.E. with generated coordinated. and there are no coordinates in that file.

Brecht Van Lommel commented

2016-11-12 17:01:13 +01:00

Added subscriber: @brecht

Mai Lavelle was unassigned by Brecht Van Lommel

2016-11-12 17:01:13 +01:00

Brecht Van Lommel self-assigned this 2016-11-12 17:01:13 +01:00

Brecht Van Lommel commented

2016-11-12 17:01:13 +01:00

We don't yet support arbitrary mesh attributes in the XML file reading, and ideally generated coordinates should be passed that way. But none are available we can still use the vertex coordinates as a fallback, I'll restore that code.

blender-admin commented

2016-11-12 17:21:21 +01:00

This issue was referenced by blender/cycles@9da3452f3a

This issue was referenced by blender/cycles@9da3452f3a6126ddba2ed2655ea285df29db54a9

blender-admin commented

2016-11-12 17:21:21 +01:00

This issue was referenced by 111e2f5aba

This issue was referenced by 111e2f5abacc0d93b83de66d1cde8f37e60f1395

Brecht Van Lommel commented

2016-11-12 17:33:59 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2016-11-12 17:33:59 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles Standalone missing generated coordinates #49904