Missing parenthesis on fluid bake button #50775

New Issue

supersudo · 2017-02-24T17:23:56+01:00

supersudo commented

2017-02-24 17:23:56 +01:00

Blender Version
Version 2.78b, on Windows 7.

Short description of error
Missing parenthesis on fluid bake button after "Req. memory: ...".

Exact steps for others to reproduce the error
blender.blend
Just add a fluid domain to object in Physics tab.

**Blender Version** Version 2.78b, on Windows 7. **Short description of error** Missing parenthesis on fluid bake button after "Req. memory: ...". ![blender.PNG](https://archive.blender.org/developer/F495760/blender.PNG) **Exact steps for others to reproduce the error** [blender.blend](https://archive.blender.org/developer/F495762/blender.blend) Just add a fluid domain to object in Physics tab.

supersudo commented

2017-02-24 17:23:56 +01:00

Changed status to: 'Open'

supersudo commented

2017-02-24 17:23:56 +01:00

Added subscriber: @supersudo

Aaron Carlisle self-assigned this 2017-02-24 19:55:43 +01:00

Lukas Stockner commented

2017-02-24 20:54:21 +01:00

Added subscribers: @Sergey, @LukasStockner

Lukas Stockner commented

2017-02-24 20:54:21 +01:00

This is caused by 87cb3f8519: Since the length function always returns 31, fluid.memory_estimate has trailing zero bytes to bring it to length 31. These zeroes are preserved in the formatting step in properties_physics_fluid.py and therefore end up between the "MB" and the closing parenthesis, which then causes the C interface code to ignore everything after the "MB".

Afaics, there are 4 ways to fix this:

Manually remove the trailing \0's in Python. Works, but it's quite hacky.
Return the correct length from rna_DomainFluidSettings_memory_estimate_length. However, as the commit message of 87cb3f8519 points out, that'd be slower.
Make RNA return the correct length when getting a string - since we already have the string in that case, doing a strlen would be pretty cheap. However, that might break other code.
Same as above, but add a flag for that behavior instead of always using it.

@Sergey, any preferences here?

This is caused by 87cb3f8519: Since the length function always returns 31, `fluid.memory_estimate` has trailing zero bytes to bring it to length 31. These zeroes are preserved in the formatting step in properties_physics_fluid.py and therefore end up between the "MB" and the closing parenthesis, which then causes the C interface code to ignore everything after the "MB". Afaics, there are 4 ways to fix this: - Manually remove the trailing `\0`'s in Python. Works, but it's quite hacky. - Return the correct length from `rna_DomainFluidSettings_memory_estimate_length`. However, as the commit message of 87cb3f8519 points out, that'd be slower. - Make RNA return the correct length when getting a string - since we already have the string in that case, doing a `strlen` would be pretty cheap. However, that might break other code. - Same as above, but add a flag for that behavior instead of always using it. @Sergey, any preferences here?

Aaron Carlisle removed their assignment 2017-02-24 21:02:43 +01:00

Aaron Carlisle commented

2017-02-24 21:02:43 +01:00

Added subscriber: @Blendify

blender-admin commented

2017-05-30 09:46:53 +02:00

This issue was referenced by 76c97aaff9

This issue was referenced by 76c97aaff94c199573463256a2ed7ff8d3d56dde

Bastien Montagne commented

2017-05-30 09:49:56 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2017-05-30 09:49:56 +02:00

Bastien Montagne commented

2017-05-30 09:52:34 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2017-05-30 09:52:34 +02:00

Just returned correct length… Note that such thing shall be a mere floating number (or integer of bytes), really no good reason to return a string here, python can do formatting and would be much simpler on C side of code. But that’s for another day.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Missing parenthesis on fluid bake button #50775