Delete Globally won't work with Datablock ID Properties #51243

New Issue

Mikhail Rachinskiy · 2017-04-18T08:12:13+02:00

2017-04-18 08:12:13 +02:00

System Information
Windows 10 x64
Renderer: GeForce GTX 860M/PCIe/SSE2

Blender Version
Broken: 2.78.4 4d0d1b5

Short description of error
Delete Globally does not take into account Datablock ID Properties, i. e. object referenced in add-on prop will be deleted from the scene, but not from the blend file.

Exact steps for others to reproduce the error

Open provided blend file: delete_global.blend
Use Run Script from the Text Editor.
Locate Test Panel tab in 3D View > Tool Shelf.
Pick a Cube object using eyedropper.

Delete Cube using Shift X for Delete Globally.

Now notice how Orphan Data in Outline doesn't show anything as it should, which means that Cube object is still has one user and will not be removed on save/open action. So user have to unreference it from every single add-on property manually.
To see how it should work do the following:

Open provided blend file.
Create new scene choosing Link Objects option (now we have two users on a Cube object).

Delete Cube using Shift X for Delete Globally.

Now notice how Orphan Data shows Cube mesh with zero users, which means that Cube object is deleted from everywhere.

**System Information** Windows 10 x64 Renderer: GeForce GTX 860M/PCIe/SSE2 **Blender Version** Broken: 2.78.4 4d0d1b5 **Short description of error** Delete Globally does not take into account Datablock ID Properties, i. e. object referenced in add-on prop will be deleted from the scene, but not from the blend file. **Exact steps for others to reproduce the error** - Open provided blend file: [delete_global.blend](https://archive.blender.org/developer/F548706/delete_global.blend) - Use Run Script from the Text Editor. - Locate Test Panel tab in 3D View > Tool Shelf. - Pick a Cube object using eyedropper. # Delete Cube using Shift X for Delete Globally. Now notice how Orphan Data in Outline doesn't show anything as it should, which means that Cube object is still has one user and will not be removed on save/open action. So user have to unreference it from every single add-on property manually. To see how it should work do the following: - Open provided blend file. - Create new scene choosing Link Objects option (now we have two users on a Cube object). # Delete Cube using Shift X for Delete Globally. Now notice how Orphan Data shows Cube mesh with zero users, which means that Cube object is deleted from everywhere.

Mikhail Rachinskiy commented

2017-04-18 08:12:13 +02:00

Changed status to: 'Open'

Mikhail Rachinskiy commented

2017-04-18 08:12:13 +02:00

Added subscriber: @MikhailRachinskiy

Alexander Romanov was assigned by Aaron Carlisle

2017-04-18 15:37:04 +02:00

Alexander Romanov commented

2017-04-18 17:55:21 +02:00

Added subscriber: @mont29

Alexander Romanov commented

2017-04-18 17:55:21 +02:00

@mont29, If I understand correctly, "X" do removing for the current scene and "Shift+X" - for all scenes? So in case of single scene "X" should also work? If this operator has "scene" context, I suppose that lookup in scene idproperties should be sufficient?

Alexander Romanov was unassigned by Bastien Montagne

2017-04-19 17:58:49 +02:00

Bastien Montagne self-assigned this 2017-04-19 17:58:49 +02:00

Bastien Montagne commented

2017-04-19 17:58:49 +02:00

Added subscriber: @AlexanderRomanov

Bastien Montagne commented

2017-04-19 17:58:49 +02:00

OK, so… This is muddy waters, spent some time thinking about this and for now would consider this 'not a bug', as in, code is behaving as expected and consistently (since Object is user of itself, it is not a detectable orphaned currently, it’s an 'orphaned archipelago', a loop of orphanage, and we are not really ready to detect and handle those in current code).

To be more detailed, Object handling is currently in a big TODO stage - first because it used a lot of custom code that could be replaced by new generic one, but that kind of cleanup takes a lot of time to do and check! Furthermore, Object handling is also being changed to some extent in new blender2.8, so would rather not start messing with it in master at this point.

I think I'll just add a 'hack' around the issue for this specific case only: when you enable 'global' option for this operator, and object is local, just use 'full-nuke' delete ID code instead - simpler, shorter and should do the work.

OK, so… This is muddy waters, spent some time thinking about this and for now would consider this 'not a bug', as in, code is behaving as expected and consistently (since Object is user of itself, it is not a detectable orphaned currently, it’s an 'orphaned archipelago', a loop of orphanage, and we are not really ready to detect and handle those in current code). To be more detailed, Object handling is currently in a big TODO stage - first because it used a lot of custom code that could be replaced by new generic one, but that kind of cleanup takes a lot of time to do *and check*! Furthermore, Object handling is also being changed to some extent in new blender2.8, so would rather not start messing with it in master at this point. I think I'll just add a 'hack' around the issue for this specific case only: when you enable 'global' option for this operator, and object is local, just use 'full-nuke' delete ID code instead - simpler, shorter and should do the work.

blender-admin commented

2017-04-19 22:07:57 +02:00

This issue was referenced by 1873ea337c

This issue was referenced by 1873ea337c24e7a169c306a7467ce899a53eb0f8

Bastien Montagne commented

2017-04-19 22:10:46 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2017-04-19 22:10:46 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Delete Globally won't work with Datablock ID Properties #51243

Delete Cube using Shift X for Delete Globally.

Delete Cube using Shift X for Delete Globally.