Colorspace in the video sequencer is empty #51898

New Issue

Tal Hershkovich · 2017-06-26T11:59:05+02:00

Tal Hershkovich commented

2017-06-26 11:59:05 +02:00

System Information
Operating system and graphics card
Debian "jessie", Geforce 580

Blender Version
Broken: 2.79 and 2.78c

Short description of error
When loading an older file for editing , the colorspace of all the strips in the video sequencer are gone (marked in red)
Probably related to the addition of filmic.
I think it was also causing problems with rendering

Exact steps for others to reproduce the error
open an old editing file and check the colorspace of each strip in the video sequencer.
I can upload my file but it's 180MB compressed (packed with all the images inside).

to solve the probelm I wrote in the script editor:

  for seq in bpy.data.scenes['Video_editing'].sequence_editor.sequences_all:
      if seq.type == 'IMAGE':
          seq.colorspace_settings.name = 'sRGB'

**System Information** Operating system and graphics card Debian "jessie", Geforce 580 **Blender Version** Broken: 2.79 and 2.78c **Short description of error** When loading an older file for editing , the colorspace of all the strips in the video sequencer are gone (marked in red) ![Blender_colorspace_bug.jpg](https://archive.blender.org/developer/F643146/Blender_colorspace_bug.jpg) Probably related to the addition of filmic. I think it was also causing problems with rendering **Exact steps for others to reproduce the error** open an old editing file and check the colorspace of each strip in the video sequencer. I can upload my file but it's 180MB compressed (packed with all the images inside). to solve the probelm I wrote in the script editor: ``` for seq in bpy.data.scenes['Video_editing'].sequence_editor.sequences_all: if seq.type == 'IMAGE': seq.colorspace_settings.name = 'sRGB'

Tal Hershkovich commented

2017-06-26 11:59:05 +02:00

Changed status to: 'Open'

Tal Hershkovich commented

2017-06-26 11:59:05 +02:00

Added subscriber: @TalHershkovich

Dalai Felinto commented

2017-06-27 11:25:29 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2017-06-27 11:25:29 +02:00

Please unpack the file, and send only the .blend. It should be small enough.

Brecht Van Lommel commented

2017-07-01 21:20:18 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2017-07-01 21:20:18 +02:00

If you used the external Filmic OpenColorIO configuration to create the original .blend, then a blank color space is the intended behavior. Unfortunately that configuration has color space names that are incompatible with the builtin Blender one, and a blank menu means "color space not found". In general you need to use the same OpenColorIO configuration that you created the .blend with.

Files created with the builtin Blender configuration (that includes the Filmic view transforms in 2.79) will not have this problem, so I don't think there's a Blender bug here. What could be improved is guessing of an appropriate replacement when the color space is not found.

If you used the external Filmic OpenColorIO configuration to create the original .blend, then a blank color space is the intended behavior. Unfortunately that configuration has color space names that are incompatible with the builtin Blender one, and a blank menu means "color space not found". In general you need to use the same OpenColorIO configuration that you created the .blend with. Files created with the builtin Blender configuration (that includes the Filmic view transforms in 2.79) will not have this problem, so I don't think there's a Blender bug here. What could be improved is guessing of an appropriate replacement when the color space is not found.

Brecht Van Lommel commented

2017-07-03 05:20:01 +02:00

Added subscriber: @Sergey

Brecht Van Lommel commented

2017-07-03 05:20:02 +02:00

It's possible to do something like this to fall back to a better default, however it only happens when the image file is actually loaded and permanently modifies the color space without any warning. I guess the ideal would be to check the validity of color spaces on .blend file load and then ask the user what to do, but that gets quite complicated.

diff --cc source/blender/imbuf/intern/colormanagement.c
index ff19a14,ff19a14..41232a6
--- a/source/blender/imbuf/intern/colormanagement.c
+++ b/source/blender/imbuf/intern/colormanagement.c
@@@ -966,7 -966,7 +966,9 @@@ static void curve_mapping_apply_pixel(C

  void colorspace_set_default_role(char *colorspace, int size, int role)
  {
--      if (colorspace && colorspace[0] == '\0') {
++      /* set default role if color space not specified, or not found due to
++       * using a different OpenColorIOR configuration */
++      if (colorspace && (colorspace[0] == '\0' || !colormanage_colorspace_get_named(colorspace))) {
                const char *role_colorspace;

                role_colorspace = IMB_colormanagement_role_colorspace_name_get(role);

Maybe @Sergey has an opinion on this, I'm tempted not to change anything here.

It's possible to do something like this to fall back to a better default, however it only happens when the image file is actually loaded and permanently modifies the color space without any warning. I guess the ideal would be to check the validity of color spaces on .blend file load and then ask the user what to do, but that gets quite complicated. ``` diff --cc source/blender/imbuf/intern/colormanagement.c index ff19a14,ff19a14..41232a6 --- a/source/blender/imbuf/intern/colormanagement.c +++ b/source/blender/imbuf/intern/colormanagement.c @@@ -966,7 -966,7 +966,9 @@@ static void curve_mapping_apply_pixel(C void colorspace_set_default_role(char *colorspace, int size, int role) { -- if (colorspace && colorspace[0] == '\0') { ++ /* set default role if color space not specified, or not found due to ++ * using a different OpenColorIOR configuration */ ++ if (colorspace && (colorspace[0] == '\0' || !colormanage_colorspace_get_named(colorspace))) { const char *role_colorspace; role_colorspace = IMB_colormanagement_role_colorspace_name_get(role); ``` Maybe @Sergey has an opinion on this, I'm tempted not to change anything here.

blender-admin commented

2017-07-10 01:03:20 +02:00

This issue was referenced by 00f3ab2fb2

This issue was referenced by 00f3ab2fb2df9047b34943728621d12746b5d363

Brecht Van Lommel commented

2017-07-10 01:22:13 +02:00

Actually we already have code for validating color space, we just didn't use that for sequencer strips yet. Fixed now.

Brecht Van Lommel commented

2017-07-10 01:22:23 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2017-07-10 01:22:23 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Colorspace in the video sequencer is empty #51898