Crash after adjusting lenght of hair particles #52439

New Issue

Jakub Vaja · 2017-08-18T12:12:49+02:00

Jakub Vaja commented

2017-08-18 12:12:49 +02:00

System Information
Win 10 64bit, GTX 760 driver - 378.49

Blender Version
Broken: (example: 2.79 66c1b23,)
Worked: (2.78 public release)

Short description of error
Crash after adjusting length of hair particles

Exact steps for others to reproduce the error
1.create a polygonal object
2.create particle system type of hair
3.check advanced particles
4.switch emit mode to verts
5. try to change hair length and blender crash

**System Information** Win 10 64bit, GTX 760 driver - 378.49 **Blender Version** Broken: (example: 2.79 66c1b23,) Worked: (2.78 public release) **Short description of error** Crash after adjusting length of hair particles **Exact steps for others to reproduce the error** 1.create a polygonal object 2.create particle system type of hair 3.check advanced particles 4.switch emit mode to verts 5. try to change hair length and blender crash

Jakub Vaja commented

2017-08-18 12:12:49 +02:00

Changed status to: 'Open'

Jakub Vaja commented

2017-08-18 12:12:49 +02:00

Added subscriber: @Conflig

blender-admin commented

2017-08-18 12:12:49 +02:00

#52686 was marked as duplicate of this issue

blender-admin commented

2017-08-18 12:12:49 +02:00

#52674 was marked as duplicate of this issue

blender-admin commented

2017-08-18 12:12:49 +02:00

#52577 was marked as duplicate of this issue

blender-admin commented

2017-08-18 12:12:49 +02:00

#52456 was marked as duplicate of this issue

Fable Fox commented

2017-08-18 20:53:04 +02:00

Added subscriber: @fablefox

Fable Fox commented

2017-08-18 20:53:04 +02:00

Can you provide a simple blender file to reproduce the problem?

Jakub Vaja commented

2017-08-19 00:46:30 +02:00

crash_hair_particles.blend Just click on the length parameter box. It actually crashed once as I hit the verts emit mode

[crash_hair_particles.blend](https://archive.blender.org/developer/F717848/crash_hair_particles.blend) Just click on the length parameter box. It actually crashed once as I hit the verts emit mode

Fable Fox commented

2017-08-19 03:29:45 +02:00

Confirmed with 2.7c rc1.

Error: EXCEPTION_ACCESS_VIOLATION

Confirmed with 2.7c rc1. ``` Error: EXCEPTION_ACCESS_VIOLATION ```

Fable Fox commented

2017-08-19 11:57:26 +02:00

also happens with 2.79 RC2

Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

void CustomData_update_typemap(CustomData *data)
{
	int i, lasttype = -1;

	for (i = 0; i < CD_NUMTYPES; i++) {
		data->typemap[i] = -1;
	}

	for (i = 0; i < data->totlayer; i++) {
		const int type = data->layers[i].type;
		if (type != lasttype) {
			data->typemap[type] = i;  <--- next statement to be executed
			lasttype = type;
		}
	}
}




Unhandled exception at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

Unhandled exception at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

Unhandled exception at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C.

also happens with 2.79 RC2 ``` Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. void CustomData_update_typemap(CustomData *data) { int i, lasttype = -1; for (i = 0; i < CD_NUMTYPES; i++) { data->typemap[i] = -1; } for (i = 0; i < data->totlayer; i++) { const int type = data->layers[i].type; if (type != lasttype) { data->typemap[type] = i; <--- next statement to be executed lasttype = type; } } } Unhandled exception at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. Unhandled exception at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. Unhandled exception at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. Exception thrown at 0x0000000140FD1B6F in blender.exe: 0xC0000005: Access violation writing location 0xFFFFFFFF855E6B2C. ```

Ray molenkamp commented

2017-08-19 23:42:33 +02:00

Added subscribers: @LucaRood-3, @mont29, @LazyDodo

Ray molenkamp commented

2017-08-19 23:42:33 +02:00

it's a threading issue introduced in fed853ea78

in distribute_from_verts_exec there's a call to

DM_ensure_tessface(ctx->dm);
mface = ctx->dm->getTessFaceDataArray(ctx->dm, CD_MFACE);

which isn't thread safe to execute, I guarded this bit of code with a spinlock and the problem went away, but that's somewhat of a crude fix.

@LucaRood-3 / @mont29 can either of you guys take a peek here?

it's a threading issue introduced in fed853ea78 in distribute_from_verts_exec there's a call to ``` DM_ensure_tessface(ctx->dm); mface = ctx->dm->getTessFaceDataArray(ctx->dm, CD_MFACE); ``` which isn't thread safe to execute, I guarded this bit of code with a spinlock and the problem went away, but that's somewhat of a crude fix. @LucaRood-3 / @mont29 can either of you guys take a peek here?

Bastien Montagne commented

2017-08-20 17:16:30 +02:00

Added subscribers: @ostapblender, @zeauro, @brecht, @Sergey