group objects and their counts become mismatched in particle system "use count" list #54257

New Issue

tom k · 2018-03-07T15:22:38+01:00

tom k commented

2018-03-07 15:22:38 +01:00

System Information
Linux Mint 18 Cinnamon 64-bit
system-info.txt

Blender Version
Broken: official release 2.79a, latest build 2.79.3 76122bc8f0
Earliest release with bug was 2.78a; 2.78 had a different bug (all counts become 1).

Short description of error
Sometimes particle system's render->group->use count (dupliweight) list will rearrange (alphabetise) object names but not the counts, so they become mismatched.

The bug occurs on changing values in the redo panel, or on loading a saved file.

Exact steps for others to reproduce the error
FROM DEFAULT SCENE:

Add a monkey ("Suzanne")
Add it to a group "test"
Select default cube, add a particle system.
Under particle system->render panel: set render type to group; select "test" for dupli group; enable use count; and set the count for Suzanne to 25.
Add an ico sphere ("Icosphere")
Under object properties->groups panel, add it to the group "test".

Now, EITHER: add another object, and change some value for it in the T-Panel (redo panel); OR save and reload the file (the list will show "no object" at first - mouse over it or something to update it).

EXAMPLE FILE (produced by following steps 1-6 then saving)
groupCountBugExample.blend

Expected Results:
Ideally nothing should change, but if it must, the count list (Suzanne: 25, Icosphere: 1) should become (Icosphere: 1, Suzanne: 25).

What happens instead:
The list becomes (Icosphere: 25, Suzanne: 1).

**System Information** Linux Mint 18 Cinnamon 64-bit [system-info.txt](https://archive.blender.org/developer/F2429961/system-info.txt) **Blender Version** Broken: official release 2.79a, latest build 2.79.3 76122bc8f00 Earliest release with bug was 2.78a; 2.78 had a different bug (all counts become 1). **Short description of error** Sometimes particle system's render->group->use count (dupliweight) list will rearrange (alphabetise) object names but not the counts, so they become mismatched. The bug occurs on changing values in the redo panel, or on loading a saved file. **Exact steps for others to reproduce the error** FROM DEFAULT SCENE: - Add a monkey ("Suzanne") - Add it to a group "test" - Select default cube, add a particle system. - Under particle system->render panel: set render type to group; select "test" for dupli group; enable use count; and set the count for Suzanne to 25. - Add an ico sphere ("Icosphere") - Under object properties->groups panel, add it to the group "test". # Now, EITHER: add another object, and change some value for it in the T-Panel (redo panel); OR save and reload the file (the list will show "no object" at first - mouse over it or something to update it). EXAMPLE FILE (produced by following steps 1-6 then saving) [groupCountBugExample.blend](https://archive.blender.org/developer/F2429960/groupCountBugExample.blend) Expected Results: Ideally nothing should change, but if it must, the count list (Suzanne: 25, Icosphere: 1) should become (Icosphere: 1, Suzanne: 25). What happens instead: The list becomes (Icosphere: 25, Suzanne: 1).

tom k commented

2018-03-07 15:22:38 +01:00

Added subscriber: @tomjk

Philipp Oeser commented

2018-04-10 13:27:33 +02:00

Added subscribers: @mont29, @lichtwerk

Philipp Oeser self-assigned this 2018-04-10 13:27:33 +02:00

Philipp Oeser commented

2018-04-10 13:27:33 +02:00

Can confirm this, looking a little further now, but if that gets a timesink, I might need @mont29 to have a look here

Philipp Oeser commented

2018-04-10 13:42:10 +02:00

possibly related #53628 (but that needs reconfirmation once a solution is found here)

Philipp Oeser removed their assignment 2018-04-10 14:38:51 +02:00

Bastien Montagne was assigned by Philipp Oeser

2018-04-10 14:38:51 +02:00

Philipp Oeser commented

2018-04-10 14:38:51 +02:00

OK, actually group indices seem to update/change on save then reload...
Hm, apparently that has always been the case [checked back to 2.74]

can easily be verified in python, too:

add cube, STRG+G
check bpy.data.groups['Group'].objects- [x] [should result in 'Cube']
add suzanne, add to 'Group'
check bpy.data.groups['Group'].objects- [x] [should still result in 'Cube']
save file
check bpy.data.groups['Group'].objects- [x] [should still result in 'Cube']
reload file
check bpy.data.groups['Group'].objects- [x] [should now result in 'Suzanne']

If that is the case, then relying on storing the group index in ParticleDupliWeight.index and restoring the objects from that said index is not a good idea, I guess?

stored in write_particlesettings
not restored in lib_link_particlesettings
but in psys_check_group_weights

Hm, what to do? do this namebased instead? Can we change/force above said change of indices before writing the file (so we dont run into the mismatch later?)
Of course I could be missing something, happy to try something more, but kindly asking @mont29 for advice before I sink more time here... [just assign back to me and I will try more]

OK, actually group indices seem to update/change on save then reload... Hm, apparently that has always been the case [checked back to 2.74] can easily be verified in python, too: - add cube, STRG+G - check `bpy.data.groups['Group'].objects- [x]` [should result in 'Cube'] - add suzanne, add to 'Group' - check `bpy.data.groups['Group'].objects- [x]` [should still result in 'Cube'] - save file - check `bpy.data.groups['Group'].objects- [x]` [should still result in 'Cube'] - reload file - check `bpy.data.groups['Group'].objects- [x]` [should now result in 'Suzanne'] If that is the case, then relying on storing the group index in `ParticleDupliWeight.index` and restoring the objects from that said index is not a good idea, I guess? stored in [write_particlesettings ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/writefile.c;5c3857b3051ff9f40e606ae2fc59f68a1747f1d7$1312) not restored in [lib_link_particlesettings ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/readfile.c;5c3857b3051ff9f40e606ae2fc59f68a1747f1d7$4174) but in [psys_check_group_weights ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/particle.c;5c3857b3051ff9f40e606ae2fc59f68a1747f1d7$330) Hm, what to do? do this namebased instead? Can we change/force above said change of indices before writing the file (so we dont run into the mismatch later?) Of course I could be missing something, happy to try something more, but kindly asking @mont29 for advice before I sink more time here... [just assign back to me and I will try more]

Bastien Montagne commented

2018-04-12 15:31:44 +02:00

Added subscriber: @Sergey

Bastien Montagne commented

2018-04-12 15:31:44 +02:00

Hey,
so group objects are not reordered on read file, but according to Dr @Sergey bloody depsgraph can reorder them at some point. This is sort of can of worms, and probably not worth spending too much time on it since it will be fixed in 2.8 by CoW (i.e. depsgraph will no longer ever touch to actual DNA data).

So think this can be closed as 'known bug, won't fix in 2.7x, will be fixed in 2.8'?

Hey, so group objects are not reordered on read file, but according to Dr @Sergey bloody depsgraph can reorder them at some point. This is sort of can of worms, and probably not worth spending too much time on it since it will be fixed in 2.8 by CoW (i.e. depsgraph will no longer ever touch to actual DNA data). So think this can be closed as 'known bug, won't fix in 2.7x, will be fixed in 2.8'?

Philipp Oeser commented

2018-04-16 09:37:27 +02:00

Changed status from 'Open' to: 'Archived'

Philipp Oeser closed this issue

2018-04-16 09:37:27 +02:00

Philipp Oeser commented

2018-04-16 09:37:27 +02:00

as @mont29 said, we will archive this then as 'known bug, won't fix in 2.7x, will be fixed in 2.8'

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

group objects and their counts become mismatched in particle system "use count" list #54257

Now, EITHER: add another object, and change some value for it in the T-Panel (redo panel); OR save and reload the file (the list will show "no object" at first - mouse over it or something to update it).