regression python crash modifying text block #54578

New Issue

mathieu menuet · 2018-04-12T07:42:51+02:00

mathieu menuet commented

2018-04-12 07:42:51 +02:00

System Information
ArchLinux x64

Blender Version
Broken: f55adabb3e5
Worked: d59c2d12b12

Short description of error
Files with a script that tries to modify a text block crash latest master. It didn't happen some days ago.

Exact steps for others to reproduce the error
install https://github.com/JacquesLucke/animation_nodes/releases/download/v2.1_testbuilds_2/animation_nodes_v2_1_linux_py36.zip
Open attached file in f55adabb3e5, it works
Open attached file in f55adabb3e5, it crashes
test crash.blend

crash log: test crash.crash.txt

**System Information** ArchLinux x64 **Blender Version** Broken: f55adabb3e5 Worked: d59c2d12b12 **Short description of error** Files with a script that tries to modify a text block crash latest master. It didn't happen some days ago. **Exact steps for others to reproduce the error** install https://github.com/JacquesLucke/animation_nodes/releases/download/v2.1_testbuilds_2/animation_nodes_v2_1_linux_py36.zip Open attached file in f55adabb3e5, it works Open attached file in f55adabb3e5, it crashes [test crash.blend](https://archive.blender.org/developer/F2666632/test_crash.blend) crash log: [test crash.crash.txt](https://archive.blender.org/developer/F2666648/test_crash.crash.txt)

mathieu menuet commented

2018-04-12 07:42:51 +02:00

Added subscriber: @bliblubli

Philipp Oeser commented

2018-04-12 09:48:40 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-04-12 09:48:40 +02:00

caused by blender/blender@ad1ea9a427

Campbell Barton was assigned by Philipp Oeser

2018-04-12 10:39:55 +02:00

Philipp Oeser commented

2018-04-12 10:39:55 +02:00

Added subscriber: @ideasman42

Philipp Oeser commented

2018-04-12 10:39:55 +02:00

Similar to #54553 (py API doesnt set TextUndoBuf), similar thing as D3139 will fix the crash here, too:
P654: #54578 snippet

diff --git a/source/blender/blenkernel/intern/text.c b/source/blender/blenkernel/intern/text.c
index c7588a4ed48..6ace5b97caf 100644
--- a/source/blender/blenkernel/intern/text.c
+++ b/source/blender/blenkernel/intern/text.c
@@ -531,7 +531,7 @@ void BKE_text_clear(Text *text, TextUndoBuf *utxt) /* called directly from rna *
 	if (utxt) {
 		oldstate = txt_get_undostate();
 	}
-	txt_set_undostate(utxt != NULL);
+	txt_set_undostate(utxt == NULL);
 
 	txt_sel_all(text);
 	txt_delete_sel(text, utxt);

Also not sure how exactly this is meant to work at first sight, @ideasman42: should I continue investigating (just throw back at me...)?

Similar to #54553 (py API doesnt set `TextUndoBuf`), similar thing as [D3139](https://archive.blender.org/developer/D3139) will fix the crash here, too: [P654: #54578 snippet](https://archive.blender.org/developer/P654.txt) ``` diff --git a/source/blender/blenkernel/intern/text.c b/source/blender/blenkernel/intern/text.c index c7588a4ed48..6ace5b97caf 100644 --- a/source/blender/blenkernel/intern/text.c +++ b/source/blender/blenkernel/intern/text.c @@ -531,7 +531,7 @@ void BKE_text_clear(Text *text, TextUndoBuf *utxt) /* called directly from rna * if (utxt) { oldstate = txt_get_undostate(); } - txt_set_undostate(utxt != NULL); + txt_set_undostate(utxt == NULL); txt_sel_all(text); txt_delete_sel(text, utxt); ``` Also not sure how exactly this is meant to work at first sight, @ideasman42: should I continue investigating (just throw back at me...)?

Philipp Oeser commented

2018-04-16 10:55:32 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2018-04-16 10:55:32 +02:00

Philipp Oeser commented

2018-04-16 10:55:32 +02:00

afaict, this is also fixed by blender/blender@fb3528d088, thx @ideasman42 !

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

regression python crash modifying text block #54578