Node editor: Changing object pointers for multiple nodes registers as a single action for undo #54580

New Issue

Konstantins Visnevskis · 2018-04-12T16:50:53+02:00

2018-04-12 16:50:53 +02:00

System Information
win 8.1x64, 3x gtx580

Blender Version
2.79a

Short description of error
Either changing object pointers for multiple nodes or repeated changes of a single node object pointer registers as a single action for undo. Executing Undo reverts all the pointer changes simultaneously, regardless if there were 1 or 10 of them.

obj-ref.blend
Exact steps for others to reproduce the error

In the node editor, change the Object parameter of one, then another Texture Coordinate nodes.
Do Undo.
Object parameter of both changes gets undone.

If this is hard to correct due to some inherent property of particular parameter type, maybe when changing it, the node affected could get selected, as node selection seems to register with undo fine.

**System Information** win 8.1x64, 3x gtx580 **Blender Version** 2.79a **Short description of error** Either changing object pointers for multiple nodes or repeated changes of a single node object pointer registers as a single action for undo. Executing Undo reverts all the pointer changes simultaneously, regardless if there were 1 or 10 of them. [obj-ref.blend](https://archive.blender.org/developer/F2670011/obj-ref.blend) **Exact steps for others to reproduce the error** - In the node editor, change the Object parameter of one, then another Texture Coordinate nodes. - Do Undo. - Object parameter of both changes gets undone. If this is hard to correct due to some inherent property of particular parameter type, maybe when changing it, the node affected could get selected, as node selection seems to register with undo fine.

Konstantins Visnevskis commented

2018-04-12 16:50:53 +02:00

Added subscriber: @KonstantinsVisnevskis

Philipp Oeser commented

2018-04-13 10:12:10 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-04-13 10:12:10 +02:00

This is true for any pointer property afaics [changing any of these wont register in undo on first sight], so nothing particular to the Node editor.
This might be a known limitation, or a design decission, needs further clarification...

This is true for any pointer property afaics [changing any of these wont register in undo on first sight], so nothing particular to the Node editor. This might be a known limitation, or a design decission, needs further clarification...

Philipp Oeser commented

2018-04-13 13:00:17 +02:00

Added subscriber: @ideasman42

Philipp Oeser commented

2018-04-13 13:00:17 +02:00

@ideasman42 : is that something to be investigated further?

Campbell Barton was assigned by Philipp Oeser

2018-06-19 16:01:22 +02:00

Philipp Oeser commented

2018-06-19 16:01:22 +02:00

Soo, looked into this a bit further and it seems like PROP_POINTER buttons indeed dont get undo pushes.
For a little detour: these are not flagged with UI_BUT_UNDO because they are of type UI_BTYPE_SEARCH_MENU (when they get defined via uiDefAutoButR )
Code is explicitly stating (here ) that

/* buttons with value >= UI_BTYPE_SEARCH_MENU don't get undo pushes */

as can be followed [here ]] and https:*developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c;668f39519cec669e970e136af020636794f927d3$741 (we dont get an uiAfterFunc with undostr, so no undo push [ https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c;668f39519cec669e970e136af020636794f927d3$844 | here ...)

If we actually allow SEARCH_MENU buttons [only the ones that represent PROP_POINTER] like in D3489
blender seems to go properly through undosys_step_encode, undosys_step_decode and I didnt run into problems yet.
(but it may very well be that I dont oversee all consequences this might have...)

I think @ideasman42 needs to have a look here though, current behavior could as well be by design and report could be closed...

Soo, looked into this a bit further and it seems like `PROP_POINTER` buttons indeed dont get undo pushes. For a little detour: these are not flagged with `UI_BUT_UNDO` because they are of type `UI_BTYPE_SEARCH_MENU` (when they get defined via [uiDefAutoButR ](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_utils.c;668f39519cec669e970e136af020636794f927d3$137)) Code is explicitly stating ([here ](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/include/UI_interface.h;668f39519cec669e970e136af020636794f927d3$281)) that > /* buttons with value >= UI_BTYPE_SEARCH_MENU don't get undo pushes */ as can be followed [here ]] and [[ https:*developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c;668f39519cec669e970e136af020636794f927d3$741 | here ]] (we dont get an `uiAfterFunc` with undostr, so no undo push [[ https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c;668f39519cec669e970e136af020636794f927d3$844 | here ](https:*developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface.c;668f39519cec669e970e136af020636794f927d3$3260)...) If we actually allow SEARCH_MENU buttons [only the ones that represent `PROP_POINTER`] like in [D3489](https://archive.blender.org/developer/D3489) blender seems to go properly through `undosys_step_encode`, `undosys_step_decode` and I didnt run into problems yet. (but it may very well be that I dont oversee all consequences this might have...) I think @ideasman42 needs to have a look here though, current behavior could as well be by design and report could be closed...

blender-admin commented

2018-12-03 08:43:33 +01:00

This issue was referenced by 6bb825e083

This issue was referenced by 6bb825e0837e5e090c32567d335fe677e33e5ab0

Campbell Barton commented

2018-12-03 08:45:28 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2018-12-03 08:45:28 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node editor: Changing object pointers for multiple nodes registers as a single action for undo #54580