[2.8 Crash] Program crash when extruding+face snap #56167
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#56167
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
win 7 x64
Nvidia 1070 (Gigabyte G1) Drivers: 398.36
Blender Version
Broken: Hash:
66a00b64c5
(date: 2018-07-29 02:12)Short description of error
Crashes when extruding.
The windows console prints this error after crash
Exact steps for others to reproduce the error
1-Open crash3.blend
2- Select an edge of the "RETOPO" object
3- use E to extrude.
4-if doesn't crash try a few times.
[Demo Video]
I know that video its not the way to report bugs but i wasn't able to get an example to properly crash first try, the crashes in the video are lucky first try crashes.
https://www.youtube.com/watch?v=lyjg734Tg2o
Added subscriber: @NahuelBelich
#56471 was marked as duplicate of this issue
Added subscriber: @mont29
Hmmm… Tried like 20 times, could not get a single crash…
Please:
--factory-startup
commandline option) (this will ensure whether this is a userpref or addon issue or not).-t 1
option (single thread mode).-d
option and attach as text file here any error printed out in the console (do not paste it directly in comment).--debug-gpu
option and attach as text file here any error printed out in the console (do not paste it directly in comment).Added subscriber: @s12a
After extruding an edge 3 times with E, I could reproduce the issue on
5300ba0ba5
and:Windows 10 Pro 64 bit (1803)
AMD Radeon RX480 4GB with Radeon Software 18.7.1
I used a debug build, here's the backtrace.
crash3.crash.txt
output.txt
Added subscriber: @mano-wii
@mano-wii looks like crash happens in raycasting code, maybe you are interested in investigating that one? Especially since it seems to only be reproducible on windows. :/
In summary the problem is in the
update_mesh_edit_mode_pointers
anddiscard_mesh_edit_mode_pointers
functions of thedeg_eval_copy_on_write.cc
file.A copy of the
edit_btmesh
frommesh_orig
is done in themesh_cow
. So the samelooptris
pointer is used on both meshes.But when doing an extrusion, the number of looptris changes and the looptris are reallocated in the original mesh causing the
mesh_cow
pointer to be invalid.The looptris are reallocated in the
BKE_editmesh_tessface_calc
function.Added subscribers: @Andruxa696, @CharlieJolly
Added subscriber: @ideasman42
Issue is in fact exact same one as with undo/redo: in macros, when next operator needs access to evaluated data, we have to ensure depsgraph is properly evaluated before calling that next operator:
@ideasman42 issue with patch above is that it needs to set whole transform operator as 'needing evaluated data', which is not a good idea in redo context (when tweaking a transform value in redo panel e.g.). I think we'll actually need to add a new 'flag_poll' callback to operatortype? That way, we could (optionally) return flags finely tuned to actual needs… E.g. in that case, only set
OPTYPE_USE_EVAL_DATA
when we actually do snapping on geometry, etc.I don't really like the idea of keeping a looptris pointer for each object evaluated.
Since the bmesh does not change, these looptris would be exact copies and it would be necessary to make sure to recalculate the looptris in each access.
This is one of the reasons for the reported inefficiency of the transform operator in edit mode.
Since it is not easy to determine when the looptris pointer has been deallocated, the
BKE_editmesh_tessface_calc
function is always called to do arender_data
with looptris in the draw_manager: draw_cache_impl_mesh.c 414 .Therefore the looptris are recalculated at least 3 times at each interaction. One in the
operator transform
to the original mesh, another inDRW_mesh_batch_cache_get_surface_shaded
and one inDRW_mesh_batch_cache_get_overlay_triangles
.Since bmesh does not change, the looptris are the same and should be recalculated only once.
@mano-wii that is kind of separated issue, not directly related to that bug imho.
This issue was referenced by
36429a5bc9
Changed status from 'Open' to: 'Resolved'