Custom property cannot be animated #56636

New Issue

Antonio Vazquez · 2018-08-31T22:22:18+02:00

Antonio Vazquez commented

2018-08-31 22:22:18 +02:00

Blender2.8 Windows 64 bits version 30/08/2018 20:49

If you add a keyframe using I key over the custom property, if you move timeline, you cannot change or animate the custom property.

To reproduce:

Open attached file.
Select cube and in custom properties set "hide" property to 0
Over "hide" property, press I to insert keyframe
Move the timeline and try to change hide prop or insert a new keyframe

I noticed also some random blender crashes when clear the property keyframe of hide property.

I have tested the same in 2.79b and works.

Driver_280.blend

Blender2.8 Windows 64 bits version 30/08/2018 20:49 If you add a keyframe using I key over the custom property, if you move timeline, you cannot change or animate the custom property. To reproduce: 1) Open attached file. 2) Select cube and in custom properties set "hide" property to 0 3) Over "hide" property, press I to insert keyframe 4) Move the timeline and try to change hide prop or insert a new keyframe I noticed also some random blender crashes when clear the property keyframe of hide property. I have tested the same in 2.79b and works. [Driver_280.blend](https://archive.blender.org/developer/F4488493/Driver_280.blend)

Antonio Vazquez commented

2018-08-31 22:22:18 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2018-08-31 22:25:15 +02:00

I have pasted the log of one the crashes P775

I have pasted the log of one the crashes [P775](https://archive.blender.org/developer/P775.txt)

Antonio Vazquez commented

2018-08-31 22:53:39 +02:00

I could reproduce the error with the default scene:

Open default scene
Select default cube
Add a custom prop (the default name is prop)
Press N and in properties enter any value to "prop"
Press I over prop
Now try to move timeline and insert a new value in the prop.

I could reproduce the error with the default scene: 1) Open default scene 2) Select default cube 3) Add a custom prop (the default name is prop) 4) Press N and in properties enter any value to "prop" 5) Press I over prop 6) Now try to move timeline and insert a new value in the prop.

Bastien Montagne commented

2018-09-03 16:22:33 +02:00

Added subscribers: @Sergey, @JoshuaLeung, @mont29

Bastien Montagne commented

2018-09-03 16:22:33 +02:00

Reminds me of similar issue with some VSE properties in 2.7x… IIRC, animation gets re-evaluated when editing those values, hence they get reset to animated value immediately…

@JoshuaLeung, @Sergey, not sure whether we have standard fix for those cases?

Reminds me of similar issue with some VSE properties in 2.7x… IIRC, animation gets re-evaluated when editing those values, hence they get reset to animated value immediately… @JoshuaLeung, @Sergey, not sure whether we have standard fix for those cases?

Philipp Oeser commented

2018-10-19 13:14:52 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-10-19 13:14:52 +02:00

@antoniov: asked in IRC if I could also have a look, and here are my findings (sorry for the lengthy detour, this might all be totally obvious for others...)

Changing a value in a (already keyed) custom property will go through dependency graph DEG_OPCODE_ANIMATION and thus calls BKE_animsys_eval_animdata (where this all gets evaluated/reset to the current fcurve value)
deg_graph_id_tag_update: id=OBCube flags=TRANSFORM, GEOMETRY, TIME, triggered here

Changing a value for e.g. posx wont do this:
deg_graph_id_tag_update: id=OBCube flags=TRANSFORM
deg_graph_id_tag_update: id=OBCube flags=COPY_ON_WRITE

if I remove the TIME dependency (like P802), this will obviously work (but will probably lack updates elsewhere [drivers...])

From comments in code I was first expecting AnimOverride to take care of this [see animsys_evaluate_overrides()], but in fact these dont seem to be used at all?

Will have a look next how this survives in 2.79 with the new dependency graph...

@antoniov: asked in IRC if I could also have a look, and here are my findings (sorry for the lengthy detour, this might all be totally obvious for others...) Changing a value in a (already keyed) `custom property` will go through dependency graph DEG_OPCODE_ANIMATION and thus calls BKE_animsys_eval_animdata (where this all gets evaluated/reset to the current fcurve value) deg_graph_id_tag_update: id=OBCube flags=TRANSFORM, GEOMETRY, TIME, triggered [here ](https://developer.blender.org/diffusion/B/browse/blender2.8/source/blender/makesrna/intern/rna_access.c;51b2d06613bb3a11a04f051d7dabaa6530a0e5c0$2100) Changing a value for e.g. `posx` wont do this: deg_graph_id_tag_update: id=OBCube flags=TRANSFORM deg_graph_id_tag_update: id=OBCube flags=COPY_ON_WRITE if I remove the TIME dependency (like [P802](https://archive.blender.org/developer/P802.txt)), this will obviously work (but will probably lack updates elsewhere [drivers...]) From comments in code I was first expecting `AnimOverride` to take care of this [see animsys_evaluate_overrides()], but in fact these dont seem to be used at all? Will have a look next how this survives in 2.79 with the new dependency graph...

Philipp Oeser commented

2018-10-19 13:27:10 +02:00

Another thing I noticed when having an animated custom property is that even other keyframes might not be evaluated anymore (and this is even true for 2.79 with new depsgraph)...:

Open default scene
Select default cube
Add a custom prop (the default name is prop)
Press N and in properties enter any value to "prop"
Press I over prop
insert single keyframe on locx
move one frame forward, change locx to 1, insert single keyframe on locx again
change frames --> transform is not updated! [even though it is keyed]
this goes back to normal evaluation after file reload

(more detailed depsgraph info in P803)

Another thing I noticed when having an animated custom property is that even other keyframes might not be evaluated anymore (and this is even true for 2.79 with new depsgraph)...: - Open default scene - Select default cube - Add a custom prop (the default name is prop) - Press N and in properties enter any value to "prop" - Press I over prop - insert single keyframe on locx - move one frame forward, change locx to 1, insert single keyframe on locx again - change frames --> **transform is not updated! [even though it is keyed]** - this goes back to normal evaluation after file reload (more detailed depsgraph info in [P803](https://archive.blender.org/developer/P803.txt))

Sergey Sharybin commented

2018-10-22 16:17:43 +02:00

Initially reported bug is caused by ID properties always tagging for time update. Doing something like this P806 solves the issue.

My guess is this is because old depsgraph was ignoring time update if animation data wasn't tagged for update. The new code with proposed i think is correct.

Not sure it's the same issue as @lichtwerk did report.

Initially reported bug is caused by ID properties always tagging for time update. Doing something like this [P806](https://archive.blender.org/developer/P806.txt) solves the issue. My guess is this is because old depsgraph was ignoring time update if animation data wasn't tagged for update. The new code with proposed i *think* is correct. Not sure it's the same issue as @lichtwerk did report.

Philipp Oeser commented

2018-10-22 16:34:58 +02:00

@Sergey: thought so, too [P802 == P806 :)]
(if that doesnt cause bad stuff elsewhere: great)

second issue remains though [the one with not updating transform -- see above. Should I move this to a separate report?]

@Sergey: thought so, too [[P802](https://archive.blender.org/developer/P802.txt) == [P806](https://archive.blender.org/developer/P806.txt) :)] (if that doesnt cause bad stuff elsewhere: great) second issue remains though [the one with not updating transform -- see above. Should I move this to a separate report?]

blender-admin commented

2018-10-22 16:43:49 +02:00

This issue was referenced by b4ebb9d8ef

This issue was referenced by b4ebb9d8efb202221834475e1c06b0ae3e4ffe77

Sergey Sharybin commented

2018-10-22 16:50:58 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2018-10-22 16:50:58 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Custom property cannot be animated #56636