Culling not working correctly when using array modifier #57389

Closed
opened 2018-10-26 11:07:16 +02:00 by Mal Duffin · 9 comments
Member

System Information
Windows 10, GTX1070

Blender Version
Broken: Blender 2.8 Alpha 2 e66084268c

Short description of error

When you add an array modifier to an object, and move the original object off-screen ( with the cloned objects still on-screen ), the cloned objects disappear.

Exact steps for others to reproduce the error

  1. Start a new scene
  2. Add an array modifier to the cube ( make the count something like 10 )
  3. Move the group so that the original cube is off-screen - the rest of the cubes will disappear.

Note that if you save and re-load this file, the culling is fine, so I wasn't able to attach a .blend to show this.

**System Information** Windows 10, GTX1070 **Blender Version** Broken: Blender 2.8 Alpha 2 e66084268cc **Short description of error** When you add an array modifier to an object, and move the original object off-screen ( with the cloned objects still on-screen ), the cloned objects disappear. **Exact steps for others to reproduce the error** 1) Start a new scene 2) Add an array modifier to the cube ( make the count something like 10 ) 3) Move the group so that the original cube is off-screen - the rest of the cubes will disappear. Note that if you save and re-load this file, the culling is fine, so I wasn't able to attach a .blend to show this.
Author
Member

Added subscriber: @MalDuffin

Added subscriber: @MalDuffin
Member

Added subscribers: @mont29, @lichtwerk

Added subscribers: @mont29, @lichtwerk
Bastien Montagne was assigned by Philipp Oeser 2018-10-26 13:48:28 +02:00
Member

Can confirm, indeed caused by e66084268c.

This is not only affecting view culling but also Bounds display_type etc..
(Interestingly before that commit [while dimension were broken] bounds drawing was actually fine...)

You can also go in and out of editmode (or change some prop on the array modifier) to get your proper bounds back (BKE_mesh_eval_geometry() gets called), but as soon as you start transforming, you will loose it again (because BKE_object_eval_done() kicks in again)

Still not familiar enough with dependency graph, @mont29: looks like bbox is calculated for "non-obdata-evaluated" object? (need to read more [depsgraph-]code here...)

Can confirm, indeed caused by e66084268c. This is not only affecting view culling but also Bounds display_type etc.. (Interestingly before that commit [while dimension were broken] bounds drawing was actually fine...) You can also go in and out of editmode (or change some prop on the array modifier) to get your proper bounds back (`BKE_mesh_eval_geometry()` gets called), but as soon as you start transforming, you will loose it again (because `BKE_object_eval_done()` kicks in again) Still not familiar enough with dependency graph, @mont29: looks like bbox is calculated for "non-obdata-evaluated" object? (need to read more [depsgraph-]code here...)

Added subscriber: @brecht

Added subscriber: @brecht

I think the bounding box is being computed too early, after the transform but before modifiers are evaluated.

It might need to be in both the object transform and mesh update, because they could be updated independently.

I think the bounding box is being computed too early, after the transform but before modifiers are evaluated. It might need to be in both the object transform and mesh update, because they could be updated independently.
Member

btw. we have another (possibly related) boundingbox issue in #57070...

btw. we have another (possibly related) boundingbox issue in #57070...

Just a follow up here, current bbox code is actually a real nightmare to follow, and is doing lots of bad things (now that we are in COW era)… Still working on trying to understand what happens, and how to fix it. :|

Just a follow up here, current bbox code is actually a real nightmare to follow, and is doing lots of bad things (now that we are in COW era)… Still working on trying to understand what happens, and how to fix it. :|

This issue was referenced by 5f6fae9ad0

This issue was referenced by 5f6fae9ad0bdb4184fb430d533dbbdec9c3da67f

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#57389
No description provided.