Driver on grease pencil modifier does not update for redraw #57483

New Issue

Antonio Vazquez · 2018-10-29T10:15:35+01:00

Antonio Vazquez commented

2018-10-29 10:15:35 +01:00

If add a driver that handle a property in a grease pencil modifier, the grease pencil datablock (GPD) must be tagged as dirty (DEG_id_tag_update(&gpd->id, OB_RECALC_OB | OB_RECALC_DATA)).

The problem is the property change in the modifier, but as the driver did not tagged the datablock as dirty, the drawing cache is not updated and the image in viewport does not change (only change if change the current frame number that force a redraw).

Here is the test file.

TEST_DRIVER_SIMPLE.blend

If add a driver that handle a property in a grease pencil modifier, the grease pencil datablock (GPD) must be tagged as dirty (DEG_id_tag_update(&gpd->id, OB_RECALC_OB | OB_RECALC_DATA)). The problem is the property change in the modifier, but as the driver did not tagged the datablock as dirty, the drawing cache is not updated and the image in viewport does not change (only change if change the current frame number that force a redraw). ![Driver_Evaluation.png](https://archive.blender.org/developer/F5281449/Driver_Evaluation.png) Here is the test file. [TEST_DRIVER_SIMPLE.blend](https://archive.blender.org/developer/F5281454/TEST_DRIVER_SIMPLE.blend)

Antonio Vazquez commented

2018-10-29 10:15:35 +01:00

Added subscriber: @antoniov

blender-admin commented

2018-10-29 10:15:35 +01:00

#62514 was marked as duplicate of this issue

Dalai Felinto commented

2018-10-29 13:03:13 +01:00

Added subscribers: @dfelinto, @Sergey

Dalai Felinto commented

2018-10-29 13:03:14 +01:00

@antoniov : depsgraph is the one responsible for those tags. You need to build a relation between the driver and the grease pencil object.
Later (tomorrow) I can nspect the depsgraph to see what is going on. If you want to try in the meantime, enable the dependency graph addon, and dump the depsgraph as image.

@antoniov : depsgraph is the one responsible for those tags. You need to build a relation between the driver and the grease pencil object. Later (tomorrow) I can nspect the depsgraph to see what is going on. If you want to try in the meantime, enable the dependency graph addon, and dump the depsgraph as image.

Dalai Felinto commented

2018-10-29 13:27:04 +01:00

For the records, you will need to install graphviz and gnuplot for that:

https://graphviz.gitlab.io/_pages/Download/windows/graphviz-2.38.msi
https://sourceforge.net/projects/gnuplot/files/gnuplot/

As well as making sure their respective bin directory is in the %PATH%.

For the records, you will need to install graphviz and gnuplot for that: https://graphviz.gitlab.io/_pages/Download/windows/graphviz-2.38.msi https://sourceforge.net/projects/gnuplot/files/gnuplot/ As well as making sure their respective bin directory is in the %PATH%.

Dalai Felinto commented

2018-10-29 13:32:11 +01:00

I simplified your file a bit:
driver.blend

It produces the following depsgraph:

I simplified your file a bit: [driver.blend](https://archive.blender.org/developer/F5282888/driver.blend) It produces the following depsgraph: ![depsgraph.jpg](https://archive.blender.org/developer/F5282904/depsgraph.jpg)

Philipp Oeser commented

2018-10-30 15:28:55 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-10-30 15:28:55 +01:00

Hm, was also looking into this, but havent found the issue (yet)

I've verified that a relation bone --> stroke modifier gets added in DepsgraphRelationBuilder::build_driver_variables

But we are missing a BKE_object_eval_uber_data on the grasepencil.

I've also verified that this is called in DepsgraphNodeBuilder::build_object_data_geometry , so that should make BKE_object_eval_uber_data() the exit for greasepencil as well?

[SCScene :: RenderLayer]: Operation is entry point for update: POSE_DONE()
[SCScene :: RenderLayer]: Operation is entry point for update: POSE_INIT_IK()
[SCScene :: RenderLayer]: Operation is entry point for update: POSE_INIT()
[SCScene :: RenderLayer]: Operation is entry point for update: COPY_ON_WRITE()
[SCScene :: RenderLayer]: Operation is entry point for update: PLACEHOLDER(Armature Eval)
[SCScene :: RenderLayer]: Operation is entry point for update: COPY_ON_WRITE()
[SCScene :: RenderLayer]: Accumulated recalc bits for OBCube: 17
[SCScene :: RenderLayer]: Accumulated recalc bits for OBArmature: 81
[SCScene :: RenderLayer]: Accumulated recalc bits for ARArmature: 4294967109
[SCScene :: RenderLayer]: Accumulated recalc bits for OBStroke: 1
[SCScene :: RenderLayer]: deg_evaluate_copy_on_write on ARArmature (0x7f94a0fc7788)
[SCScene :: RenderLayer]: deg_evaluate_copy_on_write on OBArmature (0x7f949b4e9c08)
[SCScene :: RenderLayer]: BKE_pose_eval_init on OBArmature (0x7f949b4e9c08)
[SCScene :: RenderLayer]: BKE_pose_eval_init_ik on OBArmature (0x7f949b4e9c08)
[SCScene :: RenderLayer]: BKE_pose_eval_bone on OBArmature (0x7f949b4e9c08) pchan Bone (0x7f94a44e5008)
[SCScene :: RenderLayer]: BKE_pose_bone_done on Bone (0x7f94a44e5008)
[SCScene :: RenderLayer]: BKE_pose_eval_flush on OBArmature (0x7f949b4e9c08)
[SCScene :: RenderLayer]: BKE_animsys_eval_driver on OBStroke (0x7f94cc323008) fcu grease_pencil_modifiers["Offset"].rotation[1] (0x7f94a2304108)
[SCScene :: RenderLayer]: BKE_animsys_eval_driver on OBCube (0x7f949b4eb408) fcu modifiers["SimpleDeform"].angle[0] (0x7f94a4f09088)
[SCScene :: RenderLayer]: BKE_object_eval_uber_data on OBCube (0x7f949b4eb408)

Guess I have to read some more.
Also noticed that DepsgraphNodeBuilder::build_gpencil() and DepsgraphRelationBuilder::build_gpencil() are apperently unused? (build_animdata() is called from elsewhere anyways...)
Did I say I have to read some more ;)?

Hm, was also looking into this, but havent found the issue (yet) I've verified that a relation `bone --> stroke modifier` gets added in [DepsgraphRelationBuilder::build_driver_variables ](https://developer.blender.org/diffusion/B/browse/blender2.8/source/blender/depsgraph/intern/builder/deg_builder_relations.cc;2dbddaf3be57142a70fc1fb8f46997d67e980f57$1448) But we are missing a `BKE_object_eval_uber_data` on the grasepencil. I've also verified that this is called in [DepsgraphNodeBuilder::build_object_data_geometry ](https://developer.blender.org/diffusion/B/browse/blender2.8/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc;2dbddaf3be57142a70fc1fb8f46997d67e980f57$1174), so that should make `BKE_object_eval_uber_data()` the exit for greasepencil as well? ``` [SCScene :: RenderLayer]: Operation is entry point for update: POSE_DONE() [SCScene :: RenderLayer]: Operation is entry point for update: POSE_INIT_IK() [SCScene :: RenderLayer]: Operation is entry point for update: POSE_INIT() [SCScene :: RenderLayer]: Operation is entry point for update: COPY_ON_WRITE() [SCScene :: RenderLayer]: Operation is entry point for update: PLACEHOLDER(Armature Eval) [SCScene :: RenderLayer]: Operation is entry point for update: COPY_ON_WRITE() [SCScene :: RenderLayer]: Accumulated recalc bits for OBCube: 17 [SCScene :: RenderLayer]: Accumulated recalc bits for OBArmature: 81 [SCScene :: RenderLayer]: Accumulated recalc bits for ARArmature: 4294967109 [SCScene :: RenderLayer]: Accumulated recalc bits for OBStroke: 1 [SCScene :: RenderLayer]: deg_evaluate_copy_on_write on ARArmature (0x7f94a0fc7788) [SCScene :: RenderLayer]: deg_evaluate_copy_on_write on OBArmature (0x7f949b4e9c08) [SCScene :: RenderLayer]: BKE_pose_eval_init on OBArmature (0x7f949b4e9c08) [SCScene :: RenderLayer]: BKE_pose_eval_init_ik on OBArmature (0x7f949b4e9c08) [SCScene :: RenderLayer]: BKE_pose_eval_bone on OBArmature (0x7f949b4e9c08) pchan Bone (0x7f94a44e5008) [SCScene :: RenderLayer]: BKE_pose_bone_done on Bone (0x7f94a44e5008) [SCScene :: RenderLayer]: BKE_pose_eval_flush on OBArmature (0x7f949b4e9c08) [SCScene :: RenderLayer]: BKE_animsys_eval_driver on OBStroke (0x7f94cc323008) fcu grease_pencil_modifiers["Offset"].rotation[1] (0x7f94a2304108) [SCScene :: RenderLayer]: BKE_animsys_eval_driver on OBCube (0x7f949b4eb408) fcu modifiers["SimpleDeform"].angle[0] (0x7f94a4f09088) [SCScene :: RenderLayer]: BKE_object_eval_uber_data on OBCube (0x7f949b4eb408) ``` Guess I have to read some more. Also noticed that DepsgraphNodeBuilder::build_gpencil() and DepsgraphRelationBuilder::build_gpencil() are apperently unused? (build_animdata() is called from elsewhere anyways...) Did I say I have to read some more ;)?

Antonio Vazquez commented

2018-11-22 10:49:34 +01:00

@lichtwerk Do you have any update about this?

Berbank Green commented

2019-01-07 18:12:18 +01:00

Added subscriber: @BerbankGreen

Brecht Van Lommel changed title from ~~Driver evaluation must tag grease pencil datablock for redraw~~ to Driver on grease pencil modifier does not update for redraw

2019-03-14 19:37:30 +01:00

Joe Wallace commented

2019-03-18 16:58:46 +01:00

Added subscriber: @joewc

Joe Wallace commented

2019-03-18 16:58:46 +01:00

Hello my friends!
Same problem with blender 2.8

System Information
Operating system: Windows 7 sp1
Graphics card: NVIDIA [GeForce GTX 675M] driver: nvidia v: 391.35

Device-1: Intel Core Processor Integrated Graphics driver: i7 3720QM
Device-2: 16gb RAM

Blender crash Version
blender-2.80-cc5bdf029324-win64.zip download 17/03/2019

Short description of error
Drivers link as empty to modifiers (time offset - mode: fixed frame) no realtime keyframe updates.

The old building version works fine: blender-2.80-790cb7799dcf-win64.zip - download 19/02/2019.

Thank you for yours hard work and sorry for my bad english.

Hello my friends! Same problem with blender 2.8 System Information Operating system: Windows 7 sp1 Graphics card: NVIDIA [GeForce GTX 675M] driver: nvidia v: 391.35 Device-1: Intel Core Processor Integrated Graphics driver: i7 3720QM Device-2: 16gb RAM **Blender crash Version** blender-2.80-cc5bdf029324-win64.zip download 17/03/2019 Short description of error Drivers link as empty to modifiers (time offset - mode: fixed frame) no realtime keyframe updates. **The old building version works fine: blender-2.80-790cb7799dcf-win64.zip - download 19/02/2019.** Thank you for yours hard work and sorry for my bad english.

Antonio Vazquez commented

2019-03-30 09:05:20 +01:00

@Sergey Can you help us here?

Sergey Sharybin self-assigned this 2019-03-30 20:58:16 +01:00

Sergey Sharybin commented

2019-03-30 20:58:16 +01:00

@antoniov, will check next week.

P.S. Probably better to assign to me, so it's not lost in the stream of incoming mail, and can always be accessed from assigned tasks.

@antoniov, will check next week. P.S. Probably better to assign to me, so it's not lost in the stream of incoming mail, and can always be accessed from assigned tasks.

Brecht Van Lommel commented

2019-04-04 05:58:56 +02:00

Added subscribers: @heini, @AnnaIv, @brecht

Samuel Santos commented

2019-04-15 06:01:20 +02:00

Added subscriber: @SamuelTelles

Samuel Santos commented

2019-04-15 06:01:20 +02:00

Hi, people.
Having the same problem with the "time offset" modifier, but I can tell you this was working very nicely on "blender-2.80-860a9f979d60-win64". It's pretty useful to develop complex rigs with GP. Attaching my blend file.. just in case.

test driver time offset.blend

Hi, people. Having the same problem with the "time offset" modifier, but I can tell you this was working very nicely on "blender-2.80-860a9f979d60-win64". It's pretty useful to develop complex rigs with GP. Attaching my blend file.. just in case. [test driver time offset.blend](https://archive.blender.org/developer/F6946661/test_driver_time_offset.blend)

Noah Smith commented

2019-05-28 03:25:14 +02:00

Added subscriber: @NoahJamesBradleySmith-2

Noah Smith commented

2019-05-28 03:25:14 +02:00

driver.blend Same problem here. Attached my blend file in case anyone wants a look at it.

[driver.blend](https://archive.blender.org/developer/F7073667/driver.blend) Same problem here. Attached my blend file in case anyone wants a look at it.

Antonio Vazquez commented

2019-05-28 08:56:58 +02:00

@lichtwerk Maybe this bug must be set as High to be fixed before release. What do you think?